* [dpdk-stable] [PATCH] net/mlx5: fix TSO inline size calculation
@ 2017-10-25 23:30 Yongseok Koh
2017-10-26 5:48 ` Shahaf Shuler
2017-10-26 8:27 ` Nélio Laranjeiro
0 siblings, 2 replies; 4+ messages in thread
From: Yongseok Koh @ 2017-10-25 23:30 UTC (permalink / raw)
To: adrien.mazarguil, nelio.laranjeiro
Cc: dev, Yongseok Koh, stable, Shachar Beiser
When "net/mlx5: replace network to host macros" is rebased for v4, changes
of "net/mlx5: fix calculating TSO inline size" have been reverted.
Fixes: 6b30a6a8552a ("net/mlx5: replace network to host macros")
Cc: stable@dpdk.org
Cc: Shachar Beiser <shacharbe@mellanox.com>
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_rxtx.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index af0a75546..7785ced44 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -558,14 +558,8 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)
break;
max_wqe -= n;
if (tso) {
- uint32_t inl =
- rte_cpu_to_be_32(copy_b |
- MLX5_INLINE_SEG);
-
- pkt_inline_sz =
- MLX5_WQE_DS(tso_header_sz) *
- MLX5_WQE_DWORD_SIZE;
-
+ inl = rte_cpu_to_be_32(copy_b |
+ MLX5_INLINE_SEG);
rte_memcpy((void *)raw,
(void *)&inl, sizeof(inl));
raw += sizeof(inl);
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [PATCH] net/mlx5: fix TSO inline size calculation
2017-10-25 23:30 [dpdk-stable] [PATCH] net/mlx5: fix TSO inline size calculation Yongseok Koh
@ 2017-10-26 5:48 ` Shahaf Shuler
2017-10-26 8:27 ` Nélio Laranjeiro
1 sibling, 0 replies; 4+ messages in thread
From: Shahaf Shuler @ 2017-10-26 5:48 UTC (permalink / raw)
To: Yongseok Koh, Adrien Mazarguil, Nélio Laranjeiro
Cc: dev, Yongseok Koh, stable, Shachar Beiser
Thursday, October 26, 2017 2:31 AM, Yongseok Koh:
> When "net/mlx5: replace network to host macros" is rebased for v4, changes
> of "net/mlx5: fix calculating TSO inline size" have been reverted.
>
> Fixes: 6b30a6a8552a ("net/mlx5: replace network to host macros")
> Cc: stable@dpdk.org
> Cc: Shachar Beiser <shacharbe@mellanox.com>
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index af0a75546..7785ced44 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -558,14 +558,8 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf
> **pkts, uint16_t pkts_n)
> break;
> max_wqe -= n;
> if (tso) {
> - uint32_t inl =
> - rte_cpu_to_be_32(copy_b |
> - MLX5_INLINE_SEG);
> -
> - pkt_inline_sz =
> -
> MLX5_WQE_DS(tso_header_sz) *
> - MLX5_WQE_DWORD_SIZE;
> -
> + inl = rte_cpu_to_be_32(copy_b |
> +
> MLX5_INLINE_SEG);
> rte_memcpy((void *)raw,
> (void *)&inl, sizeof(inl));
> raw += sizeof(inl);
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> --
> 2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [PATCH] net/mlx5: fix TSO inline size calculation
2017-10-25 23:30 [dpdk-stable] [PATCH] net/mlx5: fix TSO inline size calculation Yongseok Koh
2017-10-26 5:48 ` Shahaf Shuler
@ 2017-10-26 8:27 ` Nélio Laranjeiro
2017-10-26 22:25 ` Ferruh Yigit
1 sibling, 1 reply; 4+ messages in thread
From: Nélio Laranjeiro @ 2017-10-26 8:27 UTC (permalink / raw)
To: Yongseok Koh; +Cc: adrien.mazarguil, dev, stable, Shachar Beiser
On Wed, Oct 25, 2017 at 04:30:40PM -0700, Yongseok Koh wrote:
> When "net/mlx5: replace network to host macros" is rebased for v4, changes
> of "net/mlx5: fix calculating TSO inline size" have been reverted.
>
> Fixes: 6b30a6a8552a ("net/mlx5: replace network to host macros")
> Cc: stable@dpdk.org
> Cc: Shachar Beiser <shacharbe@mellanox.com>
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [PATCH] net/mlx5: fix TSO inline size calculation
2017-10-26 8:27 ` Nélio Laranjeiro
@ 2017-10-26 22:25 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2017-10-26 22:25 UTC (permalink / raw)
To: Nélio Laranjeiro, Yongseok Koh
Cc: adrien.mazarguil, dev, stable, Shachar Beiser
On 10/26/2017 1:27 AM, Nélio Laranjeiro wrote:
> On Wed, Oct 25, 2017 at 04:30:40PM -0700, Yongseok Koh wrote:
>> When "net/mlx5: replace network to host macros" is rebased for v4, changes
>> of "net/mlx5: fix calculating TSO inline size" have been reverted.
>>
>> Fixes: 6b30a6a8552a ("net/mlx5: replace network to host macros")
>> Cc: stable@dpdk.org
>> Cc: Shachar Beiser <shacharbe@mellanox.com>
>>
>> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-26 22:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-25 23:30 [dpdk-stable] [PATCH] net/mlx5: fix TSO inline size calculation Yongseok Koh
2017-10-26 5:48 ` Shahaf Shuler
2017-10-26 8:27 ` Nélio Laranjeiro
2017-10-26 22:25 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).