From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id CAB471B279 for ; Mon, 30 Oct 2017 16:36:07 +0100 (CET) Received: by mail-wr0-f193.google.com with SMTP id y9so13038853wrb.2 for ; Mon, 30 Oct 2017 08:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vo/ASPrrIJqjLexwvr76YD0VXm9X0mrNzh1eB+BW+U0=; b=IOpjYFOWeh+pUJty5TeLXJWfZqiQvm1psD3AE49KK2esc5SdHU2gwoW1hPuriMn/AB ddKSCqlTD4CHfetFkinB1dYYiPIchDyJYu/1aRUwlRHMeooGQk9qVJT9l3oSikwKGrYW IWxm48Wx9PuQFQsQfYcbtvbDLJxVt1xXZUDoIOyIv1JzvvI9WRdw+zkkIkTBWnp5lfbt uLp5YZGBUKy2A+mSJOE82rs++cA5PHKsuNK8uq4u2OTYvxOQlAxGa1f799yV04pSzOhF xYfEbERLYTML5DDzwgWINssxvGEb84UmdfOwwBEU3QLz1jyDjp2hLRssKZZJzHHlCj8h aXKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vo/ASPrrIJqjLexwvr76YD0VXm9X0mrNzh1eB+BW+U0=; b=FEnF4/Ags8E6CGUOm86LJsDV7Mxa4gnyVLs1psLyAAonZ9z+7THeapjw9TbKawjVd/ GNkvQ2eDu9BqNnpGGuyVXNP3CC6FmRsm4xGqOyEQI/SNNOiN1pf/HGrEB7pS4Zg4xEYv rglV3gM2ijQm5aZ127fkwxXDj61Tz+izIHxqhpdS5F9xNWdGRUN4nysRA6rlPP1SKQDb 1cHBsD5FOsDSP0Vk0zNvyLjrwY4eXDd0y9G4VrdK3VrETCmEpk27eP53fxCTpapeZVM7 BFGSLf+8duacpJ8wq/qbw1eJ9y0O9mlT5VWekSVkshuXojb7dDxoy0Q4cSpvKgle6Etf SaJw== X-Gm-Message-State: AMCzsaVzeuEVT1Sn2AIcHjcKW+xVOmHxN5oKwxv5A1wkyINt1mHaJmHO Ej5hkynB5ilyedgQS/GbfEhJIPuTI9I= X-Google-Smtp-Source: ABhQp+TdUZcPRs0ZaNUu5UUyObSNTBapRLwsMig8UaGtmb6WQzOwx2LWDkX6gv2aYvCJFcmaKSzrxg== X-Received: by 10.223.176.214 with SMTP id j22mr9042321wra.24.1509377767515; Mon, 30 Oct 2017 08:36:07 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id x65sm1117372wmg.11.2017.10.30.08.36.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Oct 2017 08:36:06 -0700 (PDT) From: luca.boccassi@gmail.com To: Congwen Zhang Cc: Rahul Lakkireddy , dpdk stable Date: Mon, 30 Oct 2017 15:34:16 +0000 Message-Id: <20171030153511.13322-13-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171030153511.13322-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/cxgbe: fix memory leak' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 15:36:07 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From 1ad0dee5e84b22ddab5dcc8e056da10780b42d8c Mon Sep 17 00:00:00 2001 From: Congwen Zhang Date: Tue, 5 Sep 2017 16:46:57 +0800 Subject: [PATCH] net/cxgbe: fix memory leak [ upstream commit c0b865d4717d85138f716d42ca186672b060f166 ] In function t4_wr_mbox_meat_timeout(), dynamic memory stored in 'temp' variable and it is not freed when the function return, this is a possible memory leak. Fixes: 3bd122eef2cc ("cxgbe/base: add hardware API for Chelsio T5 series adapters") Signed-off-by: Congwen Zhang Acked-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_hw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/cxgbe/base/t4_hw.c b/drivers/net/cxgbe/base/t4_hw.c index 19afdac92..565a6959c 100644 --- a/drivers/net/cxgbe/base/t4_hw.c +++ b/drivers/net/cxgbe/base/t4_hw.c @@ -403,6 +403,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox, t4_os_atomic_list_del(&entry, &adap->mbox_list, &adap->mbox_lock); t4_report_fw_error(adap); + free(temp); return (pcie_fw & F_PCIE_FW_ERR) ? -ENXIO : -EBUSY; } @@ -446,6 +447,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox, &adap->mbox_list, &adap->mbox_lock)); t4_report_fw_error(adap); + free(temp); return (v == X_MBOWNER_FW ? -EBUSY : -ETIMEDOUT); } @@ -546,6 +548,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox, T4_OS_MBOX_LOCKING( t4_os_atomic_list_del(&entry, &adap->mbox_list, &adap->mbox_lock)); + free(temp); return -G_FW_CMD_RETVAL((int)res); } } -- 2.11.0