From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 1283C1B249 for ; Mon, 30 Oct 2017 16:36:15 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id r68so17318213wmr.3 for ; Mon, 30 Oct 2017 08:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=42+64p0F7SYnycp6Nh3ZkidWPW9AvhX7Tph5Dodwztc=; b=CUtqr9s3yC3LZOxMLMEsnW/L4rhGBsu1E7i7Crr3wqM9gCd8pw5sYmDVjs8w7otQgn C+NZmRrUegnqhfFsEU59Wa23Y/zV5HfZV2o0v5XDbXR6UnmgVkvqFhyCox0GlPTOjJwH c9SWOCgu0enZtHczeclAphwamjfQuswqPXRGwfTAhXyTaxeK5awO+vZpyB+YyWTK6267 fAcje8UAs8oFtzGL6kxYFOByE+gf20OOTzIQwOz1ID0lye8l+YUUGV04xuWBtJYnRXXE ungBaDdQgqUcQyAqpqt5vXwScLjFaPipQ20c73Jio9l2xmFA6X5ZUSEQFkyUU116DzVc PoqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=42+64p0F7SYnycp6Nh3ZkidWPW9AvhX7Tph5Dodwztc=; b=Y09Bm4tLuimKVqTAgj9f+3+NgAG3BnAdo6XqH1Oz8BDEFSicFkK7e+4leJ667ZCpjR c6Uga6kL5h7mcqIzaDLBiolun4I3ekmjyJjulTzquygICQD/mdOb61P4mPaOYA/WXeRr AshLNEnPsbYzpAFLA7SP8+OOSWnRKXw8RajKUSqTfyP13zUty3L16k/P4VC23Pj1tMRL V5CiR0XeJKnxBluFibef98Ep7OoaDIGTXxDH/JPFA+oSPTHgcbO/Kkvd4/MduDBGGnox 6sNqWshIA8Th4tZZ5ooy3FjpnxYNHjjxk5R9CRdXwqfQUQGS4YjVccYjS2aj6aoLNxc/ Pgnw== X-Gm-Message-State: AMCzsaUKfEkiU+ODeRh68DZVx5fTtiy7WqovxfrbZ+UDd5Zszok4Xqdn hzbrmEherHn00pK7em/ZdU4= X-Google-Smtp-Source: ABhQp+RPugBJnRIqz6bDI4vqdp0maObpR7z4a6xAi2ZEQS5b9pWjp5OWJc9y1F4OSbletCE2Jlplhg== X-Received: by 10.28.143.212 with SMTP id r203mr4059877wmd.44.1509377774761; Mon, 30 Oct 2017 08:36:14 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id c37sm20479069wrc.92.2017.10.30.08.36.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Oct 2017 08:36:14 -0700 (PDT) From: luca.boccassi@gmail.com To: Shahaf Shuler Cc: Yongseok Koh , Nelio Laranjeiro , dpdk stable Date: Mon, 30 Oct 2017 15:34:21 +0000 Message-Id: <20171030153511.13322-18-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171030153511.13322-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/mlx5: fix Tx stats error counter definition' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 15:36:15 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From 27f6f90e4cc763c87b2d51bde6075f9a4fa06722 Mon Sep 17 00:00:00 2001 From: Shahaf Shuler Date: Thu, 14 Sep 2017 13:50:37 +0300 Subject: [PATCH] net/mlx5: fix Tx stats error counter definition [ upstream commit 9f9a48eb2978157954242e08acf81d7a26f38810 ] The current Tx error counter counts, according to its description, the total number of packets not sent when TX ring full. It is reported to application as part of oerrors field. The drop due to full ring is not the statistic that should be set on oerrors field. Such number can be counted by the application using the return value of the Tx burst function. The number that should be set there is the number of packets the device could not transmit in any way, even when it has resources. Therefore, replace this counter to count the total number of failed transmitted packets. Fixes: 87011737b715 ("mlx5: add software counters") Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.h | 2 +- drivers/net/mlx5/mlx5_stats.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h index 909d80e6a..d3d6d6ac3 100644 --- a/drivers/net/mlx5/mlx5_rxtx.h +++ b/drivers/net/mlx5/mlx5_rxtx.h @@ -81,7 +81,7 @@ struct mlx5_txq_stats { uint64_t opackets; /**< Total of successfully sent packets. */ uint64_t obytes; /**< Total of successfully sent bytes. */ #endif - uint64_t odropped; /**< Total of packets not sent when TX ring full. */ + uint64_t oerrors; /**< Total number of failed transmitted packets. */ }; /* Flow director queue structure. */ diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c index f2b5781a9..79b184107 100644 --- a/drivers/net/mlx5/mlx5_stats.c +++ b/drivers/net/mlx5/mlx5_stats.c @@ -94,13 +94,13 @@ mlx5_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) tmp.q_opackets[idx] += txq->stats.opackets; tmp.q_obytes[idx] += txq->stats.obytes; #endif - tmp.q_errors[idx] += txq->stats.odropped; + tmp.q_errors[idx] += txq->stats.oerrors; } #ifdef MLX5_PMD_SOFT_COUNTERS tmp.opackets += txq->stats.opackets; tmp.obytes += txq->stats.obytes; #endif - tmp.oerrors += txq->stats.odropped; + tmp.oerrors += txq->stats.oerrors; } #ifndef MLX5_PMD_SOFT_COUNTERS /* FIXME: retrieve and add hardware counters. */ -- 2.11.0