From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 06F5E1B270 for ; Mon, 30 Oct 2017 16:36:20 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id r196so16765172wmf.2 for ; Mon, 30 Oct 2017 08:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5CDF9EXjrx+WGauWRI6zL61a2z4TAUORJvYhxlWoqzQ=; b=l+Hky0HUI3SztlG6T+YfpWWGr4IdUvXPx0LWzJr9yfJigV45Xp4tJFg1ubV+957YbN qFoHTEfD6f/R9ymtB0O1dFQbVztelHpSQ5NHUxlfl4AEGS1a4Kp1oxDV6JT/Sbd+NJkF Pdcz0OAubyF1hIRdUF6BDYJEycmHnZbfpEvU6w2K6zakiDK9NxSU+XgldmNbxWoofkLa bVp4WIEF0uUMp9V/uNUfAS5sv0eQCJCaTIS4QlO3Cupc6dU+TfACrIRFBrW0B3ZhIeqP MpiZ/YgNpNZnP4MSSP4Pmql0MX4WyioARtuEMTE7AhDmsP/yPeoH0KRoibfkMUzA49w5 livg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5CDF9EXjrx+WGauWRI6zL61a2z4TAUORJvYhxlWoqzQ=; b=hx475GdSXOnHFAJtU8tlyUu1csFLx8vLAKC0MBLmMtbKBPk1KEjOlnfcn0w1WNcPE4 GRQQdD73PaljjvN89KyyoBl5mThNSQ8bD0W0k/P5FRCJNH5bWixi2M5EAabvaLGeLsWf o/ziRvlKOLVmkIwUQrPtd2eRp621PjhqYthrRQX5lY+vB4cRyHtTzIlXdd2uABk5yAHX 1SKA8WLhvB+4Ogx6t21XlA/PxtnP34yiNv01iBTxHKbocOKu+m04ZjG+FQNiZXtKGbqM L62EUkHxVAqBAfp/2YXR+Lo29L0ZqQ39oXqGEs3X08ha74IJ+cEQLB5KgbvDQyVR96t2 vcOQ== X-Gm-Message-State: AMCzsaV7NNV7RUIp6cPurtkNefKxF9S70ubVwt2JELx1NBUTRwwQAjSQ qUV5Ldhz/QDrMY2yE8tQdtM= X-Google-Smtp-Source: ABhQp+Q+0a/6ej1q3f8BlOFHl+ueXqPMIrIhJ5nZZ3lVRJWcYvvxsFq9JIzOzoOBWgPLW/JLJHpb8w== X-Received: by 10.28.193.76 with SMTP id r73mr115480wmf.18.1509377780636; Mon, 30 Oct 2017 08:36:20 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id f27sm28659391wrf.63.2017.10.30.08.36.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Oct 2017 08:36:19 -0700 (PDT) From: luca.boccassi@gmail.com To: Yong Wang Cc: Ferruh Yigit , dpdk stable Date: Mon, 30 Oct 2017 15:34:25 +0000 Message-Id: <20171030153511.13322-22-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171030153511.13322-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/igb: fix memcpy length' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 15:36:21 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From 664e5db471ca1fb9ccf51f23ee33ae4adc1492bf Mon Sep 17 00:00:00 2001 From: Yong Wang Date: Tue, 12 Sep 2017 08:44:00 -0400 Subject: [PATCH] net/igb: fix memcpy length [ upstream commit 671f8776871d2e46c0619c743a82b2f6f6ce58ec ] The size of "flex_filter.filter_info.mask" and "filter->mask" are 16 bytes, but the length of memcpy--"RTE_ALIGN(filter->len, sizeof(char)) / sizeof(char)" may reach 128 bytes which may cause array access out of bound. Fix it by replacing "sizeof(char)" by "CHAR_BIT". Fixes: 231d43909a31 ("igb: migrate flex filter to new API") Signed-off-by: Yong Wang Reviewed-by: Ferruh Yigit --- drivers/net/e1000/igb_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index 9cf619faf..d16be9e1b 100644 --- a/drivers/net/e1000/igb_ethdev.c +++ b/drivers/net/e1000/igb_ethdev.c @@ -3839,7 +3839,7 @@ eth_igb_get_flex_filter(struct rte_eth_dev *dev, flex_filter.filter_info.priority = filter->priority; memcpy(flex_filter.filter_info.dwords, filter->bytes, filter->len); memcpy(flex_filter.filter_info.mask, filter->mask, - RTE_ALIGN(filter->len, sizeof(char)) / sizeof(char)); + RTE_ALIGN(filter->len, CHAR_BIT) / CHAR_BIT); it = eth_igb_flex_filter_lookup(&filter_info->flex_list, &flex_filter.filter_info); -- 2.11.0