From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 1D56A1B249 for ; Mon, 30 Oct 2017 16:37:34 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id r68so17326667wmr.3 for ; Mon, 30 Oct 2017 08:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IjkWUyXIkPPDxwW8mGWrDOdL5aTZwyTTXfZrY2DzSj0=; b=PgWOIhaTA1R4PbLzSjXggCy6pUdISIGVRZRE/wQZtQHGEpjrsLic5HpnaqiCw0rP86 U2a1JpHbrVXVTxJUHIhu1IS6+rjTfXiuO9ugHgqXLECB62YzpfuKDBH52SWCRTFRyPrr 3bqI9UYx2EP8oifQO7H8QUn/wwKg9eH90AEo/RLIDULsMsZU96rHIlFHND0FnD4LUnMJ hFg+8EozyVKy+ltsjZvCVtroEi6AvS2WMi9/BV2gw4Tr8p/pPI5cAg/oN58r3x5xcjA+ vRUIIeyFc6mW+6L4OcDKxPErw8h1svmmNbGqv5tw0KNv9Iec2tEVxspLA9BvvSt0Q3zq GPZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IjkWUyXIkPPDxwW8mGWrDOdL5aTZwyTTXfZrY2DzSj0=; b=CH8NdRF/FRqAXzr9qMsSReSnK2TgncqYNX4ZEJ4mPAhNdqNaSsYMLbcOzk30TkYPdo G8FS3TT9dwTZybnOpedP8Y6vx7RUEgEy4D8ukbKakhmY7SEaTXykiTsvjgPVCODOcPeY q0AFR1+5+6uST3iKUGxFN+Rlgh0RmBK4MMAn0DbV/US5+EXLTBy9+TzVeKKxuNpZCQFQ y4urRviP4QgYYvmlc3OMrRb/ij22z9lFb+p96nXcrWNWBGyxu2bpWNlVNv2g4xYy+r0K zLNTxUAhnIIY9lgcio4wZ+nYVUuirqvJZm/M7jIBGydhZTc/S3rRdwyDamXsHmX4v7Se ubBw== X-Gm-Message-State: AMCzsaWKEbVXlQVIVJpJjl2h15PdlxKyLChrk1FKBb77h6G3PNs8bI1d +4TjZI59nC0wPWGopn0HwmQ= X-Google-Smtp-Source: ABhQp+RYCXLX5XwXgHsAEz0aMFEr9F3khv3hALcrUi1Id1nDweeRtSJjKc+zYuH2BnGajUWjfNqytg== X-Received: by 10.28.212.69 with SMTP id l66mr3869711wmg.33.1509377853801; Mon, 30 Oct 2017 08:37:33 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id n2sm9475917wmd.39.2017.10.30.08.37.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Oct 2017 08:37:33 -0700 (PDT) From: luca.boccassi@gmail.com To: Rasesh Mody Cc: dpdk stable Date: Mon, 30 Oct 2017 15:34:30 +0000 Message-Id: <20171030153511.13322-27-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171030153511.13322-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/qede/base: fix API return types' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 15:37:34 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From a80f1d0c3fc3959984319bc5e2c685ee112069e5 Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Mon, 18 Sep 2017 18:51:25 -0700 Subject: [PATCH] net/qede/base: fix API return types [ upstream commit 10409fabfc0596438429a06aade029379c3a5274 ] - Turn ecore_ptt_get_hw_addr() into static - Convert ecore_dcbx_get_operational_params() to void since we don't care about the return value Fixes: 26ae839d06e9 ("qede: add DCBX support") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dcbx.c | 6 ++---- drivers/net/qede/base/ecore_hw.c | 2 +- drivers/net/qede/base/ecore_hw.h | 11 ----------- 3 files changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/net/qede/base/ecore_dcbx.c b/drivers/net/qede/base/ecore_dcbx.c index 8175619ae..967cf6f75 100644 --- a/drivers/net/qede/base/ecore_dcbx.c +++ b/drivers/net/qede/base/ecore_dcbx.c @@ -619,7 +619,7 @@ ecore_dcbx_get_remote_params(struct ecore_hwfn *p_hwfn, return ECORE_SUCCESS; } -static enum _ecore_status_t +static void ecore_dcbx_get_operational_params(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt, struct ecore_dcbx_get *params) @@ -644,7 +644,7 @@ ecore_dcbx_get_operational_params(struct ecore_hwfn *p_hwfn, if (!enabled) { p_operational->enabled = enabled; p_operational->valid = false; - return ECORE_INVAL; + return; } p_data = &p_operational->params; @@ -671,8 +671,6 @@ ecore_dcbx_get_operational_params(struct ecore_hwfn *p_hwfn, p_operational->err = err; p_operational->enabled = enabled; p_operational->valid = true; - - return rc; } static enum _ecore_status_t diff --git a/drivers/net/qede/base/ecore_hw.c b/drivers/net/qede/base/ecore_hw.c index 7f4db0a0d..3db5cc3be 100644 --- a/drivers/net/qede/base/ecore_hw.c +++ b/drivers/net/qede/base/ecore_hw.c @@ -133,7 +133,7 @@ void ecore_ptt_release(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt) OSAL_SPIN_UNLOCK(&p_hwfn->p_ptt_pool->lock); } -u32 ecore_ptt_get_hw_addr(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt) +static u32 ecore_ptt_get_hw_addr(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt) { /* The HW is using DWORDS and we need to translate it to Bytes */ return OSAL_LE32_TO_CPU(p_ptt->pxp.offset) << 2; diff --git a/drivers/net/qede/base/ecore_hw.h b/drivers/net/qede/base/ecore_hw.h index 0750b2ed4..c246f1882 100644 --- a/drivers/net/qede/base/ecore_hw.h +++ b/drivers/net/qede/base/ecore_hw.h @@ -98,17 +98,6 @@ enum _ecore_status_t ecore_ptt_pool_alloc(struct ecore_hwfn *p_hwfn); void ecore_ptt_pool_free(struct ecore_hwfn *p_hwfn); /** - * @brief ecore_ptt_get_hw_addr - Get PTT's GRC/HW address - * - * @param p_hwfn - * @param p_ptt - * - * @return u32 - */ -u32 ecore_ptt_get_hw_addr(struct ecore_hwfn *p_hwfn, - struct ecore_ptt *p_ptt); - -/** * @brief ecore_ptt_get_bar_addr - Get PPT's external BAR address * * @param p_hwfn -- 2.11.0