From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 92D581B287 for ; Mon, 30 Oct 2017 16:35:53 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id n74so9809323wmi.1 for ; Mon, 30 Oct 2017 08:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=150ByhbTlsmLWpbBgApvoWd95ZEXjXBSeQnsVyVxujI=; b=nz3xDoDpPP/pC2MJFdp0lYPaJGrZ7Dc2FpEfKqISxuC41/PunaPvDfxmY20cxmYzUU k2hJfRcvhFXuIKCdVeIiJirqI0mqH+PSoY1KrKEGK1ImfdDB/DmRgpgfqttN6+NCOdQH Pte6y2WwjZ9N0/0E4QsPeU8cdGK8qwjojB/dkw5BQWGD6q4jzwjMpAVqfJwV/BFK1k6i S4L2XArynm8qYelyV0/+I7F3afgJzAHDQPFk2kvme3qY06M1Z8xw+hrDga776UNaMSdJ wdwllIp3kyPmTJCGxG4bhdnfwRMUGnvQV/Vo3GaPMeRW1pmb4g3fHJpmEzSA+r/ZECwx 2M6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=150ByhbTlsmLWpbBgApvoWd95ZEXjXBSeQnsVyVxujI=; b=IWRFo71ZJMfaj1fEmiQ34Yrfqek+/Re18XwQ0/VAZdLoYEDdR2DwoCStpIlx+Cm1Hp NxwYfT0cd7+1FfyVfyRF4XrdKHZKTt8uVPeK6oEJIZ0jLgovKd21adWGcRJuEt7Lmuvf ewWn4LCnD2Upx6B4DbfBE/ghy100aE5C7l2x93JrPdtanryxA3uCbCpDnbMvQwX3qfQo eFK5md59imzRK3/a7jY+/uGIpqhmljT7NK7dV3VSK4v6cKrDNxxzzw6lgNmysjtxzsqv Bzr0Bf7N/RLNZA/6tHrTNDm8xP9LUDt/YfM06sXQNShzpX4NbV0vo2TB4IyPsaikQ1dC RYAw== X-Gm-Message-State: AMCzsaUsDTL4P8EyV7UnUj3bpnWMgm+oWihxC8zrpFmQmtzVY67JzrCk KAwRNOovV/AOUw+uxb6voZQ= X-Google-Smtp-Source: ABhQp+R9lCScuihWSltAJfQ44l6XI8azfcDIKLwO+xMLJNzmE50YHYn9ngggizJ0Mm9XCY+uXSNfRQ== X-Received: by 10.28.55.197 with SMTP id e188mr4509754wma.60.1509377753210; Mon, 30 Oct 2017 08:35:53 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id g16sm16479302wrd.72.2017.10.30.08.35.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Oct 2017 08:35:52 -0700 (PDT) From: luca.boccassi@gmail.com To: Kuba Kozak Cc: Anatoly Burakov , Patrick MacArthur , dpdk stable Date: Mon, 30 Oct 2017 15:34:06 +0000 Message-Id: <20171030153511.13322-3-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171030153511.13322-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'vfio: fix close unchecked file descriptor' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 15:35:53 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From 3542d6cbe47c7a30fa977367971c1874a6688d11 Mon Sep 17 00:00:00 2001 From: Kuba Kozak Date: Thu, 21 Sep 2017 15:49:08 +0200 Subject: [PATCH] vfio: fix close unchecked file descriptor [ upstream commit 96128b365eff2a1e5477e676c08c1fc631cc82c2 ] Add file descriptor value check before calling close() function. Coverity issue: 141297 Fixes: 811b6b25060f ("vfio: fix file descriptor leak in multi-process") Signed-off-by: Kuba Kozak Acked-by: Anatoly Burakov Acked-by: Patrick MacArthur --- lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c b/lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c index fb4a2f84b..f28891725 100644 --- a/lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c +++ b/lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c @@ -301,7 +301,8 @@ vfio_mp_sync_thread(void __rte_unused * arg) vfio_mp_sync_send_request(conn_sock, SOCKET_ERR); else vfio_mp_sync_send_fd(conn_sock, fd); - close(fd); + if (fd >= 0) + close(fd); break; case SOCKET_REQ_GROUP: /* wait for group number */ -- 2.11.0