From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 492F51B287 for ; Mon, 30 Oct 2017 16:37:38 +0100 (CET) Received: by mail-wr0-f195.google.com with SMTP id w105so13075819wrc.0 for ; Mon, 30 Oct 2017 08:37:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kn2vj1vuuAAi/dxExkSWZj7J3PzbyLtXBWYE50oEQHo=; b=qunWBHfRTWDNXlVcXv6ZyH7wQCKR/5jZkydFAyiuJDNdqy+mjhq/LfX+qubFP7uD68 PfZwQeBdQEleGR43mMcU2D4WpfxowmVL9yfgvHAXbxk3dy4A1UWwmRJJei4wfQlWsWUj rx3WXaPj11GQNZpclw4lza0wnHRxCZqtFd+kdNcG0mCFEi1+HRaVCkTdDjMZ0YEqrnKe 3W2B4Nqd+a7QoX9lnJN/Wnoe5pcGD1UikqkBU9iOX0vXPc+cd50MNjD5ZaU0f3jlyTw0 6VonYUhtfyHBKY4X1RaAgf2/heGnBBzSAbCvQfDzLP7b/eFOGVk15oGvZXn+NAKnrglG IxIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kn2vj1vuuAAi/dxExkSWZj7J3PzbyLtXBWYE50oEQHo=; b=krhSrL6I8VwUOZaFcJnG0IkqoMj6lH3hpFWeZoNHWO72AZRf2D2gEmnAoL7kqkDQhU cEky8/Ss2lDq/Px+0P2jbRI7Om4iKa/uMR7XIqlT7eS3yy32yL91VI6Mdr0wvmhoU65c X1Lan2tSXeZ1atcNoOe4obGFKNrW0TDpFEPaj5Rn5Sn3OYPv95M/AbyEUajRw+TVdjss mg3Kz/KEmft5LZhXWEq7b5y3DnuowJp3NT1ukxnFF3HE7+gt9Z2HcD/KYR9YbH8Y+r53 algCNpje/o0kxQcmugc6p//tOwvcqbi/iQ7vegm/DamKof0TqrKHjdDIAnHfWHKvmxSI lj2g== X-Gm-Message-State: AMCzsaVOk8DJ4tWzi12ZjBtokxfIDYDSumRCDMwuctXjFvOwm+qmXhd5 AfeN/6hPlVaqLwMcF6eNTT2dI8XzSVA= X-Google-Smtp-Source: ABhQp+RjRmgr+CvM6tqINiLcx3dGKSXE4F4z7h83BQO/9E0vy5PMmRnakP+YbzEbSGZ+fnuMJtKwzQ== X-Received: by 10.223.187.79 with SMTP id x15mr7764314wrg.146.1509377857978; Mon, 30 Oct 2017 08:37:37 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id g16sm16483179wrd.72.2017.10.30.08.37.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Oct 2017 08:37:37 -0700 (PDT) From: luca.boccassi@gmail.com To: Wei Zhao Cc: Ferruh Yigit , dpdk stable Date: Mon, 30 Oct 2017 15:34:33 +0000 Message-Id: <20171030153511.13322-30-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171030153511.13322-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'app/testpmd: fix packet throughput after stats reset' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 15:37:38 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From 1d6c8ed407f1e78cbbe7f9df54d3452db4221c40 Mon Sep 17 00:00:00 2001 From: Wei Zhao Date: Thu, 21 Sep 2017 14:32:23 +0800 Subject: [PATCH] app/testpmd: fix packet throughput after stats reset [ upstream commit 69986a823d789da3745ab6b4ca6d3e84fe76c1b1 ] Testpmd calculates packet throughput by getting a diff of previous stats value and current one. If a stats clear called after previous sample taken, the diff will be negative and throughput calculation will be wrong. If current stats value is smaller than previous one, set throughput to zero. Fixes: 0e106980301d ("app/testpmd: show throughput in port stats") Signed-off-by: Wei Zhao Reviewed-by: Ferruh Yigit --- app/test-pmd/config.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 36c47ab51..56a7ec679 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -224,8 +224,10 @@ nic_stats_display(portid_t port_id) if (diff_cycles > 0) diff_cycles = prev_cycles[port_id] - diff_cycles; - diff_pkts_rx = stats.ipackets - prev_pkts_rx[port_id]; - diff_pkts_tx = stats.opackets - prev_pkts_tx[port_id]; + diff_pkts_rx = (stats.ipackets > prev_pkts_rx[port_id]) ? + (stats.ipackets - prev_pkts_rx[port_id]) : 0; + diff_pkts_tx = (stats.opackets > prev_pkts_tx[port_id]) ? + (stats.opackets - prev_pkts_tx[port_id]) : 0; prev_pkts_rx[port_id] = stats.ipackets; prev_pkts_tx[port_id] = stats.opackets; mpps_rx = diff_cycles > 0 ? -- 2.11.0