From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 8B2291B252 for ; Mon, 30 Oct 2017 16:37:46 +0100 (CET) Received: by mail-wr0-f196.google.com with SMTP id u40so13023482wrf.10 for ; Mon, 30 Oct 2017 08:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tgvgy2LOUTDIKF9h54I16rM0B0KU0PJPNS4B4qsb9ZA=; b=NwiIHnDIJx7JIxStJDL8ro3EYkRtNV+abdsxMq+E2YnafBMXAOMSUGXAQ9hklYyopF vBRmIHPJDcJA2wO5OK4yAvOmpyIQ2HDusu7azzwr+7iU3tp4kbzfub7dy1g/xV1jvVqd vRbshHybQhWU9Nc4z0dkmGJK177iUmjQIYbdhKGHdnZPYUWMLvf1x4AaFFAU5inXDka4 bkeg5IdkTCbjBcPNjMAnqmngGCtDvvX8yK2euyFz+LgyU2k33mgA9dN57XHZlIzSX1Sf RDYkARV2S3wwdJK04rXJC2txzygm4rtbIosj9werD7wDLKWrOY975YEeT/rz4NpXK9vU K0Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tgvgy2LOUTDIKF9h54I16rM0B0KU0PJPNS4B4qsb9ZA=; b=OvSmmIBJavXgmQAbH5xcHQ1jtR3pBb+WOG+5x57x0Haw5vnKFhUS2AFC3lpjyuNCud IOfKYHKIL2Qsr3pfpOLJx4uPVkzwiQQ4Mt9R9E+y9qXdGcgGD7VG2cP8JreUPz01qXpn UoOCYIciUndarpxL4BY03gGyNN91iX7E0m91GvOnoItdcP8OYRp/NnqPDP4j45ZNAbNk SOYWgmtAAlHv9/u2t4IO6ZL8ZIJz6x4a3V7Nj00b7Js+ycqTi9AcKDPx1UGKVj5DzUTG IN2MM4kPzHcTD8iJuGWIHnIzWivqSduG9Y6nrHi4ekFRdIJpiirfg4fK9Mab/Ha8mj4w riOQ== X-Gm-Message-State: AMCzsaU8/F0Cr8FafjB/0TQdp5hFRm2qeuIH2x8Q2bUkf0VKvK++5Ki1 soVB48Cnk3z8K4aJb2mFiwXMhft1WxQ= X-Google-Smtp-Source: ABhQp+RdwFsVCOHhnIH9DPeufGQ5LxafAs5x997fbXLCcfQMniQjVhyyqX6Nk09pzlzgRciskGlKkQ== X-Received: by 10.223.172.245 with SMTP id o108mr8754115wrc.122.1509377866317; Mon, 30 Oct 2017 08:37:46 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id j4sm10374827wrg.11.2017.10.30.08.37.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Oct 2017 08:37:45 -0700 (PDT) From: luca.boccassi@gmail.com To: Michal Jastrzebski Cc: Tomasz Kulasek , Ferruh Yigit , dpdk stable Date: Mon, 30 Oct 2017 15:34:39 +0000 Message-Id: <20171030153511.13322-36-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171030153511.13322-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/vmxnet3: fix dereference before null check' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 15:37:46 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From e00ab55ead1f7be3f2fa90c5f347d97ccb972408 Mon Sep 17 00:00:00 2001 From: Michal Jastrzebski Date: Fri, 29 Sep 2017 15:04:02 +0200 Subject: [PATCH] net/vmxnet3: fix dereference before null check [ upstream commit 4d0833e6f8d4c9814b0c8fa1a2f8ed2263ae4856 ] Coverity reports check_after_deref: Null-checking rq suggests that it may be null, but it has already been dereferenced on all paths leading to the check. This patch removes NULL checking of "rq" from function vmxnet3_dev_rx_queue_reset as it is already checked against NULL one level up the callstack (function vmxnet3_dev_clear_queues). Coverity issue: 143468 Fixes: 5aecdc17a97d ("vmxnet3: fix stop/restart") Signed-off-by: Tomasz Kulasek Signed-off-by: Michal Jastrzebski Reviewed-by: Ferruh Yigit --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index 3056f4ff8..4762a4418 100644 --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c @@ -254,11 +254,9 @@ vmxnet3_dev_rx_queue_reset(void *rxq) struct vmxnet3_comp_ring *comp_ring; int size; - if (rq != NULL) { - /* Release both the cmd_rings mbufs */ - for (i = 0; i < VMXNET3_RX_CMDRING_SIZE; i++) - vmxnet3_rx_cmd_ring_release_mbufs(&rq->cmd_ring[i]); - } + /* Release both the cmd_rings mbufs */ + for (i = 0; i < VMXNET3_RX_CMDRING_SIZE; i++) + vmxnet3_rx_cmd_ring_release_mbufs(&rq->cmd_ring[i]); ring0 = &rq->cmd_ring[0]; ring1 = &rq->cmd_ring[1]; -- 2.11.0