From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id CEE8A1B252 for ; Mon, 30 Oct 2017 16:37:49 +0100 (CET) Received: by mail-wr0-f193.google.com with SMTP id z55so13082125wrz.1 for ; Mon, 30 Oct 2017 08:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XVi2Hr84RxrbEvZ5di8g3+TusJ2jgZKkNNl7wGmGEnk=; b=e2x6IYlAfkxdkpOV9e85KpAmNZtbZXnS7IsAIZOWZkit1bSOCrRuvtx6zXrRHEYBNg W1GmlwrEH7fWXIqYyQZzTtGBeLCtoWBuoUBeCEEe6sPDU+xUPj5o4zZ1ppaH0i/WDV69 Ot07tJ6d2hOgCXr9YH9iZpvSd9b0R3t+44fdnFVN1U4EbFL+olrZPogKWHq+MJ+UsuUI S5jGG/b0y81iNG8ymOG/v8nVhFS8LerRihRU0hFkmF1CIDp9HRZuWp9OepRqOFqdAcH0 QEPz3guPrzPQMlhN7T+AYZswSJIs/Ig7K84A0Dd29xvGqxCDQyKvp2GO9ZWUjAoeMteG 7gGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XVi2Hr84RxrbEvZ5di8g3+TusJ2jgZKkNNl7wGmGEnk=; b=UhZsNVgB3yFGErJrrMhzjT5uyVta9gQXzWcD8XOrHzHADTYpUvS35l1YqCNAMGYHRL HQQZW9qIMEUWDTuFx3mRfJ9Nw++CO4IoUbrk/z1wbAhV1YICMQUGtTN7+u4FrdV+bLZ4 sDoPi+1hU7bssH7ZfxlUKvFsl94x42geXe78vMU07cHOfMm/fb8dxeZW99wDyRAPsBmt 6b0t1PPSAc3JYVH3K2+tDMvkMoememGlyl4/ywS58yaOaiD7zmyRH58DL0SuD+GG6Wtp /cdsmXErTF0f/h+iH4ahCukwO2oB2cxe0psMrqaKEHrF+e7XfrzL6eatX1glVMG4OC6U c5qw== X-Gm-Message-State: AMCzsaXC0SAelnCqTc2rIR4XKO3/6WPNgU/D6AJYlZHd6yuCjzm1rzfQ XwDcSga+6lH5Z0R0v2v3HgHtbeNNdEI= X-Google-Smtp-Source: ABhQp+SDxFclfCD8ot0oGuhH3QUEHJeUcsSWJEi4TE299PPLRVump4rwtSwCb1oCpiJsPPmXWguTAQ== X-Received: by 10.223.186.140 with SMTP id p12mr7755469wrg.235.1509377869369; Mon, 30 Oct 2017 08:37:49 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id d12sm4743956wre.85.2017.10.30.08.37.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Oct 2017 08:37:48 -0700 (PDT) From: luca.boccassi@gmail.com To: Olivier Matz Cc: dpdk stable Date: Mon, 30 Oct 2017 15:34:41 +0000 Message-Id: <20171030153511.13322-38-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171030153511.13322-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'cmdline: fix compilation with -Og' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 15:37:50 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From 3e7b58053dc2ce8222eaaabbc055192b19a1bb93 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Mon, 11 Sep 2017 17:13:29 +0200 Subject: [PATCH] cmdline: fix compilation with -Og MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 1123f16eb37b19dcabe2b2313f99911c59df91f3 ] The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC cmdline_parse.o cmdline_parse.c: In function ‘match_inst’: cmdline_parse.c:227:5: error: ‘token_p’ may be used uninitialized in this function [-Werror=maybe-uninitialized] if (token_p) { ^ This is a false positive, gcc is not able to see that we always go in the loop at least once, initializing token_p. Fix the warning by initializing token_p to NULL. Signed-off-by: Olivier Matz --- lib/librte_cmdline/cmdline_parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_cmdline/cmdline_parse.c b/lib/librte_cmdline/cmdline_parse.c index b496067aa..28a7933ba 100644 --- a/lib/librte_cmdline/cmdline_parse.c +++ b/lib/librte_cmdline/cmdline_parse.c @@ -149,7 +149,7 @@ match_inst(cmdline_parse_inst_t *inst, const char *buf, unsigned int nb_match_token, void *resbuf, unsigned resbuf_size) { unsigned int token_num=0; - cmdline_parse_token_hdr_t * token_p; + cmdline_parse_token_hdr_t *token_p = NULL; unsigned int i=0; int n = 0; struct cmdline_token_hdr token_hdr; -- 2.11.0