From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 0BD1D1B249 for ; Mon, 30 Oct 2017 16:38:00 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id m72so16768267wmc.1 for ; Mon, 30 Oct 2017 08:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1roPF2QSYV9RA4311NyYu+3ptFYuRyaTDCISULFhxSc=; b=NJ0zSHJmrrWKzkbLQfOzDbDEHxQ/GienzC9Ugtcs7tkMrvN+n8xNA0gaRaj3Qd+WON HaZWpxpDeCw16rhYN6wtyqSMQBWsvxiCJ7gnMGf3FdPr73Pn+kRpNK4A5seA8urpNiwI q/xe5LSdLT2EsfciWu7EsZrGr6ztghNmuWZzZ7zAgwz90E+beNq3GYwaeRClzrA4wuvl 7mU8BmZLFLVpGETTic9IL//kMK0aC48hCm7zNg6rsqqzw4faauyvC6fChsmBWzGgCEMe FrWqxRsdUNQfb6YLKB9//arI1YUbZq11xJS0t+yf/c7lBM4ichIoKJUC4X2S1VMbZQDD neoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1roPF2QSYV9RA4311NyYu+3ptFYuRyaTDCISULFhxSc=; b=cKsQaucblNCNIVjw40rSq5hfZ+djsR30Ft9HfxBi8XNn9UEaXb6YjvLzvpjMLJURz7 5CQ2h+yJs6FUPUEEjtugjLVpD1HGZhkxMdZq5m+Np2tXWbwypcA9W5ooEd7XEUx6Nm0o 4SeXuEysN3stxx5f1C29Q8ofmM5Q3p7nfdZx3BQiKWJSbzagcZaSgEjI1rYpOsi6bOvF Ph8baqJ1xLhIvvMnm75GSHL6bGU7Dh71frv3D15LfYAyQP334WolIR50gFT5yNVWS0fv HDaCj+VzBwF3FOuCYkSeCqCaPfL5KFtP4/0bL5h1SIAOpGwMtOwqSbbar/v4db2gCR98 u9Yg== X-Gm-Message-State: AMCzsaWjwgaXKJxKzPVpLg0h8h0UNCQSKflGbCoiLhh+8SBCiUpavtrI D0CTBB4tFfiN1cTcGKLs0g8gGqb+uS8= X-Google-Smtp-Source: ABhQp+S2eDgpB3N20wWKGf4BPfWgwoyTuJ9uiamiDTnnG36a27XrfeGbQpcXasmsdQUSlSLgRJRQzQ== X-Received: by 10.28.238.148 with SMTP id j20mr3970275wmi.23.1509377880576; Mon, 30 Oct 2017 08:38:00 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id f6sm8864866wre.66.2017.10.30.08.37.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Oct 2017 08:37:59 -0700 (PDT) From: luca.boccassi@gmail.com To: Olivier Matz Cc: Maxime Coquelin , dpdk stable Date: Mon, 30 Oct 2017 15:34:49 +0000 Message-Id: <20171030153511.13322-46-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171030153511.13322-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/virtio: fix compilation with -Og' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 15:38:01 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From ac415cc8240828a6029cd99b97159c61c4b98cbd Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Mon, 11 Sep 2017 17:13:26 +0200 Subject: [PATCH] net/virtio: fix compilation with -Og MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 3976f19e13cf7770597b207651c76b1676b9163a ] The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC virtio_rxtx.o virtio_rxtx.c: In function ‘virtio_rx_offload’: virtio_rxtx.c:680:10: error: ‘csum’ may be used uninitialized in this function [-Werror=maybe-uninitialized] csum = ~csum; ~~~~~^~~~~~~ The function rte_raw_cksum_mbuf() may indeed return an error, and in this case, csum won't be initialized. Fix it by initializing csum to 0. Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload") Signed-off-by: Olivier Matz Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index ad582f3e5..08e4e126b 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -685,7 +685,7 @@ virtio_rx_offload(struct rte_mbuf *m, struct virtio_net_hdr *hdr) * In case of SCTP, this will be wrong since it's a CRC * but there's nothing we can do. */ - uint16_t csum, off; + uint16_t csum = 0, off; rte_raw_cksum_mbuf(m, hdr->csum_start, rte_pktmbuf_pkt_len(m) - hdr->csum_start, -- 2.11.0