From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id AFD321B249 for ; Mon, 30 Oct 2017 16:38:06 +0100 (CET) Received: by mail-wr0-f196.google.com with SMTP id p96so13019622wrb.7 for ; Mon, 30 Oct 2017 08:38:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sUtSlvq2ZMPybQIDExnUbEQzYdubKcyNciQSol8fJVk=; b=ZADR5S5G41RygxP8BefLQM0XZjtuUsoaJ7YrfHVzkrUyOw+ZfFVCEbmYsRo+8aCllr IOimcpBuNyDmQm75dWAsC0iUh9TU8nZKZjQI90B8aIIyPEORU2KAItJECGEk7cGoVqEO tC0Mu8aCylPcTxziJXi9jAt6aU/V/wSVuG3Wo5h/6+IhcLxSqjkHLWpZrR+m161VRZvH 8opRFUcCoRDmsTF/77ylHgozQga3SsPH7NtPf7dsrzz+ZA4sDKDFgMkyg08wp3PNSZs3 a7phSchir8L6Ff6OZIaIdv6QtUbiRtRUBOsWjZ0l+xMqQBQY7vx1z2Dp2rxPjEH4xDu+ vc4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sUtSlvq2ZMPybQIDExnUbEQzYdubKcyNciQSol8fJVk=; b=NrzSDYRE4d4mX8zWjiCJa4luwmxThLW2D4p569Y6Krg24xexXwhAAEuNu3FJeNkLbD xt4lyLF2HHyksJ0ZZvo69tFL6OLIUoAlSyTHY8+8WyEi9KtAzDKS/Y7/hx7B/NI803GL 8mkLBrbL/UNF4eJtrHWkFdaH8G8Oljt4kyShtBy6eoK/5HS+BshdxInanoAr7ouv1wsM vSC8APxsfOhDAIsnVDrW6+Dy2SGN+2rmFWMkISHngqeJAK6v+SBE7wxbFz/slcf+vX9C 6vv6XA7ZVKqPUiKUjGmdpm0KvM9IWJ1xLEwXHX0bSr1F8XZ1B0oW7m0wXVyIphLHdjOA vbqQ== X-Gm-Message-State: AMCzsaVfTcMkpEzaPtFZHKRc9ykLvqitYFhA2JcyiMFxl0t8srr+o2EG 0skdMMP47cxe3gln0YEKSp0HMjCClyA= X-Google-Smtp-Source: ABhQp+RnJoN+5WuaSy9ShR7pkwc+ez3LHETKF8I5HRlfCbVQ0O1hC/2v9F2RuW21oWUwE03OxlyaKg== X-Received: by 10.223.135.231 with SMTP id c36mr8409475wrc.248.1509377886181; Mon, 30 Oct 2017 08:38:06 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id x185sm2287283wmx.12.2017.10.30.08.38.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Oct 2017 08:38:05 -0700 (PDT) From: luca.boccassi@gmail.com To: Li Han Cc: Ferruh Yigit , dpdk stable Date: Mon, 30 Oct 2017 15:34:53 +0000 Message-Id: <20171030153511.13322-50-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171030153511.13322-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'app/testpmd: fix invalid port id parameters' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 15:38:06 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From 9ad197a56e62b723920bf4201deb9a3119c9abe9 Mon Sep 17 00:00:00 2001 From: Li Han Date: Tue, 22 Aug 2017 13:03:42 +0800 Subject: [PATCH] app/testpmd: fix invalid port id parameters [ upstream commit d1f1a0fd8a0b3e5b090e64a8d7d895479e959143 ] in parse_ringnuma_config/parse_portnuma_config functions, port_id should be less than RTE_MAX_ETHPORTS, but port_id_is_invalid check assumes that port_id may be RTE_PORT_ALL (65535). Also fix port_id storage size. Fixes: 4468635fdd04 ("app/testpmd: forbid actions on invalid port") Signed-off-by: Li Han Reviewed-by: Ferruh Yigit --- app/test-pmd/parameters.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 2f9695393..a96264657 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -360,7 +360,8 @@ parse_portnuma_config(const char *q_arg) char s[256]; const char *p, *p0 = q_arg; char *end; - uint8_t i,port_id,socket_id; + uint8_t i, socket_id; + portid_t port_id; unsigned size; enum fieldnames { FLD_PORT = 0, @@ -390,8 +391,9 @@ parse_portnuma_config(const char *q_arg) if (errno != 0 || end == str_fld[i] || int_fld[i] > 255) return -1; } - port_id = (uint8_t)int_fld[FLD_PORT]; - if (port_id_is_invalid(port_id, ENABLED_WARN)) { + port_id = (portid_t)int_fld[FLD_PORT]; + if (port_id_is_invalid(port_id, ENABLED_WARN) || + port_id == (portid_t)RTE_PORT_ALL) { printf("Valid port range is [0"); FOREACH_PORT(pid, ports) printf(", %d", pid); @@ -416,7 +418,8 @@ parse_ringnuma_config(const char *q_arg) char s[256]; const char *p, *p0 = q_arg; char *end; - uint8_t i,port_id,ring_flag,socket_id; + uint8_t i, ring_flag, socket_id; + portid_t port_id; unsigned size; enum fieldnames { FLD_PORT = 0, @@ -450,8 +453,9 @@ parse_ringnuma_config(const char *q_arg) if (errno != 0 || end == str_fld[i] || int_fld[i] > 255) return -1; } - port_id = (uint8_t)int_fld[FLD_PORT]; - if (port_id_is_invalid(port_id, ENABLED_WARN)) { + port_id = (portid_t)int_fld[FLD_PORT]; + if (port_id_is_invalid(port_id, ENABLED_WARN) || + port_id == (portid_t)RTE_PORT_ALL) { printf("Valid port range is [0"); FOREACH_PORT(pid, ports) printf(", %d", pid); -- 2.11.0