From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id DE7231B279 for ; Mon, 30 Oct 2017 16:38:27 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id m72so10956720wmc.0 for ; Mon, 30 Oct 2017 08:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uzIgGkthGxiUlm8MqiuYTi73l62z0jktU5npEv0RdcE=; b=NLmSWnA3iA2aVtlo8D6AZKOkraG6FsLXHe1nveuFlCa0OolZiGOLccdVHT4Xdoj+7c 2OZyCC2862U8K+L2uWNfP0m1UM7657u7l3PaTXYymng2jD2dYlVHBpyYDdiiMKhErzxW E7rSbeQugEooKMndD74+iVE0FpmsZPK15UwPBNmRXugVe1SsjYIbNCqDCuEZMsVvCJ9C eSbFzXLZ+E1Uvkd0v9MXzpix3wCTluyyWga9sOoGarAAHF9HBUcLDbffkLSBVlPUBOLD Apk/2v8QvZjjl3m3wvnpASTvCr19asccIBcIljJPwdXCXrimww4ZXiRIqwp8PGgHFlZq moYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uzIgGkthGxiUlm8MqiuYTi73l62z0jktU5npEv0RdcE=; b=aNWbrRrrRzeFQYV5bZoAgoJD14niSFio2p9HiLVjNBk946EJMRCErj9GLM0XtFGdw2 2d9o7CkW7p+ljNmxczFqppXoH0gehILsmzzVF+KFUYeSFEmV037Il75gE+GHfCtjvt6P VPA/hF052RP5k9bvrto/O312wqZqeidkkpV19CTlCY3H8pEGRfIsY41shnUssiuHzq9p 9lTYdr2MaLcszS8QeAuUOOzMQ037ddTy1rAnu62+ELUZ9uQDWHDFflCyVIduVpQPO+9t teBnL+8kXPhTQTjUIGuPbm2+XO43+haS1sg3i/qr48JrwijvOFhkiVKpyxiWqkkO4h5K QMjg== X-Gm-Message-State: AMCzsaUtOnighkz0sRZLm43oaaL3ByFlpK7c8eeHsJaeukPEAbmW28iX aNpmawJFR48CgA/+QLpCIeA= X-Google-Smtp-Source: ABhQp+QRAqNIC/Io1sPFCTe3RSLROo8vuuf9+G2NMgT4WmlqcoqQTpJZAFMktGyyNdX0RRpPtWepHw== X-Received: by 10.28.236.203 with SMTP id h72mr4442210wmi.147.1509377907647; Mon, 30 Oct 2017 08:38:27 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id o3sm2695288wmg.3.2017.10.30.08.38.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Oct 2017 08:38:26 -0700 (PDT) From: luca.boccassi@gmail.com To: Kuba Kozak Cc: Konstantin Ananyev , Zhiyong Yang , dpdk stable Date: Mon, 30 Oct 2017 15:35:08 +0000 Message-Id: <20171030153511.13322-65-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171030153511.13322-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'examples/l3fwd-acl: check fseek return' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 15:38:28 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From 09cf3b1c4a30ba0bc1542826109d7806e4cb0881 Mon Sep 17 00:00:00 2001 From: Kuba Kozak Date: Tue, 3 Oct 2017 13:48:02 +0200 Subject: [PATCH] examples/l3fwd-acl: check fseek return [ upstream commit ab9cfe43c28efb3576396e7133af64b25b8785f3 ] Add return value check and error handling for fseek call. Coverity issue: 143435 Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl") Signed-off-by: Kuba Kozak Acked-by: Konstantin Ananyev Acked-by: Zhiyong Yang --- examples/l3fwd-acl/main.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c index 9307d48c5..0d0d8bfc3 100644 --- a/examples/l3fwd-acl/main.c +++ b/examples/l3fwd-acl/main.c @@ -1027,6 +1027,7 @@ add_rules(const char *rule_path, char buff[LINE_MAX]; FILE *fh = fopen(rule_path, "rb"); unsigned int i = 0; + int val; if (fh == NULL) rte_exit(EXIT_FAILURE, "%s: Open %s failed\n", __func__, @@ -1043,7 +1044,11 @@ add_rules(const char *rule_path, rte_exit(EXIT_FAILURE, "Not find any route entries in %s!\n", rule_path); - fseek(fh, 0, SEEK_SET); + val = fseek(fh, 0, SEEK_SET); + if (val < 0) { + rte_exit(EXIT_FAILURE, "%s: File seek operation failed\n", + __func__); + } acl_rules = calloc(acl_num, rule_size); -- 2.11.0