From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id 141081B2B7 for ; Wed, 1 Nov 2017 15:12:47 +0100 (CET) Received: by mail-lf0-f68.google.com with SMTP id a16so2712782lfk.0 for ; Wed, 01 Nov 2017 07:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gjGi/rNl01Y2vqOXO0lEDXym7O05w4EWkHdweXIKONY=; b=FcHyDZ9TfccFJ59b2N8PpERaSMUp9qtCXcZMVkSFSDv0xlg9ySo5vVq3DgNO7eHzzR J/S1A31Db9RrNCDI/572vl3RQkvaKrgtEyE1Ep+bcN5TluMmIPNjDPB+hywssja5QOrd tRerPqVRa1pcTYMbia3xxnSG2zolmZpoJSyppf8jev8sD9EFCNjnqtlOf1smnQSq2HEU jeELKdJIla4W7xEkvRBqNL6XPd17gsU43XnAsegUBr1yApyJHzlmY6GVX0OEREtSD//S wfGN4LavIgZlQfmcQW3q6XgA4aOJyRUQUb+XSI+BcUiCJwSEZvuK0FPi5qfnOEiT6GUE x1GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gjGi/rNl01Y2vqOXO0lEDXym7O05w4EWkHdweXIKONY=; b=aWZO/wxlus4CvyeJ/Zk8KFb7hL60+bt1Iaz0reS2zoZDqY8XvJ0UpZLlPp+npMFoK6 5Xl6LOTuNQOty3FhEjEVZ3qOqDf5ofw5HPGHexgUJx3y5znnpNuLLxInt3if6A7s+wuu 32exYMn0V8PgkrOakQ6a6hBdKvs/EjPfsZu+S5EPTdhqU5WylY48ARUj5YT6Xedo678h HJSDv4wkCvwdlG/1Wddk017cGUp73gSx/k3w0IuZwIa6TNc+7Hta2JfhVoDssN4bk0Mj bc2sok2KW2AbWV22ajfHbSw7Ikt04paM1/3qswiHtLRdyH/KO8iC9MHunS7aL0COrSXC Iq4Q== X-Gm-Message-State: AMCzsaWfSKVXCNoDXQYsX6IzM7fNucseKSl0/bobZwePhrQklAmSFpn/ 0PhMbwLCiI5cWiAyRDP/JnGiVg== X-Google-Smtp-Source: ABhQp+QdmzMzhYtO3UKkYHQVxBm+6vnKh0VXM7eHwkmt/XInHOAYDhuv09WZz2uxIxGorLaMih4Rig== X-Received: by 10.25.84.134 with SMTP id b6mr2133968lfl.168.1509545566444; Wed, 01 Nov 2017 07:12:46 -0700 (PDT) Received: from shemminger-XPS-13-9360 (static-92-33-18-3.sme.bredbandsbolaget.se. [92.33.18.3]) by smtp.gmail.com with ESMTPSA id f10sm151619ljf.3.2017.11.01.07.12.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Nov 2017 07:12:46 -0700 (PDT) Date: Wed, 1 Nov 2017 15:12:20 +0100 From: Stephen Hemminger To: "Mody, Rasesh" Cc: Ferruh Yigit , "Tan, Jianfeng" , Jingjing Wu , "Thotton, Shijith" , Gregory Etelson , "Patil, Harish" , Thomas Monjalon , "dev@dpdk.org" , "stable@dpdk.org" , George Prekas , Sergio Gonzalez Monroy Message-ID: <20171101151220.0f3f811b@shemminger-XPS-13-9360> In-Reply-To: References: <20171020165511.47899-1-ferruh.yigit@intel.com> <44560a31-d8dc-b2e1-1589-95020fb654f3@intel.com> <5108b90a-5617-ea1a-ad41-c2eb83b8c1a1@intel.com> <02e895a8-e1fa-7159-f0e9-b8b8f883ae27@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] igb_uio: remove device reset in open X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2017 14:12:47 -0000 On Wed, 1 Nov 2017 06:58:53 +0000 "Mody, Rasesh" wrote: > Hi Jianfeng and Ferruh, > > > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > > Sent: Thursday, October 26, 2017 5:50 PM > > > > On 10/26/2017 2:28 AM, Tan, Jianfeng wrote: > > > Hi Rasesh, > > > > > > > > > On 10/26/2017 7:43 AM, Mody, Rasesh wrote: > > >> Hi Ferruh, > > >> > > >>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > > >>> Sent: Friday, October 20, 2017 9:58 AM > > >>> > > >>> On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > > >>>> Remove device reset during application start, the reset for > > >>>> application exit still there. > > >>>> > > >>>> Reset in open removed because of following comments: > > >>>> 1- Device reset not completed when VF driver loaded, which cause VF > > PMD > > >>>> initialization error. > > >>>> Adding delay can solve the issue but will increase driver load time. > > >>>> > > >>>> 2- Reset will be issues all devices unconditionally, not very efficient > > >>>> way. > > >>>> > > >>>> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of > > >>>> device file") > > >>>> Cc: stable@dpdk.org > > >>>> > > >>>> Signed-off-by: Ferruh Yigit > > >>> Hi Jingjing, Shijith, Gregory, Harish, > > >>> > > >>> Can you please test this on top of current master (which has already > > >>> Jingjin's > > >>> fix) ? > > >> The original FLR change during igb_uio open()/release() in DPDK17.08 also > > impacts BNX2X PMD and it exhibits the issues with bare metal testing. > > >> > > >> Now, we tested this change for BNX2X PMD using latest dpdk, which has > > this fix where FLR is invoked only in the release(). > > > > Good to hear this fixed the problem. > > Yes, it fixed the issue caused by pci reset during application start. > > > > > >> However, we ran into an issue when trying to reload the testpmd > > application in quick succession. The pci reset, called during the igb_uio > > release() operation, is taking longer time and adapter is still doing the FLR > > when we relaunch the application. We see this behavior with bare metal > > testing. > > > > > > If we don't reset that device, it will continue working which is a > > > more serious issue IMO. > > > > +1 > > I think, it would better for the individual PMDs to take care of the reset during the application exit. That will never be possible. Poll Mode Drivers are userspace entities and part of the application. If application crashes, there is no way for PMD to do cleanup, it must be handled by kernel.