From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 384DB1B3C6 for ; Thu, 2 Nov 2017 13:03:43 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id b189so10479691wmd.4 for ; Thu, 02 Nov 2017 05:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ta4xX94IEC0ESDsagWowSiS1zzDbKjYhOF1AWMXE8NI=; b=MslyZ1tZ35iFiMCQwKYUsqbXjYN1l3Qq8+fjTuqrEvIEJZa5Zp5bONyI/yQKpweijp 3ZH2eArSUb6IeOIHZV6r0PUiItHZ/qpmqhE/737cMFEYL3/jp+8PD23t1vQdrl6yuR/+ ZoPMc/bYp9qNPzhqcfOKOkFXT1gjJaThgAg2J7TSTQJ3Qdv/UKM59OnQxG+kwEBobOic o1ZnIA4Og1dxcFsOcrsb7fTK0KtldVQ2qdtCjAZkWX5njpo/8dsrvIeqvYmNpjdJ8x6D Qb5xRseh00YSSNVoV6vEWKzrngm9AgdocI0RTHyJp5HoYAcUj131R1/7sS9raGYeWeie 3rRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ta4xX94IEC0ESDsagWowSiS1zzDbKjYhOF1AWMXE8NI=; b=HQYun6UXqv6IpI1XnmcUuIw+95IhGA4vJ8/AhT5YTFBnxGok8H+3EYcWL896EXr8jY vCJK2g2N1kADjgmJep6XVlVEYOCgr/AfDzjj9tybhCP022mvO+Aeg+dCtJPu8WNR7R52 0TKVqPMKbJS+SsTxJCF4BEHKNk5/uV3oTpY/67opi5UmEFiQasq0MvirPZVh2JloVDsW jZV0AYLslaeCIqxbFVNOx/ormRCsLEGOHxF8cMrVEGmdES/XOhMmsb9ipzhU1hVb1NGr l26WE5cPqbDz6torRZzm8eoHn/YjJ4oCkx2yPM/6lH3s2lm1Vdf4g/aNG656FrvzGPJi FZNw== X-Gm-Message-State: AJaThX6/jPU5jYQORy9JGQPnvcfY0KFDATRsQBXKIqDCn+P4UQY2ZrMX y980iaTbbmcPt7Td/aYS9J5r3heYNa8= X-Google-Smtp-Source: ABhQp+Q61C/wpYbmTl7o1zINmSEmv5W2x3V/RJwBprfNrQSNFK6midUXulzh+xQN4AyCgQ2HzGjbvA== X-Received: by 10.28.132.66 with SMTP id g63mr1403197wmd.22.1509624222802; Thu, 02 Nov 2017 05:03:42 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id k185sm2964518wma.28.2017.11.02.05.03.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Nov 2017 05:03:42 -0700 (PDT) From: luca.boccassi@gmail.com To: Nikhil Rao Cc: Job Abraham , Bruce Richardson , dpdk stable Date: Thu, 2 Nov 2017 12:02:45 +0000 Message-Id: <20171102120247.10565-16-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171102120247.10565-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> <20171102120247.10565-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'eal/x86: fix atomic cmpset' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Nov 2017 12:03:43 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/04/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From fed9c8331e53040653352b5df099bea677dce830 Mon Sep 17 00:00:00 2001 From: Nikhil Rao Date: Fri, 30 Sep 2016 02:54:53 +0530 Subject: [PATCH] eal/x86: fix atomic cmpset [ upstream commit 9d1c2a6a912bebde1139157b950e39ffa7192c9d ] The original code used movl instead of xchgl, this caused rte_atomic64_cmpset to use ebx as the lower dword of the source to cmpxchg8b instead of the lower dword of function argument "src". Fixes: af75078fece3 ("first public release") Reported-by: Job Abraham Signed-off-by: Nikhil Rao Tested-by: Job Abraham Acked-by: Bruce Richardson --- lib/librte_eal/common/include/arch/x86/rte_atomic_32.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/arch/x86/rte_atomic_32.h b/lib/librte_eal/common/include/arch/x86/rte_atomic_32.h index 2e04c7595..fb3abf187 100644 --- a/lib/librte_eal/common/include/arch/x86/rte_atomic_32.h +++ b/lib/librte_eal/common/include/arch/x86/rte_atomic_32.h @@ -81,7 +81,7 @@ rte_atomic64_cmpset(volatile uint64_t *dst, uint64_t exp, uint64_t src) : "memory" ); /* no-clobber list */ #else asm volatile ( - "mov %%ebx, %%edi\n" + "xchgl %%ebx, %%edi;\n" MPLOCKED "cmpxchg8b (%[dst]);" "setz %[res];" -- 2.11.0