From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 304C71B3D0 for ; Thu, 2 Nov 2017 13:03:24 +0100 (CET) Received: by mail-wr0-f193.google.com with SMTP id y9so4779496wrb.2 for ; Thu, 02 Nov 2017 05:03:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xIkutAD+X4mKt4SKGoDpa4fLrVa8DyTgjPtj71Zbccs=; b=Z8uxrXyPQSsOG1vPrdJhw2tp90Nm5ToQZYZdf4W+mmOKH1jieBvvvlGXnmk+swD+ej NYqdAQr/hG1GoNiRB/kiW3b6ljmwpyPIPiQ4GP+LmW7ZcmXR75WQR27l0XUJyTsqHkc+ Ct0DLub3nqWqgXS3z+ib5mnY9FIPTQ9RwYMSu3JtbbMPjmPhqbm7zfpL8KFPG6iaElUB S1kX0oX1cuvSyqCfpsWnI9Cmd1xKUToUz/ZIZNqeYgctT5VwePlssvG5JAu+B3FowvFm e38xH/ku1bkRzt63lzuLeii1/FF4Lb10GqLkFg7G8FtbGBwLBTNRelZZqLDZQC/ETZuM fIDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xIkutAD+X4mKt4SKGoDpa4fLrVa8DyTgjPtj71Zbccs=; b=FBEidHPg6jgg8zzu8Se0jZahT1cD/4CMmN6byS74Y4KMtZ+Vmm43IJWc8GfIhm78Dc 4/0nyP2Ev0DXZZVajvRSwufVdcV8UDxkkq/iWMKPUZgXoqVCFuEOyJbeNYfltmExy5Lw H9VUDsTIdRef0BnrXMlII2/xG6lHby7y/cjcG93t+WheT4QLjGfASjoNbkCrIdtPVTLg p3/ekh7Sej/Onh4alL23ufIT1BUzHiIBB7zJzeFKnCNL69b/h4+rmX9pCWMfhXDX6Rdn jRGZlrfwWAB3h/cKD6PPLMzC/Ws+np9DwHepbGi3MrjUzVj9qbbUliwZVH+yZtNt8b17 4hCA== X-Gm-Message-State: AMCzsaWmsNZWe/ok7Vhg2b4TK1wwMyEPvO7OCe7ENWEgXHJRudm6Mq5T 3w//mRh/70jEBkeuzMRHPRE= X-Google-Smtp-Source: ABhQp+TfyTUCOgu0tJBy2GCAv3cJlZWOH3IcoKtebEMAckBa761IbLPTDVfD0QRhNXfiJR7V/Q/yQA== X-Received: by 10.223.176.214 with SMTP id j22mr3035682wra.24.1509624203886; Thu, 02 Nov 2017 05:03:23 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id q7sm3090661wrg.97.2017.11.02.05.03.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Nov 2017 05:03:23 -0700 (PDT) From: luca.boccassi@gmail.com To: Zhiyong Yang Cc: Maxime Coquelin , Yuanhan Liu , dpdk stable Date: Thu, 2 Nov 2017 12:02:32 +0000 Message-Id: <20171102120247.10565-3-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171102120247.10565-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> <20171102120247.10565-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/virtio: fix Tx packet length stats' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Nov 2017 12:03:24 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/04/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From ab7510c1a80d12547abd886610851c71449f1ac9 Mon Sep 17 00:00:00 2001 From: Zhiyong Yang Date: Tue, 24 Oct 2017 11:06:14 +0800 Subject: [PATCH] net/virtio: fix Tx packet length stats [ upstream commit f1216c1eca5a54706af9f13133d06b3477099f8b ] In the function virtqueue_enqueue_xmit(), when can_push is true, vtnet_hdr_size is added to pkt_len by calling rte_pktmbuf_prepend. which is wrong for pkt stats, virtio header length should be subtracted before calling stats function. Fixes: 58169a9c8153 ("net/virtio: support Tx checksum offload") Signed-off-by: Zhiyong Yang Reviewed-by: Maxime Coquelin Acked-by: Yuanhan Liu --- drivers/net/virtio/virtio_rxtx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index aa985fb6b..43fac63b6 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -291,6 +291,10 @@ virtqueue_enqueue_xmit(struct virtnet_tx *txvq, struct rte_mbuf *cookie, /* prepend cannot fail, checked by caller */ hdr = (struct virtio_net_hdr *) rte_pktmbuf_prepend(cookie, head_size); + /* rte_pktmbuf_prepend() counts the hdr size to the pkt length, + * which is wrong. Below subtract restores correct pkt size. + */ + cookie->pkt_len -= head_size; /* if offload disabled, it is not zeroed below, do it now */ if (offload == 0) { ASSIGN_UNLESS_EQUAL(hdr->csum_start, 0); -- 2.11.0