From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id A4E931B3D0 for ; Thu, 2 Nov 2017 13:03:25 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id p75so10565630wmg.3 for ; Thu, 02 Nov 2017 05:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ONa6XClhJoVMyVA1Rsy6XRCYcMkSReOX+d+fd1UAupU=; b=EScWEPsaz6oE2oru1Jh/05CFQLBeEMvdNCYFveRQk4hw3x2C8BzksXsZoJ8Eydzjqy Uk2pfLjn8j0TCa1wX0Y8Sx9SeMyqZbNhDcflqBFFchvB6RaoVbYO44bhd0NBtITc3LKk HSxgHgE1eb89srUqKvF98lcne1vq7gzvBRE4hZlhTlIy7xqfvl+HgRPvm+OsXvvHLHHW rVLBG+6nNtgIyDVmjmrSre96CedDW8kNo8JIhyftuOtjFnWqIP1OX4KLl3pYtKR8GUvM Sac3Z8oK0DYtjK/PXq9zSyihe+xJToOMmV7EFM2K54Xs3s1wRc3tR6yOCCuQLZTNAKfH 8oAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ONa6XClhJoVMyVA1Rsy6XRCYcMkSReOX+d+fd1UAupU=; b=e66CwQ0egE1JpWxeaPmSQieSlPuzwLEA2K6C6ddtgJ8LkJ0spqKgsMZJbOE0vu21t4 F7hopyfd/Eonlu/6c6dhy09QkYFhfrrq9QD7nIvPVKOD0gWjlBks7VidrpuDqhAIq/yz gDtlTPbm6drydwlUek5h66R0f91yvMkpsogD0JLSsSc/tvkYbh/jSJeCvVFyFdaXYhfI f97XWU40RtBEbrJmO1rN0ggq+Cn70vKd8QUZb3DGkEqfMooLpWo/ARiUCGb4OS7QtkZS 8jCf5jrEZ71sBpup51qK4coFN2irECbRTZBZVP8K+ygg/2vaoHndxlaYvgbvTgTmPoWl qd2g== X-Gm-Message-State: AJaThX5TsTPCO4sRwtu7VMfKlYEyjDvNMoskOOFE/7pjqqqqJO0UkdGO V+M6SUMo81Ypbns8tWcSWn5BcHWU X-Google-Smtp-Source: ABhQp+RpiOY0C6u33eIEQHRU5WoE/5A+SD/FMiUQuvDa1moaw2ra0YWspDqVWXt/e+P+S+gsJ4qpPg== X-Received: by 10.28.122.22 with SMTP id v22mr1426865wmc.47.1509624205268; Thu, 02 Nov 2017 05:03:25 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id m187sm6819030wmb.17.2017.11.02.05.03.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Nov 2017 05:03:24 -0700 (PDT) From: luca.boccassi@gmail.com To: Jasvinder Singh Cc: dpdk stable Date: Thu, 2 Nov 2017 12:02:33 +0000 Message-Id: <20171102120247.10565-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171102120247.10565-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> <20171102120247.10565-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'examples/qos_sched: fix uninitialized config' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Nov 2017 12:03:25 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/04/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From 9da80b9877bae699fdd98158ba536d15a26ebf16 Mon Sep 17 00:00:00 2001 From: Jasvinder Singh Date: Tue, 24 Oct 2017 10:09:57 +0100 Subject: [PATCH] examples/qos_sched: fix uninitialized config [ upstream commit 96b5077cfaf95cd38dc7644e39036ad94e6435c8 ] Fix problem with uninitialized rx/tx deferred_start flags of the struct rte_eth_rxconf/txconf by initializing with 0 value (deferred start of the rx/tx queues is turned off). This setting allows device rx/tx queues to start with rte_eth_dev_start(). Coverity issue: 194999, 195009 Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: Jasvinder Singh --- examples/qos_sched/init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index fe0221c6f..51ba5fb75 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -116,6 +116,7 @@ app_init_port(uint8_t portid, struct rte_mempool *mp) rx_conf.rx_thresh.wthresh = rx_thresh.wthresh; rx_conf.rx_free_thresh = 32; rx_conf.rx_drop_en = 0; + rx_conf.rx_deferred_start = 0; tx_conf.tx_thresh.pthresh = tx_thresh.pthresh; tx_conf.tx_thresh.hthresh = tx_thresh.hthresh; @@ -123,6 +124,7 @@ app_init_port(uint8_t portid, struct rte_mempool *mp) tx_conf.tx_free_thresh = 0; tx_conf.tx_rs_thresh = 0; tx_conf.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOOFFLOADS; + tx_conf.tx_deferred_start = 0; /* init port */ RTE_LOG(INFO, APP, "Initializing port %"PRIu8"... ", portid); -- 2.11.0