From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 50FB41B5E7 for ; Thu, 2 Nov 2017 13:03:33 +0100 (CET) Received: by mail-wr0-f196.google.com with SMTP id p96so4771049wrb.7 for ; Thu, 02 Nov 2017 05:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mliRZAT9SWrWzPdbFVK8Hdz2MFRM4aWAaYUfrfbU8OM=; b=pLnsPpihzWqW5qydxtYD+OZIPcq2+ndeR8d0HhJ+JdXgTxxjZeFWfRhJwYrnAHSuiD csaZL4AolKHIvnmEiKZSkPT2nl+Uyu9gZWLDnp8108ZOgKaSi3tGGY7V6+LPZb97BCsu OtwuSlrejytS0wKQnZRaBOLK3HylBgbtYPhlvXm+xTVRFbVEC0wyL3I0qivOTY2apWl7 rk4dqbeXDvYBbAFXSDswYqOuY0pEw56kMgm1mtLgF/OlZITZOT5H9bkWJYOUqfm4h+m4 VCrBUr/qPPgjkLiGMWrIdTEf2ajm39RRRPo4UK4mV16d8eiJyIKlWT3+pQKJGmsUiiz0 Bv8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mliRZAT9SWrWzPdbFVK8Hdz2MFRM4aWAaYUfrfbU8OM=; b=CjiW43iTxVcSGTE1KGpkkacr9RlIp5+hj0s7H21bNvG2+Vb2JTHh4wfcKtZr2N09N2 AZ3mvmh7N+3akKstSFZ80L4FneIkK85gZdXjZ/ddJsWvIFnf04N5HoKnVfpwlYR4mIb1 su9NNEdW1W/21wQ/d07YegbYpEZoYOo3uQvXy9JKWo5I9FdjJ0hF5saOP4GJm0DYJr1M avqPZfOQX+4biKSZRo0xxHOmnt/FG3Y9ApY5SL/A7HRR+oMOK2eUcqRPX5+R5lvnwUly 0hPH7UaV2fNOggSitgAZAVpuWRJfcl5b5FN7AjKFAnP5CcSX/aEsqvN2c/5fQtA4dWvf GCSA== X-Gm-Message-State: AMCzsaVABeTnqmcKWffafDrxgJ6C45x8+m1xNi3VfLD0H1MD2VcV6O3a Hxnf5IhUgnK2/hCY5e5dlwE= X-Google-Smtp-Source: ABhQp+R/doVQRIB6tetmxVWkUZkR+EZk9lRggTT+1FNUhn9BxWH5YvpfFKkqyn7rg2rwn/9VmoapUg== X-Received: by 10.223.159.81 with SMTP id f17mr2594213wrg.4.1509624212749; Thu, 02 Nov 2017 05:03:32 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id i12sm3393422wra.40.2017.11.02.05.03.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Nov 2017 05:03:32 -0700 (PDT) From: luca.boccassi@gmail.com To: John Daley Cc: dpdk stable Date: Thu, 2 Nov 2017 12:02:38 +0000 Message-Id: <20171102120247.10565-9-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171102120247.10565-1-luca.boccassi@gmail.com> References: <20171030153511.13322-1-luca.boccassi@gmail.com> <20171102120247.10565-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/enic: fix packet loss after MTU change' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Nov 2017 12:03:33 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/04/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From 02d632155451162a76705a8123a668c727c954c6 Mon Sep 17 00:00:00 2001 From: John Daley Date: Mon, 23 Oct 2017 13:23:00 -0700 Subject: [PATCH] net/enic: fix packet loss after MTU change [ upstream commit ea5f15b1c49a687eaa57d435a8bf68e553b50b30 ] If multiple Rx queues and Rx Scatter are used and the MTU is modified so that the number of mbufs per packet changes, packet loss is possible. The enic completion queue index was miscalculated leaving the upper half of the queues uninitialized after an MTU change, possibly leading to completions on those queues not getting processed. Fixes: c3e09182bcd6 ("net/enic: support scatter Rx in MTU update") Signed-off-by: John Daley --- drivers/net/enic/enic_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index 86c5539f3..b25eff4f1 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -1125,11 +1125,12 @@ static int enic_reinit_rq(struct enic *enic, unsigned int rq_idx) { struct vnic_rq *sop_rq, *data_rq; - unsigned int cq_idx = enic_cq_rq(enic, rq_idx); + unsigned int cq_idx; int rc = 0; sop_rq = &enic->rq[enic_rte_rq_idx_to_sop_idx(rq_idx)]; data_rq = &enic->rq[enic_rte_rq_idx_to_data_idx(rq_idx)]; + cq_idx = rq_idx; vnic_cq_clean(&enic->cq[cq_idx]); vnic_cq_init(&enic->cq[cq_idx], -- 2.11.0