From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Alejandro Lucero <alejandro.lucero@netronome.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/nfp: initialize stats struct
Date: Fri, 10 Nov 2017 13:05:54 +0900 [thread overview]
Message-ID: <20171110130554.3e491e70@shemminger-XPS-13-9360> (raw)
In-Reply-To: <15bd63fc-1c14-faae-ac09-b94375fb1553@intel.com>
On Thu, 9 Nov 2017 17:10:16 -0800
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 11/8/2017 3:59 AM, Alejandro Lucero wrote:
> > Not all struct fields will be written and random data could
> > confuse readers.
> >
> > Fixes: 92aa491b881e ("nfp: add statistics")
> > Coverity: 140755
>
> Hi Alejandro,
>
> Thank you for coverity fixes, but they will be considered for next release,
> since trying to limit rc4 only for critical fixes.
>
> Thanks,
> ferruh
>
> >
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
>
This looks like a bug fix. because the stats are on the stack and will
be garbage.
next prev parent reply other threads:[~2017-11-10 4:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 11:59 [dpdk-stable] " Alejandro Lucero
2017-11-10 1:10 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2017-11-10 4:05 ` Stephen Hemminger [this message]
2017-11-10 8:55 ` Ferruh Yigit
2017-11-10 9:37 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110130554.3e491e70@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).