From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 413781B215 for ; Fri, 10 Nov 2017 17:10:10 +0100 (CET) Received: by mail-wr0-f194.google.com with SMTP id j23so9019248wra.9 for ; Fri, 10 Nov 2017 08:10:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aC2Ikhj5wYF99pQyx7Go6sqnKkwlpOp5Y5gmamQUjfE=; b=WN55shPvqthyKkH4f4Wolmw6qxUA3PIaD28aBSOxVLSDKAEI2USr3B4C2TpalwqWWt odF0a8HYsCM8Vi2e5B8+ka6Hx6j/ZSg0tDqAL8dh58PcwP/yLjf5ihnGy6lV18axjB8J sHTgPNwEwHnpxn1Pc1YSUiV1nn7g5fYFmPvHjbzEd7Ltuhufm5C4HcY3c5FdFl+S27ra /wzBnXtAQkDd3DOpQd/WxaW2LEuHA14St0th85Na8gS7R75T9uK6ti6lbW3LsbcBb+VP zI7BHeM/U/BtiyFDm6rn1Yj71I3pMP/gw7Uln0KSmWQ8TnI5r0KRdA+CWCDm3MnVldm1 xFtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aC2Ikhj5wYF99pQyx7Go6sqnKkwlpOp5Y5gmamQUjfE=; b=YvZ2dd+6P4DvxSs3Bs1XyWPwfXGDWJ3d4b3WDGF7Sv8yvWuxdR2PzEi0wZpTkGE+Uv yFU374MJl2sfRHtffGiRVCV1yKTnPGtjsNjMs1UDLezepHQtaYOn5g/Vni9yU3vE48ZH AXcLcPfIS9q92+D1RYeN4KdjWJBOldEecaXh3YDmvx2Jr4C4bBWkVulzyvEPvxQLq3bH Z1063Gd+fMpXx+DfiSfJO90BjTpm8fst6FGJwuin3bt6tvdun2AQHH+w2Kz95VmZDMoP PhB7/KnIjOmkx6V3TKhXofWl8IPR+FTMC5earg6p4iJTVS08BNy70qlrz6H6MgYUM1HR BwWw== X-Gm-Message-State: AJaThX6df9GSMuqObN6nj/PZy98zWUPe93Ntfx1s9HodAnamJznuCoSk eS0lDUgrpcviuCOER1JURcI= X-Google-Smtp-Source: AGs4zMbTREPaP4ZeuXCssLNAttETYZP53oq6C5FGOrtywcinDPNGbLNgpiuvfhkc6TkQk3zCzrBNMA== X-Received: by 10.223.160.86 with SMTP id l22mr724819wrl.187.1510330209764; Fri, 10 Nov 2017 08:10:09 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id o70sm28241400wrb.62.2017.11.10.08.10.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Nov 2017 08:10:08 -0800 (PST) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: dpdk stable Date: Fri, 10 Nov 2017 16:09:45 +0000 Message-Id: <20171110161000.15369-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171102120247.10565-18-luca.boccassi@gmail.com> References: <20171102120247.10565-18-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'buildtools: fix icc build' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Nov 2017 16:10:10 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From b1076ba6bc492dedbc50d6033dd5bbd622a9225a Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Thu, 2 Nov 2017 00:25:10 +0000 Subject: [PATCH] buildtools: fix icc build MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit a462a6a9e7705e0a8e855ed42377041ff0efc908 ] There are random build errors in test reports [1]. Build error is not directly related to DPDK but observed during DPDK build. When I get similar unexpected build errors in my system, found out that /dev/null is invalid. It seems ICC overwrites the /dev/null with "icc -o /dev/null" instead of sending output to /dev/null. This is not always reproducible, so hard to say what exactly is triggering the error. I suspect test-report build errors can be because of the same reason, and it is good to add a protection for this case. Instead of sending output to /dev/null save it to the tmp folder and remove it back when done. [1] http://dpdk.org/ml/archives/test-report/2017-November/034053.html Failure #3 /usr/src/linux-headers-4.4.0-97-generic/include/linux/sysfs.h:517:37: error: pointer targets in passing argument 2 of ‘kernfs_find_and_get’ differ in signedness [-Werror=pointer-sign] return kernfs_find_and_get(parent, name); Signed-off-by: Ferruh Yigit --- scripts/auto-config-h.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/auto-config-h.sh b/scripts/auto-config-h.sh index 4356d7e38..cb8bce9b8 100755 --- a/scripts/auto-config-h.sh +++ b/scripts/auto-config-h.sh @@ -114,9 +114,9 @@ printf "\ " "$include" "$code" > "${temp}" && if ${CC} ${CPPFLAGS} ${EXTRA_CPPFLAGS} ${CFLAGS} ${EXTRA_CFLAGS} \ ${AUTO_CONFIG_CFLAGS} \ - -c -o /dev/null "${temp}" 1>&${out} 2>&${err} + -c -o ${temp}.o "${temp}" 1>&${out} 2>&${err} then - rm -f "${temp}" + rm -f "${temp}" "${temp}.o" printf "\ #ifndef %s #define %s 1 @@ -125,7 +125,7 @@ then " "${macro}" "${macro}" "${macro}" >> "${file}" && printf 'Defining %s.\n' "${macro}" else - rm -f "${temp}" + rm -f "${temp}" "${temp}.o" printf "\ /* %s is not defined. */ -- 2.11.0