From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 370361B70E for ; Fri, 10 Nov 2017 17:10:26 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id z3so3746119wme.5 for ; Fri, 10 Nov 2017 08:10:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xksa2ggFBEclahNE4yDjDqIRaHr3HmFzFXBP8KI5Wdc=; b=ooc9fCEIzolda+xzHFdSahlEx4jadiISYDSkmAK1O+8G5uhTJiwhl6WjPsdk0W8tm3 uwWKBdNDvH6BHlp3Bip3eYD/+ysxQV587yWu+E8ezDlpSpCb1PRKuFfc/TksjOxt26D6 W5AQ8t20ntvJPTeOZrimdWL00coHbxLLegt/9w5PQweL133KiqlyCsx2YpL5gGokhaIn FkE26Tqruj298AD5Nm08zWJ7FngIwExkKQKzp+izKTM8wr0X5h6mwAx2+ON/YNQY9TW5 uoaXNQuWaXGQok7Prvqpgn+w64ANOrvJRHVjVWz6TG2UemuC7jb3bi1C84uEewtzpRR3 R3GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xksa2ggFBEclahNE4yDjDqIRaHr3HmFzFXBP8KI5Wdc=; b=qXLLgIdEOsWNoeGoFW5VNv4UiIyfrAdAePfQlZsZ4VjC4PW8hiWZQjcTNg/UE1ThSF YTsyeaxTCwDTE5q0adn9laxr8LD3KClk/fjyEEYf3TpHUXsscXxpaa6m8tXXx76UkDdz k+YxkO3MKWmiFi4UYugLvpQz5Zv2frmLtypAmceYpsWOjAw7aa2DzOjmP/ZAD/zqe1wo 7tickhN4nlwEMCYmv+nvJXjAdlFxa/sJPy+GGHlu67pAdMYp2JcBzFT6YrHd33x5k8cj Y85kV6B11RfSOKZwml3XUWPFeLUQ6f61M/DV/BpQTwUTdncuN9xLpPxtw8Sp2Sc6xwf8 MNtw== X-Gm-Message-State: AJaThX7OWJMNwPRrZFJ2GtyhKWHPZMnxrGzmmZpd7ibq+XEImaY993p5 u8mvgodwrKMsB3/PCXF7ybQ= X-Google-Smtp-Source: AGs4zMZLS6yp5uAywo7xyLc7jsn+k6KAyxaAO0Xt5S8xi6+es6ILeDKmZ5TmX05r/CUGz/ZmINFncw== X-Received: by 10.28.30.151 with SMTP id e145mr613452wme.8.1510330225943; Fri, 10 Nov 2017 08:10:25 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id d4sm2712430wmh.35.2017.11.10.08.10.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Nov 2017 08:10:25 -0800 (PST) From: luca.boccassi@gmail.com To: Ophir Munk Cc: Raslan Darawsheh , Pablo de Lara , dpdk stable Date: Fri, 10 Nov 2017 16:09:55 +0000 Message-Id: <20171110161000.15369-11-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171110161000.15369-1-luca.boccassi@gmail.com> References: <20171102120247.10565-18-luca.boccassi@gmail.com> <20171110161000.15369-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'app/testpmd: fix forwarding between non consecutive ports' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Nov 2017 16:10:26 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From f7d56b8e49954dd481db419361a51322c91b77d4 Mon Sep 17 00:00:00 2001 From: Ophir Munk Date: Tue, 7 Nov 2017 13:52:30 +0000 Subject: [PATCH] app/testpmd: fix forwarding between non consecutive ports [ upstream commit fafee5e9caaf439b29a6e10600e91b8de81eff66 ] When defining two failsafe devices in testpmd the port numbers of the failsafe devices may not be consecutive. For example: if failsafe device includes a PCI device and a TAP device then failsafe port numbers would be 0 and 3. Port 0 - failsafe #1 device Port 1 - PCI #1 device Port 2 - TAP #1 device Port 3 - failsafe #2 device Port 4 - PCI #2 device Port 5 - TAP #2 device If forwarding is defined between the failsafe devices including a peer address the forwarding should be between peer addresses of ports 0 and 3. Instead testpmd establishes forwarding between peer addresses of consecutive ports 0 and 1. This commit fixes this bug. Fixes: af75078fece3 ("first public release") Signed-off-by: Ophir Munk Signed-off-by: Raslan Darawsheh Acked-by: Pablo de Lara --- app/test-pmd/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 56a7ec679..c50b62efd 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1199,7 +1199,7 @@ simple_fwd_config_setup(void) fwd_streams[i]->rx_queue = 0; fwd_streams[i]->tx_port = fwd_ports_ids[j]; fwd_streams[i]->tx_queue = 0; - fwd_streams[i]->peer_addr = j; + fwd_streams[i]->peer_addr = fwd_streams[i]->tx_port; fwd_streams[i]->retry_enabled = retry_enabled; if (port_topology == PORT_TOPOLOGY_PAIRED) { @@ -1207,7 +1207,7 @@ simple_fwd_config_setup(void) fwd_streams[j]->rx_queue = 0; fwd_streams[j]->tx_port = fwd_ports_ids[i]; fwd_streams[j]->tx_queue = 0; - fwd_streams[j]->peer_addr = i; + fwd_streams[j]->peer_addr = fwd_streams[j]->tx_port; fwd_streams[j]->retry_enabled = retry_enabled; } } -- 2.11.0