From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 496281B1C7 for ; Fri, 10 Nov 2017 17:10:33 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id p75so3726440wmg.3 for ; Fri, 10 Nov 2017 08:10:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=l6+xUF5OrZy9TS3s3u9OecjqQ1Ypj4hGbahO+4esADQ=; b=VRxhR+VkGvrbt1SFDgcyBDNYMyyemXi8YJ91RoGeR8D0h/hqAkx8+5BCWkihQy9bvW QnPjofTq4hkvGkMaMF5nNW0YAvGF2CFeYqakkxIMq9oQwRJOqOhrwYsTomvu2fvVE0kf W/269elXzgMFuyI5IWakUUrnyndEHMq5Ac8WvMVS53ogven3qvkyFA5b3RRr8uT5ZyQg lbMgLkO0BXDa80SEk1Kz/1qynM0jmoJLK7ECguuy9PCqQYgGBz8TyI3Ko/8wlZ50aRMB ljT3hHk3Te5KF1RgXmBnfOySww/kaulj4fJ0TlOIpZ1A6lv527lLTNb0cC0bZgOKr7vX CF/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=l6+xUF5OrZy9TS3s3u9OecjqQ1Ypj4hGbahO+4esADQ=; b=oF2gFHB1jLqEeeMkPlA1Y2+gaMxW9UAdMA21rZS0tcWpVek7qibYnIPuez54RlSM0x BZ1LWTn/N1wouUhp9uc0XJ+zwyXuVjk/30QwgPYlghCFBw1oQkJlgTpGOT1UpQEpE5oC ZfKwczdOxiuXfLCZaMH768tb+JydAKYya9ZFkwb0i3rETOe8hzko4pO3zVzfjeCVpNxJ TYEu9gMN6WbiULBG8B4fMjyqBWwztXNgvocPbfGzHWw044pzV8YHIaesVbatgwD5XKGO QtSYqu4lZBPjFAYGLfFmYiWlCyyM3dGbzy6/eqUaXomiCYMdZg65tv8/xKp5Kz3oJMBR +yqQ== X-Gm-Message-State: AJaThX6YWsJioI6le6jzZlPZ0gyjvjXX5BKX3HOVkFOFd1qkSA2WrAIt D2D3bL8DywcIhygAP0Q1Zk8voUW+Bl0= X-Google-Smtp-Source: AGs4zMaqO5YGrmlokEtQjP5FNOSX41KH+Z9B5to2PW1ZCAt6TK5fwT1LGI2ZfJkp82BAYrL/o+m22A== X-Received: by 10.28.237.18 with SMTP id l18mr607224wmh.136.1510330233032; Fri, 10 Nov 2017 08:10:33 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id p23sm17819408wrb.76.2017.11.10.08.10.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Nov 2017 08:10:32 -0800 (PST) From: luca.boccassi@gmail.com To: Yong Wang Cc: dpdk stable Date: Fri, 10 Nov 2017 16:10:00 +0000 Message-Id: <20171110161000.15369-16-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171110161000.15369-1-luca.boccassi@gmail.com> References: <20171102120247.10565-18-luca.boccassi@gmail.com> <20171110161000.15369-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'buildtools: check allocation error in pmdinfogen' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Nov 2017 16:10:33 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From 557277fd6818584b3cc4ba746a1baae48c786304 Mon Sep 17 00:00:00 2001 From: Yong Wang Date: Fri, 15 Sep 2017 07:33:08 -0400 Subject: [PATCH] buildtools: check allocation error in pmdinfogen [ upstream commit 3b29f60f2d584d5086b735e0a6fab518a17eaa1e ] In func locate_pmd_entries(), pointer 'new' returned from call to func 'calloc' may be NULL. It is dereferenced without null point check. Signed-off-by: Yong Wang --- buildtools/pmdinfogen/pmdinfogen.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c index 5bf08ced8..df10a2f9f 100644 --- a/buildtools/pmdinfogen/pmdinfogen.c +++ b/buildtools/pmdinfogen/pmdinfogen.c @@ -326,6 +326,10 @@ static int locate_pmd_entries(struct elf_info *info) do { new = calloc(sizeof(struct pmd_driver), 1); + if (new == NULL) { + fprintf(stderr, "Failed to calloc memory\n"); + return -1; + } new->name_sym = find_sym_in_symtab(info, "this_pmd_name", last); last = new->name_sym; if (!new->name_sym) @@ -407,7 +411,8 @@ int main(int argc, char **argv) } parse_elf(&info, argv[1]); - locate_pmd_entries(&info); + if (locate_pmd_entries(&info) < 0) + exit(1); if (info.drivers) { output_pmd_info_string(&info, argv[2]); -- 2.11.0