From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id E89361B394 for ; Mon, 13 Nov 2017 15:49:54 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id g141so15691660wmg.2 for ; Mon, 13 Nov 2017 06:49:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=T5LhzjFPHsp1uZBCnCd3fDIzTiT5f2i6J0tN0Du9v1g=; b=WKVuoppkgyseTUT3uZ63PYOp3WCthD8QdYyaJad95rmIhWUt/J54jGCRWw37sZHkH2 n6xiqDV+iTILWxskz+rhKR8wLamLwkymm1LJ66ghYy4lObPVEvEAMK/v9ZXAzNbVXUIq HgFFyYFjBdc0Ik60YUcPJX1jR42ZLWji6kH+z4AZWMatmhkbav2PQL6WCuBeXMdmno7f Azm6w7NYGJ6frS3krFpQ44/++4lH7X3Cp0XfAGyCb7IvXVQ/VzmqeSsa4QPp4FTCJ4Az p8/9XVdkwLYA/988uTOI6cdsdv5cgPTvgRFv5Sk2HB7TSws4goklaBYgHMCpP8BBNcah 77vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=T5LhzjFPHsp1uZBCnCd3fDIzTiT5f2i6J0tN0Du9v1g=; b=Qbrr3rZ3+n0NHn2yBK/475vOD6uGdQIJZUAyHS0IyoA1OqKqeleFsHib+cLMX5GzjP HsH67KfG4tgIDmPc1hSrm6B6Sk3rn+po4zHvwkJl1w7JX2n1q2XDmpq1M//WctaQb0Wa H0xxNiLP0I9kqju77BzllR/7px+jBU25CN0m+NbGbSZHZOeHA1APhefQF9YehE8Lhh77 Zo5fDfEf/2iK6FqCbSiuv7M/FU8RXpYBfHBu6P+r1A44h5IPpU2EPCAYYMLxcdypYaue MvPNG496Pryyk/ntCluxxMCqDeycCY0Y60DN2993bRDhjEVDEjZORCpiifGkCTeC07A0 X0Ww== X-Gm-Message-State: AJaThX5YkymD0z/6APED7Ak8VCoD79GgO/Xy6kdyFk+mRpazwPfV5xoi 8ioWpFtnTIQhr1QEbdE+GkxCUnIy X-Google-Smtp-Source: AGs4zMZJnG7K3q7P2ZqCm9cgL1Qtxr8J6squjfKIWd/H1GqGwo0EkGpkNLDG4812VnPoylOMIpzwrg== X-Received: by 10.28.24.203 with SMTP id 194mr6728345wmy.34.1510584594311; Mon, 13 Nov 2017 06:49:54 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id 10sm12627027wml.27.2017.11.13.06.49.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Nov 2017 06:49:53 -0800 (PST) From: luca.boccassi@gmail.com To: "Ilya V. Matveychikov" Cc: dpdk stable Date: Mon, 13 Nov 2017 14:49:37 +0000 Message-Id: <20171113144938.30993-6-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171113144938.30993-1-luca.boccassi@gmail.com> References: <20171110161000.15369-16-luca.boccassi@gmail.com> <20171113144938.30993-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'pdump: fix possible mbuf leak on failure' has been queued to LTS release 16.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2017 14:49:55 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/15/17. So please shout if anyone has objections. Thanks. Kind regards, Luca Boccassi --- >>From 1b8810926176b5a3d5707da8cc3d135b1c97fbf2 Mon Sep 17 00:00:00 2001 From: "Ilya V. Matveychikov" Date: Fri, 10 Nov 2017 16:55:16 +0300 Subject: [PATCH] pdump: fix possible mbuf leak on failure [ upstream commit ef1d0e390e056916438ad74c4fa0333c3f09aaa6 ] If pdump_pktmbuf_copy_data() fails it's possible to have segment leak as rte_pktmbuf_free() only handles m_dup chain but not the seg just allocated and yet not chained. Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Ilya V. Matveychikov --- lib/librte_pdump/rte_pdump.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c index 596868374..e64bf598c 100644 --- a/lib/librte_pdump/rte_pdump.c +++ b/lib/librte_pdump/rte_pdump.c @@ -154,6 +154,8 @@ pdump_pktmbuf_copy(struct rte_mbuf *m, struct rte_mempool *mp) do { nseg++; if (pdump_pktmbuf_copy_data(seg, m) < 0) { + if (seg != m_dup) + rte_pktmbuf_free_seg(seg); rte_pktmbuf_free(m_dup); return NULL; } -- 2.11.0