From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id BB9A82BBE for ; Thu, 23 Nov 2017 18:38:12 +0100 (CET) Received: by mail-wr0-f195.google.com with SMTP id w95so18262545wrc.2 for ; Thu, 23 Nov 2017 09:38:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+u7uaUXz/eCLPQ8nOVyP5Nz376faLIX0EOrmPeDGMvo=; b=0f7ew1cybqwvV5dAMT8WmqLksnmgVGR+fxSDazKGDaWjstUJNaEgs2jgcMe6jmApn5 pev5BEF8QVsq07PphTGV0oTKc+v5On/Mxm6cpUUeXZPdxk+7ta7wIctiNFr1MLw6Okbv Bgj0e223xyKlq7pVPElS3IUH6PgtkVVYiOTwQueVO5ji7iGiiW6rNSVrc5S0psuDd3n4 81SpKnc45mxjnsDA9IT4j8gmM2jnDSfUSNEGM2xJe/tXegXE2icXHCZk7ZUWVhf4PmRm Tx0xWnrQFakvHCzbpH6m6iJKwqFy/Ub4k0bKy0Xo/Yl4sUJ05D0anPbt1r67wESJrwNr C5RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+u7uaUXz/eCLPQ8nOVyP5Nz376faLIX0EOrmPeDGMvo=; b=lPIkko0GOzluL8WEqfLAMedkDOfVgTKJ8/iV2QUQFrUpV+iMur5EuwjuflWO40cHKp EkEr89HXd4btS9El9E3Ah21Vx2nXurB0GnLnzE0/NvfujA/DJzL2K7oFg+QYpu26GP56 1R3SDTk8VDeByvfudE3v6h0Hg9Dejx9S3KTwzhzudohZAoXZeMnlpgiYahKblL245CRk dzCk0uZbJbFmU9dATXODrNOs0dBSPtKv/sOdDv5RgkBafJGAzFUT07iV9ro/FJBZS7+g sdVXbL+UNs1j0TgjaytxbJTIpI/+zFECd+K2wgIoDVjUgq4GE1G6iXOtFRq0hTHQcnvM P6Aw== X-Gm-Message-State: AJaThX7PQezJcKttCtGRn4NPunteTPffBIz3HMCnhFsprlvQe0Axq1uD gpZ7lDX3vfGda2cEOLHYyZaQnQ== X-Google-Smtp-Source: AGs4zMZXOti56RUbPCukVVOtVM0aQM7I86phdcvhQEXnWfF1v0XGxoF2dBbo0YxvhZ1ncW1+EXQWrQ== X-Received: by 10.223.139.8 with SMTP id n8mr19265338wra.225.1511458692338; Thu, 23 Nov 2017 09:38:12 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 128sm7717469wmi.28.2017.11.23.09.38.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Nov 2017 09:38:11 -0800 (PST) Date: Thu, 23 Nov 2017 18:38:00 +0100 From: Adrien Mazarguil To: Shahaf Shuler Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org, Neil Horman Message-ID: <20171123172640.28827-4-adrien.mazarguil@6wind.com> References: <1511272929-17955-1-git-send-email-adrien.mazarguil@6wind.com> <20171123172640.28827-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171123172640.28827-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-stable] [PATCH v2 3/5] net/mlx4: use function to get default RSS fields X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 17:38:12 -0000 Supported RSS hash fields are listed in function mlx4_conv_rss_hf() and duplicated in mlx4_flow_prepare(); the latter are used when RSS is requested without specifying any parameters. This commit standardizes on mlx4_conv_rss_hf(). Signed-off-by: Adrien Mazarguil Acked-by: Neil Horman --- drivers/net/mlx4/mlx4_flow.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 8b87b2989..7397dde26 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -105,6 +105,9 @@ struct mlx4_drop { /** * Convert DPDK RSS hash fields to their Verbs equivalent. * + * This function returns the supported (default) set when @p rss_hf has + * special value (uint64_t)-1. + * * @param rss_hf * Hash fields in DPDK format (see struct rte_eth_rss_conf). * @@ -154,6 +157,8 @@ mlx4_conv_rss_hf(uint64_t rss_hf) seen |= rss_hf & in[i]; conv |= out[i]; } + if (rss_hf == (uint64_t)-1) + return conv; if (!(rss_hf & ~seen)) return conv; rte_errno = ENOTSUP; @@ -759,10 +764,7 @@ mlx4_flow_prepare(struct priv *priv, &(struct rte_eth_rss_conf){ .rss_key = mlx4_rss_hash_key_default, .rss_key_len = MLX4_RSS_HASH_KEY_SIZE, - .rss_hf = (ETH_RSS_IPV4 | - ETH_RSS_NONFRAG_IPV4_TCP | - ETH_RSS_IPV6 | - ETH_RSS_NONFRAG_IPV6_TCP), + .rss_hf = -1, }; /* Sanity checks. */ for (i = 0; i < rss->num; ++i) -- 2.11.0