From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Jia He <hejianet@gmail.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
konstantin.ananyev@intel.com, olivier.matz@6wind.com,
jianbo.liu@arm.com, hemant.agrawal@nxp.com, stable@dpdk.org,
Jia He <jia.he@hxt-semitech.com>
Subject: Re: [dpdk-stable] [PATCH V6 1/3] eal/arm64: remove the braces {} for dmb() and dsb()
Date: Sun, 3 Dec 2017 16:41:16 +0530 [thread overview]
Message-ID: <20171203111115.GA602@jerin> (raw)
In-Reply-To: <1511748024-7245-2-git-send-email-hejianet@gmail.com>
-----Original Message-----
> Date: Sun, 26 Nov 2017 18:00:22 -0800
> From: Jia He <hejianet@gmail.com>
> To: jerin.jacob@caviumnetworks.com, dev@dpdk.org,
> bruce.richardson@intel.com, konstantin.ananyev@intel.com
> Cc: olivier.matz@6wind.com, jianbo.liu@arm.com, hemant.agrawal@nxp.com, Jia
> He <hejianet@gmail.com>, stable@dpdk.org, Jia He <jia.he@hxt-semitech.com>
> Subject: [PATCH V6 1/3] eal/arm64: remove the braces {} for dmb() and dsb()
> X-Mailer: git-send-email 2.7.4
>
> for the code as follows:
> if (condition)
> rte_smp_rmb();
> else
> rte_smp_wmb();
> Without this patch, compiler will report this error:
> error: 'else' without a previous 'if'
>
> Fixes: 84733fd0d75e ("eal/arm: fix memory barrier definition")
> Cc: stable@dpdk.org
> Signed-off-by: Jia He <jia.he@hxt-semitech.com>
Please fix the below checkpatch errors.
Wrong tag:
Suggested-by: Ananyev, Konstantin <konstantin.ananyev@intel.com>
Wrong 'Fixes' reference:
Fixes: 84733fd0d75e ("eal/arm: fix memory barrier definition")
With above fix:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
next prev parent reply other threads:[~2017-12-03 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1510291392-33251-1-git-send-email-hejianet@gmail.com>
[not found] ` <1511748024-7245-1-git-send-email-hejianet@gmail.com>
2017-11-27 2:00 ` Jia He
2017-12-03 11:11 ` Jerin Jacob [this message]
[not found] ` <1512352212-7191-1-git-send-email-hejianet@gmail.com>
2017-12-04 1:50 ` [dpdk-stable] [PATCH V7 " Jia He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171203111115.GA602@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hejianet@gmail.com \
--cc=hemant.agrawal@nxp.com \
--cc=jia.he@hxt-semitech.com \
--cc=jianbo.liu@arm.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).