* [dpdk-stable] [PATCH V6 1/3] eal/arm64: remove the braces {} for dmb() and dsb()
[not found] ` <1511748024-7245-1-git-send-email-hejianet@gmail.com>
@ 2017-11-27 2:00 ` Jia He
2017-12-03 11:11 ` Jerin Jacob
[not found] ` <1512352212-7191-1-git-send-email-hejianet@gmail.com>
1 sibling, 1 reply; 3+ messages in thread
From: Jia He @ 2017-11-27 2:00 UTC (permalink / raw)
To: jerin.jacob, dev, bruce.richardson, konstantin.ananyev
Cc: olivier.matz, jianbo.liu, hemant.agrawal, Jia He, stable, Jia He
for the code as follows:
if (condition)
rte_smp_rmb();
else
rte_smp_wmb();
Without this patch, compiler will report this error:
error: 'else' without a previous 'if'
Fixes: 84733fd0d75e ("eal/arm: fix memory barrier definition")
Cc: stable@dpdk.org
Signed-off-by: Jia He <jia.he@hxt-semitech.com>
---
lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
index 0b70d62..71da29c 100644
--- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
+++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
@@ -43,8 +43,8 @@ extern "C" {
#include "generic/rte_atomic.h"
-#define dsb(opt) { asm volatile("dsb " #opt : : : "memory"); }
-#define dmb(opt) { asm volatile("dmb " #opt : : : "memory"); }
+#define dsb(opt) asm volatile("dsb " #opt : : : "memory")
+#define dmb(opt) asm volatile("dmb " #opt : : : "memory")
#define rte_mb() dsb(sy)
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH V6 1/3] eal/arm64: remove the braces {} for dmb() and dsb()
2017-11-27 2:00 ` [dpdk-stable] [PATCH V6 1/3] eal/arm64: remove the braces {} for dmb() and dsb() Jia He
@ 2017-12-03 11:11 ` Jerin Jacob
0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2017-12-03 11:11 UTC (permalink / raw)
To: Jia He
Cc: dev, bruce.richardson, konstantin.ananyev, olivier.matz,
jianbo.liu, hemant.agrawal, stable, Jia He
-----Original Message-----
> Date: Sun, 26 Nov 2017 18:00:22 -0800
> From: Jia He <hejianet@gmail.com>
> To: jerin.jacob@caviumnetworks.com, dev@dpdk.org,
> bruce.richardson@intel.com, konstantin.ananyev@intel.com
> Cc: olivier.matz@6wind.com, jianbo.liu@arm.com, hemant.agrawal@nxp.com, Jia
> He <hejianet@gmail.com>, stable@dpdk.org, Jia He <jia.he@hxt-semitech.com>
> Subject: [PATCH V6 1/3] eal/arm64: remove the braces {} for dmb() and dsb()
> X-Mailer: git-send-email 2.7.4
>
> for the code as follows:
> if (condition)
> rte_smp_rmb();
> else
> rte_smp_wmb();
> Without this patch, compiler will report this error:
> error: 'else' without a previous 'if'
>
> Fixes: 84733fd0d75e ("eal/arm: fix memory barrier definition")
> Cc: stable@dpdk.org
> Signed-off-by: Jia He <jia.he@hxt-semitech.com>
Please fix the below checkpatch errors.
Wrong tag:
Suggested-by: Ananyev, Konstantin <konstantin.ananyev@intel.com>
Wrong 'Fixes' reference:
Fixes: 84733fd0d75e ("eal/arm: fix memory barrier definition")
With above fix:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-stable] [PATCH V7 1/3] eal/arm64: remove the braces {} for dmb() and dsb()
[not found] ` <1512352212-7191-1-git-send-email-hejianet@gmail.com>
@ 2017-12-04 1:50 ` Jia He
0 siblings, 0 replies; 3+ messages in thread
From: Jia He @ 2017-12-04 1:50 UTC (permalink / raw)
To: dev, Jerin Jacob, Jianbo Liu, Jan Viktorin, Olivier Matz,
Thomas Monjalon
Cc: konstantin.ananyev, hemant.agrawal, Jia He, stable, Jia He
for the code as follows:
if (condition)
rte_smp_rmb();
else
rte_smp_wmb();
Without this patch, compiler will report this error:
error: 'else' without a previous 'if'
Fixes: 84733fd0d75e ("eal/arm64: fix memory barrier definition")
Cc: stable@dpdk.org
Signed-off-by: Jia He <jia.he@hxt-semitech.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
index 0b70d62..71da29c 100644
--- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
+++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
@@ -43,8 +43,8 @@ extern "C" {
#include "generic/rte_atomic.h"
-#define dsb(opt) { asm volatile("dsb " #opt : : : "memory"); }
-#define dmb(opt) { asm volatile("dmb " #opt : : : "memory"); }
+#define dsb(opt) asm volatile("dsb " #opt : : : "memory")
+#define dmb(opt) asm volatile("dmb " #opt : : : "memory")
#define rte_mb() dsb(sy)
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-04 1:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1510291392-33251-1-git-send-email-hejianet@gmail.com>
[not found] ` <1511748024-7245-1-git-send-email-hejianet@gmail.com>
2017-11-27 2:00 ` [dpdk-stable] [PATCH V6 1/3] eal/arm64: remove the braces {} for dmb() and dsb() Jia He
2017-12-03 11:11 ` Jerin Jacob
[not found] ` <1512352212-7191-1-git-send-email-hejianet@gmail.com>
2017-12-04 1:50 ` [dpdk-stable] [PATCH V7 " Jia He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).