From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <tiwei.bie@intel.com> Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id F05E3325B; Tue, 5 Dec 2017 04:12:16 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2017 19:12:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,362,1508828400"; d="scan'208";a="181382530" Received: from deepin-15.sh.intel.com (HELO debian-xvivbkq) ([10.67.104.165]) by orsmga005.jf.intel.com with ESMTP; 04 Dec 2017 19:12:13 -0800 Date: Tue, 5 Dec 2017 11:11:44 +0800 From: Tiwei Bie <tiwei.bie@intel.com> To: "Fischetti, Antonio" <antonio.fischetti@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "yliu@fridaylinux.org" <yliu@fridaylinux.org>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "jfreimann@redhat.com" <jfreimann@redhat.com>, "stable@dpdk.org" <stable@dpdk.org> Message-ID: <20171205031144.f7tv4nctuwxb6uxy@debian-xvivbkq> References: <20170829082601.30349-1-tiwei.bie@intel.com> <1508465368-36746-1-git-send-email-tiwei.bie@intel.com> <BCFD2BB875535045A5368D9ADBF2969935059706@IRSMSX101.ger.corp.intel.com> <BCFD2BB875535045A5368D9ADBF296993506013E@IRSMSX101.ger.corp.intel.com> <20171202043033.gwg3lx2hlmdway3x@debian-xvivbkq> <20171204071935.semcmhb2agdkbggp@debian-xvivbkq> <BCFD2BB875535045A5368D9ADBF29699350608E8@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <BCFD2BB875535045A5368D9ADBF29699350608E8@IRSMSX101.ger.corp.intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/virtio: fix an incorrect behavior of device stop/start X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 05 Dec 2017 03:12:17 -0000 On Mon, Dec 04, 2017 at 07:46:07PM +0800, Fischetti, Antonio wrote: > > -----Original Message----- > > From: Bie, Tiwei > > Sent: Monday, December 4, 2017 7:20 AM > > To: Fischetti, Antonio <antonio.fischetti@intel.com> > > Cc: dev@dpdk.org; yliu@fridaylinux.org; maxime.coquelin@redhat.com; > > jfreimann@redhat.com; stable@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: fix an incorrect behavior > > of device stop/start > > > > On Sat, Dec 02, 2017 at 12:30:33PM +0800, Tiwei Bie wrote: > > > Hi Antonio, > > > > > > On Sat, Dec 02, 2017 at 01:17:58AM +0800, Fischetti, Antonio wrote: > > > > Hi All, > > > > I've got an update on this. > > > > I could replicate the same issue by using testpmd + a VM (= Virtual > > Machine). > > > > > > > > The test topology I'm using is: > > > > > > > > > > > > [Traffic gen]----[NIC port #0]----[testpmd]----[vhost port #2]----+ > > > > | > > > > | > > > > > > [testpmd in > > > > the > > VM] > > > > | > > > > | > > > > [Traffic gen]----[NIC port #1]----[testpmd]----[vhost port #3]----+ > > > > > > > > > > > > So there's no OvS now in the picture: one testpmd running on the > > host > > > > and one testpmd running on the VM. > > > > > > > > The issue is that no packet goes through testpmd in the VM. > > > > It seems this is happening after this patch was upstreamed. > > > > > > > > Please note > > > > ----------- > > > > To replicate this issue both the next 2 conditions must be met: > > > > - the traffic is already being sent before launching testpmd in the > > VM > > > > - there are at least 2 forwarding lcores. > > > > > > > > > [...] > > > > > > Do you see anything I missed? Or can you reproduce the issue with the > > > setup I'm using? > > > > > > > Hi Antonio, > > > > Are you using vector Rx in your test? After some further > > [Antonio] Hi Tiwei, yes I suppose so. > > Below some more details on my testbench to explain why I'm > using this configuration. > > With this topology I can replicate as much as possible > my initial OvS-DPDK testbench. In the ovs case I > had 1 single process on the host (OvS) which spawns 2 > dequeuing threads running on 2 different lcores (please > note: if they run on the same lcore there's no issue). > > So in place of Ovs I'm using 1 testpmd only on the host like: > > sudo ./x86_64-native-linuxapp-gcc/app/testpmd -l 0-3 -n 4 \ > --socket-mem=1024,1024 \ > --vdev 'eth_vhost0,iface=/tmp/sock0,queues=1' \ > --vdev 'eth_vhost1,iface=/tmp/sock1,queues=1' -- -i > > so the testpmd on the host is seeing 4 phy ports, 2 are real > phy ports and 2 are vdev. > > Then I set the forwarding cores > > testpmd> set corelist 2,3 > > and the port order > testpmd> set portlist 0,2,1,3 > testpmd> set fwd mac retry > testpmd> start > > I then launch the VM and inside of it I launch testpmd: > > ./testpmd -c 0x3 -n 4 --socket-mem 512 -- --burst=64 -i \ > --txqflags=0xf00 --disable-hw-vlan > > on testpmd console: > testpmd> set fwd mac retry > testpmd> start > > As the traffic is already running at the line-rate for > some seconds, for sure all the descs have been consumed. > > I'm currently using 1 GB hugepage sizes, but I was > seeing the same issue with OvS when I was using 2 MB > hugepage sizes. > Hi Antonio, Got it! Thank you for the detailed info! I will send out a patch to fix this issue ASAP. Best regards, Tiwei Bie