Re: [dpdk-stable] [PATCH 1/2] net/bnxt: fix headroom initialization

[Olivier MATZ <olivier.matz@6wind.com>]

Hi Ferruh,

On Fri, Dec 15, 2017 at 06:30:58PM -0800, Ferruh Yigit wrote:
> On 12/14/2017 6:28 AM, Olivier Matz wrote:
> > When allocating a new mbuf for Rx, the value of m->data_off should not
> > be reset to its default value (RTE_PKTMBUF_HEADROOM), instead of reusing
> > the previous undefined value, which could cause the packet to have a too
> > small or too high headroom.
> > 
> > Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---
> >  drivers/net/bnxt/bnxt_rxr.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> > index 188df362e..3fff4d437 100644
> > --- a/drivers/net/bnxt/bnxt_rxr.c
> > +++ b/drivers/net/bnxt/bnxt_rxr.c
> > @@ -75,7 +75,7 @@ static inline int bnxt_alloc_rx_data(struct bnxt_rx_queue *rxq,
> >  
> >  	rx_buf->mbuf = data;
> >  
> > -	rxbd->addr = rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR(rx_buf->mbuf));
> > +	rxbd->addr = rte_cpu_to_le_64(rte_mbuf_data_dma_addr_default(data));
> 
> Hi Olivier,
> 
> Using deprecated rte_mbuf_data_dma_addr_default() breaks build for this commit.
> 
> What do you think using directly rte_mbuf_data_iova_default() in this patch?

No problem. It was initially split in 2 patches to ease the backport for
stable versions.