* [dpdk-stable] [PATCH] net/virtio: fix wrong use_msix value for legacy device
@ 2017-12-27 10:09 Zhiyong Yang
2017-12-28 6:21 ` Yang, Zhiyong
0 siblings, 1 reply; 2+ messages in thread
From: Zhiyong Yang @ 2017-12-27 10:09 UTC (permalink / raw)
To: dev; +Cc: yliu, maxime.coquelin, stable, Zhiyong Yang
If virtio fails to detect modern device, use_misx should be reset
to VIRTIO_MSIX_NONE, otherwise this wrong value will be used after
legacy device detection succeeds to be done.
Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO")
Cc: stable@dpdk.org
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
drivers/net/virtio/virtio_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c
index 9574498fb..5582238fd 100644
--- a/drivers/net/virtio/virtio_pci.c
+++ b/drivers/net/virtio/virtio_pci.c
@@ -695,6 +695,7 @@ vtpci_init(struct rte_pci_device *dev, struct virtio_hw *hw)
return 0;
}
+ hw->use_msix = VIRTIO_MSIX_NONE;
PMD_INIT_LOG(INFO, "trying with legacy virtio pci.");
if (rte_pci_ioport_map(dev, 0, VTPCI_IO(hw)) < 0) {
if (dev->kdrv == RTE_KDRV_UNKNOWN &&
--
2.13.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH] net/virtio: fix wrong use_msix value for legacy device
2017-12-27 10:09 [dpdk-stable] [PATCH] net/virtio: fix wrong use_msix value for legacy device Zhiyong Yang
@ 2017-12-28 6:21 ` Yang, Zhiyong
0 siblings, 0 replies; 2+ messages in thread
From: Yang, Zhiyong @ 2017-12-28 6:21 UTC (permalink / raw)
To: dev; +Cc: yliu, maxime.coquelin, stable
Self Nack.
Another patch has been sent out to fix testpmd startup failure issue using uio_pci_generic on virtio legacy device.
http://www.dpdk.org/dev/patchwork/patch/32779/
> -----Original Message-----
> From: Yang, Zhiyong
> Sent: Wednesday, December 27, 2017 6:09 PM
> To: dev@dpdk.org
> Cc: yliu@fridaylinux.org; maxime.coquelin@redhat.com; stable@dpdk.org; Yang,
> Zhiyong <zhiyong.yang@intel.com>
> Subject: [PATCH] net/virtio: fix wrong use_msix value for legacy device
>
> If virtio fails to detect modern device, use_misx should be reset to
> VIRTIO_MSIX_NONE, otherwise this wrong value will be used after legacy device
> detection succeeds to be done.
>
> Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO")
> Cc: stable@dpdk.org
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
> drivers/net/virtio/virtio_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c index
> 9574498fb..5582238fd 100644
> --- a/drivers/net/virtio/virtio_pci.c
> +++ b/drivers/net/virtio/virtio_pci.c
> @@ -695,6 +695,7 @@ vtpci_init(struct rte_pci_device *dev, struct virtio_hw
> *hw)
> return 0;
> }
>
> + hw->use_msix = VIRTIO_MSIX_NONE;
> PMD_INIT_LOG(INFO, "trying with legacy virtio pci.");
> if (rte_pci_ioport_map(dev, 0, VTPCI_IO(hw)) < 0) {
> if (dev->kdrv == RTE_KDRV_UNKNOWN &&
> --
> 2.13.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-28 6:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-27 10:09 [dpdk-stable] [PATCH] net/virtio: fix wrong use_msix value for legacy device Zhiyong Yang
2017-12-28 6:21 ` Yang, Zhiyong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).