patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
	Ivan Malov <Ivan.Malov@oktetlabs.ru>,
	Igor Ryzhov <iryzhov@nfware.com>,
	dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
	Laurent Hardy <laurent.hardy@6wind.com>,
	stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] ethdev: fix setting of MAC address
Date: Mon, 8 Jan 2018 15:23:35 +0100	[thread overview]
Message-ID: <20180108142334.2s4h66sce57f3ss3@platinum> (raw)
In-Reply-To: <d59a7ced-dafe-3105-da72-68e79c1f0150@intel.com>

On Mon, Jan 08, 2018 at 11:59:09AM +0000, Ferruh Yigit wrote:
> On 1/3/2018 2:12 PM, Andrew Rybchenko wrote:
> > On 01/03/2018 04:54 PM, Olivier Matz wrote:
> >> On Wed, Jan 03, 2018 at 02:43:59PM +0100, Olivier Matz wrote:
> >>> I've walked through the PMDs as suggested by Andrew, and there was
> >>> indeed some conflicts with the initial patch. I've just submitted the
> >>> patch for vmxnet3 [1] and bnxt [2].
> >>>
> >>> But there is still an issue with the qede driver, that overwrites the
> >>> MAC address in dev->data by the previous one if it cannot be set. It
> >>> seems it's the only driver that does this in error case, but anyway,
> >>> this behavior will be broken by the initial patch.
> >>>
> >>> So I submitted a v2 that only changes the behavior for i40evf [3].
> >>>
> >>> I propose to include these 3 patches for 18.02, and announce an ABI
> >>> change for 18.05 to add a return value to dev_ops->mac_addr_set() and
> >>> move the ether_addr_copy() after the callback, only in case of success.
> >>>
> >>> Any opinions?
> > 
> > I'm not sure if dev_ops->mac_addr_set() is a part of ABI.
> > It is an internal interface between rte_ethdev library and drivers. Yes, out-of-tree
> > drivers will be broken.
> > rte_eth_dev_default_mac_addr_set() is definitely a part of API/ABI, but it already
> > has return value.
> > So, I'm not sure that we have to wait for 18.05, but it is still may be too late for
> > 18.02 since integration deadline is pretty close.
> 
> I think there is no API/ABI breakage, but it can be good to announce the change
> and give time for modifications.
> 
> +1 for proposal.

Thanks Andrew and Ferruh for the feedback.
I'll send an RFC for this soon.

  reply	other threads:[~2018-01-08 14:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 17:15 [dpdk-stable] " Olivier Matz
2017-12-18 10:35 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2017-12-18 10:53   ` Igor Ryzhov
2017-12-18 11:38     ` Andrew Rybchenko
2017-12-19  9:29       ` Olivier MATZ
2017-12-19  9:47         ` Andrew Rybchenko
2017-12-20 10:00           ` Andrew Rybchenko
2018-01-03 13:43             ` Olivier Matz
2018-01-03 13:54               ` Olivier Matz
2018-01-03 14:12                 ` Andrew Rybchenko
2018-01-08 11:59                   ` Ferruh Yigit
2018-01-08 14:23                     ` Olivier Matz [this message]
2018-01-03 13:34 ` [dpdk-stable] [PATCH v2] net/i40e: fix setting of MAC address on i40evf Olivier Matz
2018-01-04  7:39   ` Xing, Beilei
2018-01-08  6:43     ` [dpdk-stable] [dpdk-dev] " Zhang, Helin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108142334.2s4h66sce57f3ss3@platinum \
    --to=olivier.matz@6wind.com \
    --cc=Ivan.Malov@oktetlabs.ru \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=iryzhov@nfware.com \
    --cc=laurent.hardy@6wind.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).