From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Matan Azrad <matan@mellanox.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
dev@dpdk.org, stephen@networkplumber.org,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v3 1/8] net/failsafe: fix invalid free
Date: Tue, 16 Jan 2018 11:24:17 +0100 [thread overview]
Message-ID: <20180116102417.zwno5vpz7lpyqbmw@bidouze.vm.6wind.com> (raw)
In-Reply-To: <1515509253-17834-2-git-send-email-matan@mellanox.com>
Hi Matan,
On Tue, Jan 09, 2018 at 02:47:26PM +0000, Matan Azrad wrote:
> From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>
> rte_free() is not supposed to work with pointers returned by calloc().
>
> Fixes: a0194d828100 ("net/failsafe: add flexible device definition")
> Cc: stable@dpdk.org
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> drivers/net/failsafe/failsafe_args.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c
> index cfc83e3..ec63ac9 100644
> --- a/drivers/net/failsafe/failsafe_args.c
> +++ b/drivers/net/failsafe/failsafe_args.c
> @@ -407,7 +407,7 @@ typedef int (parse_cb)(struct rte_eth_dev *dev, const char *params,
> uint8_t i;
>
> FOREACH_SUBDEV(sdev, i, dev) {
> - rte_free(sdev->cmdline);
> + free(sdev->cmdline);
> sdev->cmdline = NULL;
> free(sdev->devargs.args);
> sdev->devargs.args = NULL;
> --
> 1.8.3.1
>
--
Gaëtan Rivet
6WIND
next prev parent reply other threads:[~2018-01-16 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171218162443.12971-1-adrien.mazarguil@6wind.com>
[not found] ` <20171222173846.20731-1-adrien.mazarguil@6wind.com>
2017-12-22 18:01 ` [dpdk-stable] [PATCH v2 1/5] " Adrien Mazarguil
[not found] ` <1515509253-17834-1-git-send-email-matan@mellanox.com>
2018-01-09 14:47 ` [dpdk-stable] [PATCH v3 1/8] " Matan Azrad
2018-01-16 10:24 ` Gaëtan Rivet [this message]
[not found] ` <1516265026-6469-1-git-send-email-matan@mellanox.com>
2018-01-18 8:43 ` [dpdk-stable] [PATCH v4 " Matan Azrad
[not found] ` <1516269709-15252-1-git-send-email-matan@mellanox.com>
2018-01-18 10:01 ` [dpdk-stable] [PATCH v5 " Matan Azrad
[not found] ` <1516283506-21198-1-git-send-email-matan@mellanox.com>
2018-01-18 13:51 ` [dpdk-stable] [PATCH v6 " Matan Azrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116102417.zwno5vpz7lpyqbmw@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).