patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Matan Azrad <matan@mellanox.com>,
	stable@dpdk.org, Ophir Munk <ophirmu@mellanox.com>,
	dev@dpdk.org, Olga Shern <olgas@mellanox.com>,
	Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic
Date: Wed, 24 Jan 2018 10:27:31 -0800	[thread overview]
Message-ID: <20180124102731.219f90cc@xeon-e3> (raw)
In-Reply-To: <2260225.RPhyHJgTVH@xps>

On Wed, 24 Jan 2018 19:08:02 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 24/01/2018 16:39, Stephen Hemminger:
> > On Wed, 24 Jan 2018 14:12:13 +0000
> > Ophir Munk <ophirmu@mellanox.com> wrote:  
> > > --- a/drivers/net/vdev_netvsc/Makefile
> > > +++ b/drivers/net/vdev_netvsc/Makefile
> > > @@ -12,7 +12,7 @@ EXPORT_MAP := rte_pmd_vdev_netvsc_version.map
> > >  # Additional compilation flags.
> > >  CFLAGS += -O3
> > >  CFLAGS += -g
> > > -CFLAGS += -std=c11 -pedantic -Wall -Wextra
> > > +CFLAGS += -Wall -Wextra
> > >  CFLAGS += -D_XOPEN_SOURCE=600
> > >  CFLAGS += -D_BSD_SOURCE
> > >  CFLAGS += -D_DEFAULT_SOURCE  
> > 
> > Why did this driver not use $(WERROR) like rest of DPDK drivers.  
> 
> It can be a separate patch.
> Matan?

I meant that you should use:

CFLAGS += $(WERROR_FLAGS)

instead of

CFLAGS += -Wall -Wextra

in this patch.

Also, do you really  need all the other CFLAGS? Why?

This driver has no reason to be a special case different from what is done
in virtio, vmxnet3, ixgbe, e1000, ...

  reply	other threads:[~2018-01-24 18:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1516792792-10119-1-git-send-email-ophirmu@mellanox.com>
2018-01-24 14:12 ` [dpdk-stable] " Ophir Munk
2018-01-24 14:45   ` Matan Azrad
2018-01-24 18:06     ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-01-24 15:39   ` Stephen Hemminger
2018-01-24 18:08     ` Thomas Monjalon
2018-01-24 18:27       ` Stephen Hemminger [this message]
2018-01-25  8:24         ` Matan Azrad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180124102731.219f90cc@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=olgas@mellanox.com \
    --cc=ophirmu@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).