From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 793921B2C7 for ; Fri, 26 Jan 2018 14:14:17 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id r78so21184028wme.0 for ; Fri, 26 Jan 2018 05:14:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UUOnY1JveKqqJ5lAc8/bFxROSA99COKCHlLkXsqvtIY=; b=BSk0wpV/qpSWt9ZGlhX6AMHZmThtiqXl6V1LjyxggFIr+T3svpicivnfmx+XgedfUz ai3JljphlfBx+SgGtWvMuf0dIOjr/TLZ1oX0aiKqDoaVM0bHNt38PmT6EqTNLi8v62jB BzOCN56NyfJm6ns3VPYYBXqxMHgOd/ngXs4TN/3Y3Rz7BJtIUFpO9j7yCAt1I0RudBJ9 RDsqNOUzLMfTfKuKk8G6Q1jX6SwISOQ8mR8SLaTeZRIohxW3dvQe/wqF4/JfbuZImhB1 BLoo8GdvdbewlLLwYVagzeKh4+4+hiLEqTUFbASwFriHR88O03S0SP65JAC35D4QDiHN okdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UUOnY1JveKqqJ5lAc8/bFxROSA99COKCHlLkXsqvtIY=; b=BRQv+xXLObrLnqAR52hY+Sd5IxKRWfl5kNPYbwWK6GKCE5j4hzh7CqQQbZUDPdrHyq qEd7T1BSJ66L/gV5bE2vnp1Fr+NN3QH6RYyJKkCcnUCNGLxndjMuuIen1g4yiA1+Mlav uOekt8LeENXAl2K8fFVtPuINL36584KZnKp4r/92+ZKJqM8e+4/KO62bL6YTg+dDMNJ4 OWN4oHSKnlrgfhT9xb2kz5yRo6Owr6a/sX5BnwZU6DQ4mOH++/D5fEOfEZg7wJoXJNVe IQg5IjTPLyZs4BdM3ODMuv3RMBmJqUOBlTc0fs6QSVF2t08ljiAQ/JezXT9Z7/1w5BUE c+BA== X-Gm-Message-State: AKwxytcr7X60H3+i7K8Pj6pHtt6j/J62zvcP06+fIcS3lmNMk50ERcDr ZjjeSf/W2w8s61pgAT5ff2oVcxmj X-Google-Smtp-Source: AH8x224IQ+oV+ecAz0Gk6sKrh45CBQA8KPeWuDgghwoXELDa3NGbQKBVfL1mFFZjhUNsEZdlGPw6uw== X-Received: by 10.28.167.215 with SMTP id q206mr10559110wme.48.1516972457230; Fri, 26 Jan 2018 05:14:17 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id 44sm10541447wrt.46.2018.01.26.05.14.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 05:14:16 -0800 (PST) From: luca.boccassi@gmail.com To: Anatoly Burakov Cc: dpdk stable Date: Fri, 26 Jan 2018 13:12:41 +0000 Message-Id: <20180126131332.15346-11-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180126131332.15346-1-luca.boccassi@gmail.com> References: <20180126131332.15346-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'vfio: fix enabled check on error' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 13:14:17 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/28/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From a552f812df96cc4d6734920b85e9d3d57f65c348 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Fri, 22 Dec 2017 10:30:36 +0000 Subject: [PATCH] vfio: fix enabled check on error [ upstream commit 7b74a6e0b638ce69b9d03367ce85258e0da19807 ] rte_eal_check_module() might return -1, which would have been a "not false" condition for mod_available. Fix that to only report vfio being enabled if rte_eal_check_module() returns 1. Fixes: 221f7c220d6b ("vfio: move global config out of PCI files") Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linuxapp/eal/eal_vfio.c index 702f7a2e0..7ea20f3e2 100644 --- a/lib/librte_eal/linuxapp/eal/eal_vfio.c +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c @@ -339,7 +339,7 @@ vfio_enable(const char *modname) int vfio_is_enabled(const char *modname) { - const int mod_available = rte_eal_check_module(modname); + const int mod_available = rte_eal_check_module(modname) > 0; return vfio_cfg.vfio_enabled && mod_available; } -- 2.14.2