From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id E8AC61B1C9 for ; Fri, 26 Jan 2018 14:14:35 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id t74so1198344wme.3 for ; Fri, 26 Jan 2018 05:14:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ToW8FMbnG14jOwf/XzeU8L/INUskVOCcu718+gYT4Tw=; b=PRm34M9nKNCieqg611wCBwcMPlZgXojBS4qlcgGMRsqDrvrGKV/UMvOXCoVesnDnyD 38uQGiuYkdO2VfffCN5aAMUuef9oczrI9uRz3TbRSAi0IUqK4Dc46V+vevUqW00YZc3u gT2mivhDPITE3GdWswVaUNfCIsjW+FSbTO/NO6rlRZr5R/irhPmfB18sjXFN+1JqaCiT qsHabosdqHZenCwLn57VFQceV3dVCMFqgLXsK6DX/+8UpROvN6fqrQqsYGinYEBVGAxB yNTvPF2C3E/MSRH98KYBhSFb0L9M1KiiQQynNgZLJTbH57uj98mI9UpJOPWci/lqDwJ0 rtKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ToW8FMbnG14jOwf/XzeU8L/INUskVOCcu718+gYT4Tw=; b=bLVxc3JyKqYoibQuXW5ZzEH2Y+29xRywgLjFL6Nd538jE0pxbwiOH8bfGHOdk/FZqr CO2Zk9cti4K+aIy/7xm06KJOd/mt6YUsBPquls7pO8cMQKeDFxQAWEURTe3iQEhlDr1S 5MxQV9sO3Kb+Itd2Bda9xe16rte5jX8aRYayxz8slVDAY/ElotNTJi3fzqaLhMnXB1wt qtH/7/VXaY7zhuBo5Jfo9TCmHwWCVNQV1Ix0JoBcZt9HROOkzbPJrMyk3ZBVxuYAwDxL l+fHKfRh/lBxnLX+hWe2yWF2iUsAoMXBHxiBJKBaiI38DHLGG5RpWWXtxwsnDdqtNtXh Qwmw== X-Gm-Message-State: AKwxytcQL6El/6Jo9y+OO0jY2W4IGG0zaqqdU4L+0CiRvEU2QrcNmMVa VDHo95vyaVmpMDSLthGGbarXQnG6kCM= X-Google-Smtp-Source: AH8x227KgujdBFL2uovBcCYnmYaXLX9bInbSrTeGuOJ5NpuV1QclvhvxCUOkSVaaymURsSEZi62XVw== X-Received: by 10.28.20.8 with SMTP id 8mr10290179wmu.106.1516972475677; Fri, 26 Jan 2018 05:14:35 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id d125sm1812376wmc.47.2018.01.26.05.14.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 05:14:35 -0800 (PST) From: luca.boccassi@gmail.com To: Alejandro Lucero Cc: dpdk stable Date: Fri, 26 Jan 2018 13:12:49 +0000 Message-Id: <20180126131332.15346-19-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180126131332.15346-1-luca.boccassi@gmail.com> References: <20180126131332.15346-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/nfp: fix jumbo settings' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 13:14:36 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/28/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From c8ac12fbb38b528437938b9522d8239032917deb Mon Sep 17 00:00:00 2001 From: Alejandro Lucero Date: Fri, 24 Nov 2017 14:24:37 +0000 Subject: [PATCH] net/nfp: fix jumbo settings [ upstream commit c70ccbc79d8a0b7327f98f6072da75a530c4102a ] When jumbo frames is configured, the hardware mtu needs to be updated to the specified max_rx_pkt_len. Also, changing mtu should be avoided once the PMD port started. Fixes: defb9a5dd156 ("nfp: introduce driver initialization") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 052b07348..4c25e3e3c 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -517,7 +517,7 @@ nfp_net_configure(struct rte_eth_dev *dev) new_ctrl |= NFP_NET_CFG_CTRL_TXVLAN; if (rxmode->jumbo_frame) - /* this is handled in rte_eth_dev_configure */ + hw->mtu = rxmode->max_rx_pkt_len; if (rxmode->hw_strip_crc) { PMD_INIT_LOG(INFO, "strip CRC not supported\n"); @@ -1240,6 +1240,13 @@ nfp_net_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) if ((mtu < ETHER_MIN_MTU) || ((uint32_t)mtu > hw->max_mtu)) return -EINVAL; + /* mtu setting is forbidden if port is started */ + if (dev->data->dev_started) { + PMD_DRV_LOG(ERR, "port %d must be stopped before configuration", + dev->data->port_id); + return -EBUSY; + } + /* switch to jumbo mode if needed */ if ((uint32_t)mtu > ETHER_MAX_LEN) dev->data->dev_conf.rxmode.jumbo_frame = 1; -- 2.14.2