From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 7C1041B1C9 for ; Fri, 26 Jan 2018 14:14:40 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id 141so21025770wme.3 for ; Fri, 26 Jan 2018 05:14:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8lfA1Gx0tgozIV/JUUBU86iD61qu9FkAra3BjSUhG8E=; b=U3n4eMWXAm/A59hr/VSi1Df3gh/tgnkJQoN2mgleHTeJpsfSnnMY2TRo4XcByxcbWd X2KNd0o+9d5e21/1Ctx7AbrKbf4VUKtwfKHRsvH8G9yUETTUKF4jXRgUji4LgUKvZEJX xdLfxRLHo9b89FMMs3cBE0sX32lK2u8faQ6QCKSyPuuqczPmtvgJWb8si4G+1gWRnOD+ HEoQ1ZvHPeKPzMjoYULzZgl344FmVFwwcMJsrUpiDPI+Q4bIKVHbnbXJBYxLv3IwGUAR x/Nxi9+uns6dUK2SZnjGEVa5WoXNkVO+2cIUovni4CbHz2KxYsE+j9/tpR7Mh5BaZD7B P8Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8lfA1Gx0tgozIV/JUUBU86iD61qu9FkAra3BjSUhG8E=; b=q34hyt1GSY9UH8lGUDqxc5oIMJNm44IfL8ULTkeJU9eQdnO64FaXFVHY24VhvzSy8W ytRwtiWXSfv5BQtYeLZihF1SKmPU7n9X16pZ1NK4UC3p4I8tIEmlH/as4rcGkCiD8VEP uxqQYoTv120EJq8N0fprh//oby5Rr6kFwgIkhJCyUyIoJi+3ElkDgs6HjigQII6pConV o1M3wj8N5TfkhmFNZkWPb4rie1O5rlHx4RbbJs4mzBb/7R2GTSCEkCQGIoONorP+iBK2 eArYEz0ToWHZ9aCSYYJIbrAZigdcH5qBlA1iX66JPQXBqvcSPXbjdlB/wYpUPP+mn6Gt 25aQ== X-Gm-Message-State: AKwxyteMpAlHXlsxYBdiIK1fI1bJpZTTo5RV0DIMTs44sLTYkOr1cr9e 3DT73n7Qr33q3itq4rFStTo= X-Google-Smtp-Source: AH8x2255fiarNdMSJ75dmKg3IblQJdrKaEf1P4JczH0HppvgsDVr6is2LG3Ge8eMAXYuGmsenI8ioQ== X-Received: by 10.28.14.10 with SMTP id 10mr11915043wmo.2.1516972480242; Fri, 26 Jan 2018 05:14:40 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id c54sm9616356wrg.68.2018.01.26.05.14.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 05:14:39 -0800 (PST) From: luca.boccassi@gmail.com To: Alejandro Lucero Cc: dpdk stable Date: Fri, 26 Jan 2018 13:12:50 +0000 Message-Id: <20180126131332.15346-20-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180126131332.15346-1-luca.boccassi@gmail.com> References: <20180126131332.15346-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/nfp: fix CRC strip check behaviour' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 13:14:40 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/28/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From f286ca3b2b4b4a244b1ff5b423fb5c4f79bb5d8f Mon Sep 17 00:00:00 2001 From: Alejandro Lucero Date: Fri, 24 Nov 2017 14:26:02 +0000 Subject: [PATCH] net/nfp: fix CRC strip check behaviour [ upstream commit d4abcc55c5c6922ab24bb62358b6ba54fb14df87 ] NFP does CRC strip by default and it is not configurable. But, even if an app requests not to do it, that should not be a reason for PMD configuration failure. Fixes: defb9a5dd156 ("nfp: introduce driver initialization") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 4c25e3e3c..1f42dac83 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -519,10 +519,8 @@ nfp_net_configure(struct rte_eth_dev *dev) if (rxmode->jumbo_frame) hw->mtu = rxmode->max_rx_pkt_len; - if (rxmode->hw_strip_crc) { - PMD_INIT_LOG(INFO, "strip CRC not supported\n"); - return -EINVAL; - } + if (!rxmode->hw_strip_crc) + PMD_INIT_LOG(INFO, "HW does strip CRC and it is not configurable\n"); if (rxmode->enable_scatter) { PMD_INIT_LOG(INFO, "Scatter not supported\n"); -- 2.14.2