From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 3B71B1B306 for ; Fri, 26 Jan 2018 14:15:34 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id f71so1195555wmf.0 for ; Fri, 26 Jan 2018 05:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ROYG7v5w6ew6TcWsHgCXaD94Nik4FPRH05gEITMdSaQ=; b=FCHRO/sJgicroC3q0eMYvKwWFBFFPVB/b49Vn+nBVub19ql+2J1vyxiHpy4Uz7BVmj Zbe1j631wX6c89TdkGP5mSqlde6Fq3QmDojhS9AJF/AoCoRO/0WxM9V2TJm8bBStig+b HzVmRfy6L0xXquPYI2m9Q1AZBKgmYXu8VTOBRtq9syr8kKLKf3ZHElNQJYmqaoZnKDLr FH9dOQsYPbpxcSmUZqIw27MtDPmvnrU7dSjyt+au86/4nLTkDY2DIQa5QQQjtiXMNPEf /YKRCdVwVE139g6GqdtELWKjQ79OdmHAE/+9mC9hTpgEmoY3QWPywcMdJcSu7YbzYKaD /i2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ROYG7v5w6ew6TcWsHgCXaD94Nik4FPRH05gEITMdSaQ=; b=OhmOg0lhTgpiNV76rfZUgZqWYRXFNUhMegNuBKVRlGNjWvix4C91YORRDlQ52Ks55s SyehaGCGS8BkLmdYK9FNfa5sfrsAeFayVfsbTCJmeUmE8d+N6zMn1vVhf5Kjmv49DChU w6VB3E+cs89PBo7Ilth7ejMgTy1LIqB2SppAv9F1J8hqxWWWzuHivpeU7nnmEzY5FzrF cNKbVYW2TbAUE6pkyHLP6Vb1T/MhQSIYI9JKWbmu14NfuMdqD7r4b3kTOFTnoHmdLThx ARRLOseRpNuBx4uajQCjr9OaGgnnOc4BgElpuvyO2MgvJr0gHzjrvK+sNjWHanp9g9Av vSdw== X-Gm-Message-State: AKwxytfHBEkbZxJkSmB80GCuUpylgBy+qpTkAK1yaT5uf+FY7jm6149g M3ARgWTQsmxOVlpbyI51Rb4= X-Google-Smtp-Source: AH8x227xo4SnVaZyc422srY0KObIwN7BM/vbkMSRfsLcSaVzFWpQeenW9YeSJgaC7IFQEPgCFMOH5A== X-Received: by 10.28.26.144 with SMTP id a138mr11452340wma.61.1516972533962; Fri, 26 Jan 2018 05:15:33 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id s2sm3706240wmf.0.2018.01.26.05.15.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 05:15:33 -0800 (PST) From: luca.boccassi@gmail.com To: Harish Patil Cc: dpdk stable Date: Fri, 26 Jan 2018 13:12:54 +0000 Message-Id: <20180126131332.15346-24-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180126131332.15346-1-luca.boccassi@gmail.com> References: <20180126131332.15346-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/qede: fix to reject config with no Rx queue' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 13:15:34 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/28/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From d676db628b14dc789523595544405c41dbc23714 Mon Sep 17 00:00:00 2001 From: Harish Patil Date: Wed, 13 Dec 2017 22:36:02 -0800 Subject: [PATCH] net/qede: fix to reject config with no Rx queue [ upstream commit e60644c4420c47fa196c0c947a6c6e5891d167d0 ] The qede firmware expects minimum one RX queue to be created, otherwise it results in firmware exception. So a check is added to prevent that. Fixes: ec94dbc57362 ("qede: add base driver") Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 9d782ac78..8fdff14f3 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -674,6 +674,14 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev) } } + /* We need to have min 1 RX queue.There is no min check in + * rte_eth_dev_configure(), so we are checking it here. + */ + if (eth_dev->data->nb_rx_queues == 0) { + DP_ERR(edev, "Minimum one RX queue is required\n"); + return -EINVAL; + } + /* Sanity checks and throw warnings */ if (rxmode->enable_scatter == 1) eth_dev->data->scattered_rx = 1; -- 2.14.2