From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 665E91B211 for ; Fri, 26 Jan 2018 14:16:08 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id r71so1206704wmd.1 for ; Fri, 26 Jan 2018 05:16:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ODF8yPtgCRn7nxs4+mYO0j4A9C0OVRKs73hIm8pzmtc=; b=ALCu4ZxW7uEwp5CmxLkEx8o9waYFKS+6HWGINASlGY/KH/3PrHomSafDyKSw2WExmg sZ+qlNwUxQIyNpi06cs5XkBN2ohLOr30uyBPL81zOro0wQDCKbOJHmtL99Pb0alpWQOF 8gEKPJh0KAXIXWwoaZc7QZn89A/iTqlmXpu/yTq3cdH+mgo3Ih39Bwvu/ZRgZ6IxnJLW hP9iHuDgU3dqIwXf4quKby7YHpy/TuwowD6Ki0vOSwrUko9c4FgsEqGKWpcSHEt1BVJ+ Xkd/xHlsMDad5NL6LwTkcA7rcAExq2FI1/kEW9ofn+LYXcFxmwQ4vWZ9fNmx7plS9TgP 14Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ODF8yPtgCRn7nxs4+mYO0j4A9C0OVRKs73hIm8pzmtc=; b=LcrHdwK3fRYy+voLHcva+kz5LMHNoIFq6XNinZudsiW8O3gPe42qrj2R++YsYJNRTG esRCtsNwaA9393+vnkRHMZz2Vj9MUPDaGh+Ubj4c6R9Gjt4BZgL5r68BXxGYWvC2Vyvk /u2lAckPoNcpoucqnXMQDYBsiTkxbQa+eWMdXeEJHfu4via96hzXMq/HqyEtdHPOKYVy F7pCpUEgQZ2J2NWETJ7LdrHZkJMfUIkKsJXPsvIp15e2JKXrWYsO9LikMc7wTQPKu6Tw kOxAzOwDdpQ4/r14aG7NdoY7qKhNtfXwRXUp3kw4jG3cAhFoj3jVJgJjsX3NIdXDBur+ tx5w== X-Gm-Message-State: AKwxytcaUkXoDDVpDHg/cBe0ewOEyz+TdBWsPvnJaZpCWiAhO1ste+U6 ZTDM3W3cRWQIsU01MC9awP4= X-Google-Smtp-Source: AH8x225M0LD21uLE4yAWVv5a1CbCID9gxOsh4X4j4SL3srHCTBjwJo2Nr7WLatniHOTA3do+9/fNdg== X-Received: by 10.28.51.12 with SMTP id z12mr10100375wmz.16.1516972568144; Fri, 26 Jan 2018 05:16:08 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id s44sm9680679wrc.64.2018.01.26.05.16.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 05:16:07 -0800 (PST) From: luca.boccassi@gmail.com To: Qi Zhang Cc: Beilei Xing , dpdk stable Date: Fri, 26 Jan 2018 13:13:06 +0000 Message-Id: <20180126131332.15346-36-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180126131332.15346-1-luca.boccassi@gmail.com> References: <20180126131332.15346-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/i40e/base: fix link LED blink' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 13:16:08 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/28/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 6591eda92ca37722b265e31178dafad3073fb21e Mon Sep 17 00:00:00 2001 From: Qi Zhang Date: Tue, 9 Jan 2018 15:30:13 -0500 Subject: [PATCH] net/i40e/base: fix link LED blink [ upstream commit e35eed328516f90c51bd41b9ac6623a3e5951549 ] This fix solves an issue occurring while calling i40e_led_set function from the driver with "blink" parameter set as TRUE. This call resulted in Activity LED blinking instead of Link LED, which may lead to errors in physically identyfying the port, since Activity LED may be blinking for different reasons aswell. Fixes: 51b27bc5d898 ("i40e/base: update LED blinking") Signed-off-by: Qi Zhang Acked-by: Beilei Xing --- drivers/net/i40e/base/i40e_common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c index 76f262116..de60e2a12 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/drivers/net/i40e/base/i40e_common.c @@ -1579,6 +1579,7 @@ u32 i40e_led_get(struct i40e_hw *hw) case I40E_COMBINED_ACTIVITY: case I40E_FILTER_ACTIVITY: case I40E_MAC_ACTIVITY: + case I40E_LINK_ACTIVITY: continue; default: break; @@ -1627,6 +1628,7 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink) case I40E_COMBINED_ACTIVITY: case I40E_FILTER_ACTIVITY: case I40E_MAC_ACTIVITY: + case I40E_LINK_ACTIVITY: continue; default: break; @@ -1637,9 +1639,6 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink) gpio_val |= ((mode << I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT) & I40E_GLGEN_GPIO_CTL_LED_MODE_MASK); - if (mode == I40E_LINK_ACTIVITY) - blink = false; - if (blink) gpio_val |= BIT(I40E_GLGEN_GPIO_CTL_LED_BLINK_SHIFT); else -- 2.14.2