From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id EDB841B1C9 for ; Fri, 26 Jan 2018 14:14:01 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id 141so21022225wme.3 for ; Fri, 26 Jan 2018 05:14:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PwkjEF26J+C7ZqlwV2drmC3oX+t3fseFnygAKOTL5YY=; b=DhWo8M1jJ8i3nzc+2jXyHQ9+zQubEgT7FrcODXlrUK0UwGKLXRgi4aJoLTYQQfSvfZ 7/fIGojb0F0sqZjPiBx24eK5KMe70t9LA5r6sD1Qi6rJUHUdA1PXUx+xxNGOCrVxH6n8 rPF4aC2bu5IvODcwBaiB51LOfyxkisDNZTDn4O/uysayTX6pi7vmEJKOfhujq++YRdQy ho2WEiLe08tZyWCPKoxbSWFaeZW4pcL7PcinG+37QKtgJWwkKUrkX/j7RW7Pvmch1IKe 47NgJ6mQAhMplLD65fC3T/5oL8BvlRDQH7GGzNAkhJQWK4sb/aXWwUIUEDKdxOu0SS5u gC5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PwkjEF26J+C7ZqlwV2drmC3oX+t3fseFnygAKOTL5YY=; b=kFQfk1wpFV8JRkc35Xq8zP93y6sm9claltAS9gqVJSdikUdth5iI2EhtCeXtetckYa RrY7pTXaJXjksKMRNqT+zjv4AjzZSJpLV3OyKHklhElNBhJBbO1M/s5vpyvLX5niLj6T H6Ht5FUV0hc+WSS7S6OczIPZgl1zRzIRJcTT6PL4JbFLV20gyWNPjRwZTLZFOihI9XfX NtHx/dAQ5S9Q1WNm7S2jy7UMYCuOlo0WcYFPuifnTOJ82og83e9qxhbvJEAKc8+Rwemn yyhNIWEgU6ueLi33xuFtHfFLIaqz648R1B7xzy2fzHiA6RjWpeltId2MyjJcjJs5ugda 6Fqg== X-Gm-Message-State: AKwxytfOGmxgrK2hcYcwuhNi4/wbRdED8gBFJRictl2vZJekoHmP+zsu kkKR04oZiDhUKOtFKQXJbZs= X-Google-Smtp-Source: AH8x224DwVjLRHita/r9SDhc7n2MzjozgAMVEqBTF+Ee3noMKOiS69G0QteaViJoFl7PbUY/TGAuOA== X-Received: by 10.28.184.131 with SMTP id i125mr11634642wmf.44.1516972441680; Fri, 26 Jan 2018 05:14:01 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id g64sm4080266wmf.20.2018.01.26.05.14.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 05:14:01 -0800 (PST) From: luca.boccassi@gmail.com To: Michael McConville Cc: Ferruh Yigit , dpdk stable Date: Fri, 26 Jan 2018 13:12:34 +0000 Message-Id: <20180126131332.15346-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180126131332.15346-1-luca.boccassi@gmail.com> References: <20180126131332.15346-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'mem: fix mmap error check on huge page attach' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 13:14:02 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/28/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 6f8b9f0a1b53743ca27af98d4a4a78a244389175 Mon Sep 17 00:00:00 2001 From: Michael McConville Date: Thu, 30 Nov 2017 23:51:13 -0700 Subject: [PATCH] mem: fix mmap error check on huge page attach [ upstream commit b45056be0429d6df2313e5e49aa8f78e5d840a97 ] mmap(2) returns MAP_FAILED, not NULL, on failure. Signed-off-by: Michael McConville Reviewed-by: Ferruh Yigit --- lib/librte_eal/bsdapp/eal/eal_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_memory.c b/lib/librte_eal/bsdapp/eal/eal_memory.c index 3614da8db..248312d96 100644 --- a/lib/librte_eal/bsdapp/eal/eal_memory.c +++ b/lib/librte_eal/bsdapp/eal/eal_memory.c @@ -150,7 +150,7 @@ rte_eal_hugepage_attach(void) /* Map the shared hugepage_info into the process address spaces */ hpi = mmap(NULL, sizeof(struct hugepage_info), PROT_READ, MAP_PRIVATE, fd_hugepage_info, 0); - if (hpi == NULL) { + if (hpi == MAP_FAILED) { RTE_LOG(ERR, EAL, "Could not mmap %s\n", eal_hugepage_info_path()); goto error; } -- 2.14.2