From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id BEFCD1B173 for ; Fri, 26 Jan 2018 14:16:19 +0100 (CET) Received: by mail-wr0-f194.google.com with SMTP id 16so491846wry.12 for ; Fri, 26 Jan 2018 05:16:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sATSglfPMOWMqU3bFbR3iOEkutmS+RAxvYhSVfczTxg=; b=h4+n/3oA8PGKORdko8AZA/zmucwsMi2qYPAoS8bLXFoPn0PuVbkp1ozNfRKuLL5XDH sL6VqRWofsq7/5Cg4q3rgiUyBpYQ+e/jzSVLN+Q08YGrV9IU5Sl/IVUidC6uk0rE2p1g 35x1p8M06ohXdir+HQZlv0Ts/gihJ+6TEYVyMQ0gkULPcc5G51DQvjWu6n/vzVorCHzj +CsPI8DZOLeDTE8+hidaSeNV5drBgwTc0byVC0U+u5BvrmvfPtXNySBfiVlzpkLYzIUk heH/UmCuD68UUObpYiEqZhZNT7JLTivdykieM5zKOdWWlBL4bNxNNt6p3e6DxVwyJHEf BJNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sATSglfPMOWMqU3bFbR3iOEkutmS+RAxvYhSVfczTxg=; b=lV8MKbsrNBlX3nRKYfRToNt/qhjFTSCLAD5opGlTzxzGuJkVoG7XKfNp9DuN2XoQWz O4esxXmSbhcj9dWqgDUx5Z9EbKR7KgeBcCemQsLkKoF6opRjfYiQxTVFtyr0SJsgG4xM bwHdDGRvof1+pX+5I1G13BB8ufChgehHYWS7SqZFp2X/vOx8VaZ5hUG0tx78WPBGhbSv YAn8WDgyGwwg/nY8RGp/hwpaaPkxUWrDP+Z8/S6S2Q0CBtH9US6t/b1BNtew8PsEBwGn tL9Ll6D6iyEC/lsekHG6vdwBv7GHql3x0i40S6PE6Cur7CffCy+itRdi9D0cYbQZrZwf +LGw== X-Gm-Message-State: AKwxytd3WpC1uGmHm3qzKcLQ0ZP5kArZpXjizPemmdcw+NwDYEtN2u92 sJORNoj7rw0l7vegR1oLX40vY8Z3lc4= X-Google-Smtp-Source: AH8x225B9nk90R1XKc2swOaUMAvsXHP/Jb//nzspoLQBSW1IliflmJ78XL0CHv7jCmfyz0zVATjFzA== X-Received: by 10.223.173.194 with SMTP id w60mr1689711wrc.214.1516972579513; Fri, 26 Jan 2018 05:16:19 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id k17sm8318359wrf.17.2018.01.26.05.16.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 05:16:18 -0800 (PST) From: luca.boccassi@gmail.com To: Chas Williams Cc: Declan Doherty , dpdk stable Date: Fri, 26 Jan 2018 13:13:11 +0000 Message-Id: <20180126131332.15346-41-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180126131332.15346-1-luca.boccassi@gmail.com> References: <20180126131332.15346-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/bonding: fix setting slave MAC addresses' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 13:16:19 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/28/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 5b05cafd4878e62108978d1dbc46c9d6426d124e Mon Sep 17 00:00:00 2001 From: Chas Williams Date: Wed, 27 Dec 2017 21:12:31 -0500 Subject: [PATCH] net/bonding: fix setting slave MAC addresses [ upstream commit aa7791ba8de07c9e67ac4a42c7322409886cf6e5 ] Use rte_eth_dev_default_mac_addr_set() to change a slave MAC address. mac_address_set() only updates the software copy and does nothing to update the hardware. Signed-off-by: Chas Williams Acked-by: Declan Doherty --- drivers/net/bonding/rte_eth_bond_api.c | 2 +- drivers/net/bonding/rte_eth_bond_pmd.c | 10 ++++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c index 2a3893a15..29e2de5fd 100644 --- a/drivers/net/bonding/rte_eth_bond_api.c +++ b/drivers/net/bonding/rte_eth_bond_api.c @@ -565,7 +565,7 @@ __eth_bond_slave_remove_lock_free(uint8_t bonded_port_id, uint8_t slave_port_id) &rte_eth_devices[bonded_port_id].data->port_id); /* Restore original MAC address of slave device */ - mac_address_set(&rte_eth_devices[slave_port_id], + rte_eth_dev_default_mac_addr_set(slave_port_id, &(internals->slaves[slave_idx].persisted_mac_addr)); slave_eth_dev = &rte_eth_devices[slave_port_id]; diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 7811a5ac7..c1ec3aa43 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1217,7 +1217,8 @@ mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev) case BONDING_MODE_BALANCE: case BONDING_MODE_BROADCAST: for (i = 0; i < internals->slave_count; i++) { - if (mac_address_set(&rte_eth_devices[internals->slaves[i].port_id], + if (rte_eth_dev_default_mac_addr_set( + internals->slaves[i].port_id, bonded_eth_dev->data->mac_addrs)) { RTE_BOND_LOG(ERR, "Failed to update port Id %d MAC address", internals->slaves[i].port_id); @@ -1235,15 +1236,16 @@ mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev) for (i = 0; i < internals->slave_count; i++) { if (internals->slaves[i].port_id == internals->current_primary_port) { - if (mac_address_set(&rte_eth_devices[internals->primary_port], + if (rte_eth_dev_default_mac_addr_set( + internals->primary_port, bonded_eth_dev->data->mac_addrs)) { RTE_BOND_LOG(ERR, "Failed to update port Id %d MAC address", internals->current_primary_port); return -1; } } else { - if (mac_address_set( - &rte_eth_devices[internals->slaves[i].port_id], + if (rte_eth_dev_default_mac_addr_set( + internals->slaves[i].port_id, &internals->slaves[i].persisted_mac_addr)) { RTE_BOND_LOG(ERR, "Failed to update port Id %d MAC address", internals->slaves[i].port_id); -- 2.14.2