From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 392551B2D3 for ; Fri, 26 Jan 2018 14:16:31 +0100 (CET) Received: by mail-wr0-f194.google.com with SMTP id g21so489720wrb.13 for ; Fri, 26 Jan 2018 05:16:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nqcxlPLryHCqAqnmppkppf9bJy+KKIwWtTGgP0gff5c=; b=gZGEnJl3BJvYEluG7veJGPbZZFABBtT+k4NLVY68sltJy+8j7Sm4W3VLH9qlGj1zOI p4RWHmrEN7KqhxlNQeQUG+iY9S/RSTatcOPdjR79aO1z/KcCqF4Lqlclx3Ol68iVtecQ 5CVh1UZkv7VyMFxTtOsRswGVFKGLme0UQq0JVtqVXyb09OJwKpLRRv5xGHcCx0sW6bLd 28qWlANhg/SRvSkw0hYIKt+Dyblr1nm3QLehuV9i93OqDmtvbiLsf03u0sp/KDOs+TeB PtVhF0bMuvU/G5qbvlbaiOI59opOIX12ZYXQoxQwDACepFZ+12uoQuf5D47N4cR1Acpz WbZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nqcxlPLryHCqAqnmppkppf9bJy+KKIwWtTGgP0gff5c=; b=rNaVy/asPxqLyus7Dx0YyLxxayFsdRroI7O0JjduNKrFoDtCRl10b2GV+A4o+fgE1o 3+YUb7sxDvR+7wT3usJn9nuZ6hWbEg1ZpjRVysJfwRZTcuoTZHqljcGnWg0P8M7aVJt0 4dkG3A0AqbAcG8XcKBzS+2wxXH4AHvNs0nccmc4FlAc4etB6VGVWOYxn8lwBzLGwzd1K 0Y0Jlv8p6AqsSDBEoGjADnCOAD6KyOjqN7q1QUUn7DJsuWHl1nASHAqhfKPW9sBqlQyW wIpPzxEpVfYMytzMSqCK6shhucbLonJCTDoQyAB+EYqkpqnSUd1vNdffJyx4/GhxWYfc BczA== X-Gm-Message-State: AKwxytfvguZjkEXJFB9rtraxtn5GDtVsruZpKkBYwFEJ6m4e5bozJGLt GO4e3y1J17VY6CqPlq7+CGXbU26a0is= X-Google-Smtp-Source: AH8x224zWomUn3Fq7DbP8rX2YrQxiV78QYrt+jZkRIBay8Fnl/fckmv1sDa6GcEo0EgO3s9xMAV/jg== X-Received: by 10.223.209.3 with SMTP id a3mr12837475wri.69.1516972590951; Fri, 26 Jan 2018 05:16:30 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id g15sm7156399wrb.66.2018.01.26.05.16.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 05:16:30 -0800 (PST) From: luca.boccassi@gmail.com To: Qi Zhang Cc: Wei Dai , dpdk stable Date: Fri, 26 Jan 2018 13:13:16 +0000 Message-Id: <20180126131332.15346-46-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180126131332.15346-1-luca.boccassi@gmail.com> References: <20180126131332.15346-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/ixgbe: fix mailbox interrupt handler' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 13:16:31 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/28/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 4dde0d6e4099818118804d0ee203e92a4a7ac313 Mon Sep 17 00:00:00 2001 From: Qi Zhang Date: Wed, 27 Dec 2017 15:22:29 -0500 Subject: [PATCH] net/ixgbe: fix mailbox interrupt handler [ upstream commit 6810c6392656f05b3f9d45806a87ee683337a15b ] Mailbox interrupt handler only takes care of PF reset notification, for other message ixgbe_read_mbx should not be called since it gets chance to break the foreground VF to PF communication. This can be simply repeated by 'testpmd>rx_vlan rm all 0'. Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link up/down") Signed-off-by: Qi Zhang Acked-by: Wei Dai --- drivers/net/ixgbe/ixgbe_ethdev.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index d9cc02f47..f870069a7 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -7571,12 +7571,17 @@ static void ixgbevf_mbx_process(struct rte_eth_dev *dev) struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); u32 in_msg = 0; - if (ixgbe_read_mbx(hw, &in_msg, 1, 0)) - return; + /* peek the message first */ + in_msg = IXGBE_READ_REG(hw, IXGBE_VFMBMEM); /* PF reset VF event */ - if (in_msg == IXGBE_PF_CONTROL_MSG) - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, NULL); + if (in_msg == IXGBE_PF_CONTROL_MSG) { + /* dummy mbx read to ack pf */ + if (ixgbe_read_mbx(hw, &in_msg, 1, 0)) + return; + _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, + NULL); + } } static int -- 2.14.2