From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 2F2921B2E9 for ; Fri, 26 Jan 2018 14:16:43 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id 141so21037202wme.3 for ; Fri, 26 Jan 2018 05:16:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Taycu12ycJ+uvhG6VqFjWpddcqdIX+XKzz2Q4eCCOZk=; b=KLo8X2BDLD2HkF6H/dX76l0SnK+N21WD/lRttO3iPNjojr97OaJNGSI0qvcJvhCtey Ak1Xyeg1U2T/AjwTVrwU8WmcnSbSKBtoZMStBpMHuXbRNAsuGlLIu+yqZSk/NCeRyWLh yBYD1dwmz3wlSFVobY4HUZm7nuLe0+xNDX5eYUyJeq+UCu8NPomFiq4YucsvYW6gz6Kg b6dAnidsn5GvwsGiKi5Fv3t+DlbRFvj5AOzWoGXoRyoONZN0H+kcQZj8g4mkuUf+TSku V6rJfpTRAQTvlb6i3dMh2+ARylDVyqATPTTfxR1xFRveXdadyAWTkBoxbAk/5rHOJ4OK esog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Taycu12ycJ+uvhG6VqFjWpddcqdIX+XKzz2Q4eCCOZk=; b=QkeyGq2khkmeXU4EiQxI/r52XFzu2qJ/GTerg20JCkOIlX5m+IzHffQWh1Gq6afdPp 4heHIBEN3cG1cgXGNR8LguKZjUG6KDW8LN67/PO7RW064uUds7aMEfxXyN2IjsGWqv26 tUONNOQtHwJt7eeijABtgm4qotiHEXX9SXgRbYyKOEReuU9JSqUhfwAVJUt0pvTjCaen AHhAvIUCi/UI4py6oL6FId3KrFg0pfPSNw5CDSzr9GQZAv9uIxqzhPAdZpWzTu8O8R+J Pfcymkeu4MkuzdbrXgx+SExbuzBCS196uOjqQ+4kt3FMVBzKQnM+OI0681yha8TQXkwa 8Azw== X-Gm-Message-State: AKwxytdUY45HJ4/70T50hoXe2Usdq46VUraFBrPppFeVeV976jjrDq45 sF4qckQ1FoZafnnYxrIzZLs= X-Google-Smtp-Source: AH8x224mJTu/IX94+NDs/Ycb3RUe2wo+XNqidFn3UqRD6UGUX7j63RvUxiN4aDJtdyHJinPwWf0IuQ== X-Received: by 10.28.21.136 with SMTP id 130mr9746908wmv.152.1516972602907; Fri, 26 Jan 2018 05:16:42 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id 62sm4466175wml.24.2018.01.26.05.16.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 05:16:42 -0800 (PST) From: luca.boccassi@gmail.com To: Olivier Matz Cc: Maxime Coquelin , Jens Freimann , dpdk stable Date: Fri, 26 Jan 2018 13:13:19 +0000 Message-Id: <20180126131332.15346-49-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180126131332.15346-1-luca.boccassi@gmail.com> References: <20180126131332.15346-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'vhost: fix error code check when creating thread' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 13:16:43 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/28/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 8ae9838b58bc57d386479582af666545cb4c3f23 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Fri, 8 Dec 2017 11:19:49 +0100 Subject: [PATCH] vhost: fix error code check when creating thread [ upstream commit da51d2f6b8b652da8eb9d4b50df4f3f5a24b656f ] On error, pthread_create() returns a positive number (errno). Fix the test on the return value. Fixes: af1475918124 ("vhost: introduce API to start a specific driver") Fixes: e623e0c6d8a5 ("vhost: add reconnect ability") Signed-off-by: Olivier Matz Reviewed-by: Maxime Coquelin Reviewed-by: Jens Freimann --- lib/librte_vhost/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index 84e059513..a95fbfbb9 100644 --- a/lib/librte_vhost/socket.c +++ b/lib/librte_vhost/socket.c @@ -438,7 +438,7 @@ vhost_user_reconnect_init(void) ret = pthread_create(&reconn_tid, NULL, vhost_user_client_reconnect, NULL); - if (ret < 0) + if (ret != 0) RTE_LOG(ERR, VHOST_CONFIG, "failed to create reconnect thread"); return ret; @@ -525,7 +525,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags) if ((flags & RTE_VHOST_USER_CLIENT) != 0) { vsocket->reconnect = !(flags & RTE_VHOST_USER_NO_RECONNECT); if (vsocket->reconnect && reconn_tid == 0) { - if (vhost_user_reconnect_init() < 0) { + if (vhost_user_reconnect_init() != 0) { free(vsocket->path); free(vsocket); goto out; -- 2.14.2