From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id 852E21B31A for ; Fri, 26 Jan 2018 14:16:49 +0100 (CET) Received: by mail-wr0-f171.google.com with SMTP id v31so495897wrc.11 for ; Fri, 26 Jan 2018 05:16:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jNhPyKl6F5Gz8JJ7MBMcIDVkNwfZOWoovJvcJDKLm1E=; b=oQ7ipo3tn44KTiXv5QcuJ/AWM0MjtJAaKqpcAAnB74ONCvMMVV6Z2qxrvPmIfbg/e8 iOR4dMaVHB74AFpLzKwAZ36Zkzk2I7a/803gRLsaLR8Yda28n1bhXUfymsyL/XZEeF8C gPhHHUQRN4tTLzgA5EDHhNaYrnromlfCzpR1JZzgEWI7jI5CCTth3KyfQ4zZC1n9ZKB7 6YOAimVoCSBAsOpkwEb3ExVbKVdY3ZOPWf7TpWzWStvNls965qb9nUmw21K5iZBtF3it oYwKBwCyt0X6PiMrWtfL1bK3bo66hkrfHg1jN562tErhop0Vjyml45pCQ4MQQ7jRjYeV QOlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jNhPyKl6F5Gz8JJ7MBMcIDVkNwfZOWoovJvcJDKLm1E=; b=HbIJNbL1Nm4c3gjkZY/8qC84J30eqlSEFfqxj10EGJeUhijv+jovoybBVhu1A3VTrK tFL3unfsv22jesIAcLUL2hqcbuXXCe0k6E5eqHXqdGGLxMNTTXNDQNu6uRVVwLUwcGVn eQO06ZL/bL37+ksu/W0qDANnY2jOGIx7PVVDGPuT3Na0PUiTJYGDrI7KkPSh9L0AisBN 9NbFXNsPcOrWNDIlJSZyb29UzLSpJvvOfww/u7Wna6GFJqNM3u97MKR6uq4WYBT3Wvr3 4gU9Nc3IOrY8EwMKTaZuckQFFsIBDIOGdt8pNmnKvLvBA+FpQxrGYmAfmYA0n8L9aIK2 C0lA== X-Gm-Message-State: AKwxytcuq3EcB+P4gH8lWLEvQQIJjZiU8/ESFMOmrnmtCv08VifoaOP3 UFRVvBQXXkHJBpvdgYKnZBKmMvt/Gmc= X-Google-Smtp-Source: AH8x226+zuXjKa1F76wwdmXRIpiUan3+L5o5txplgGKfjRTZXZedXviRJghjn8gSXcan4V42y11DrA== X-Received: by 10.223.186.77 with SMTP id t13mr12665714wrg.89.1516972609212; Fri, 26 Jan 2018 05:16:49 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id p32sm9421527wrc.9.2018.01.26.05.16.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 05:16:48 -0800 (PST) From: luca.boccassi@gmail.com To: Anatoly Burakov Cc: Declan Doherty , dpdk stable Date: Fri, 26 Jan 2018 13:13:23 +0000 Message-Id: <20180126131332.15346-53-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180126131332.15346-1-luca.boccassi@gmail.com> References: <20180126131332.15346-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'test: register test as failed if setup failed' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 13:16:49 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/28/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 576481bec56fea8b3a70884dd0895838081b5304 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Fri, 22 Dec 2017 10:21:51 +0000 Subject: [PATCH] test: register test as failed if setup failed [ upstream commit 69a95070111f37fb1c7d7ee11956aff2865f6c11 ] If test set up couldn't be completed, the test was previously shown as succeeding, even though setup failed. Fix this to report test as failed, and count all tests that should've been executed, as failed as well. Fixes: ffac67b1f71b ("app/test: new assert macros and test suite runner") Signed-off-by: Anatoly Burakov Acked-by: Declan Doherty --- app/test/test.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/app/test/test.c b/app/test/test.c index cd0e78458..76941af08 100644 --- a/app/test/test.c +++ b/app/test/test.c @@ -165,8 +165,20 @@ unit_test_suite_runner(struct unit_test_suite *suite) } if (suite->setup) - if (suite->setup() != 0) + if (suite->setup() != 0) { + /* + * setup failed, so count all enabled tests and mark + * them as failed + */ + while (suite->unit_test_cases[total].testcase) { + if (!suite->unit_test_cases[total].enabled) + skipped++; + else + failed++; + total++; + } goto suite_summary; + } printf(" + ------------------------------------------------------- +\n"); -- 2.14.2