From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 160C61B31A for ; Fri, 26 Jan 2018 14:16:51 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id 143so1203522wma.5 for ; Fri, 26 Jan 2018 05:16:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8f7pnQYvh6zdN5qMSckvuc9cLjR3vT9UMaQqvPBHpfc=; b=SBuwVJRmaGCjFo7nKKPlBcX2DP2rAw0p/Ix9KnH0WvunTAUD9i2xkiFnUUvtm2NyAY b4wVw/sxcQmIhwXygpH8wm9zMd7AbGppRN88H5vwX4jdHIh5vD9qlfED+oobRDzlL3RH bIiGSwNiNYM4pwkwf5Kypd+rT1oSiHLrAp/i/0CZ1WL7Xx/5JM39HCV+A8kIUNDEArdH fuBQxDnIz9f3kg44GJyKw+2oCE9GdLrWIGKgwZl75Gx48QPAV1BGbzcmmJdCAZ810taY vEe0eZHy9q5s0TfpDRH/IMpS2fjKMWLI8qn0LTlStp9A/uyvHCzE5PKhnar1ClU1S3Q7 bPqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8f7pnQYvh6zdN5qMSckvuc9cLjR3vT9UMaQqvPBHpfc=; b=V3bTPYzu3axaziz28tfn8cow7s5T5rGQRHkQ3d7+mFA4Sxc3a3zx0DSuPbAZYO3EQa tz2AmY5xUouqRn4USmJS8sa+9mMaxR27xhwuwc6lM6T9xQ9q6NBOW5QMiLPjuh7PkfPI bAMSekNg620NdK9aabD6UGclepg7Xk81RwSR8Co0kzXAJPHhJRoCjpWuP9i8iBkGGBSM bhwhiSLzbhuc+vSyOS4MTEuoUDQjKmFlt3k31S9dGWECj9pdu4mif6Mt7Nb7qDzSkghN ySRzffCCtf7MddB+84uj1hMfGHxTcPjvFakrcAtLCqsjSvyKUZQ++akgMBFe5+zLPiQt ZiTQ== X-Gm-Message-State: AKwxytd0Sj7bHUUbU4uJSlS6QUU4W++RKqwoQIQENzEDYdIgDKpeKcYU XH3Eln0E45A0f/fCwGxmlM4= X-Google-Smtp-Source: AH8x225HsuUm66wnHOFr+VThzBcRA+6co1BthpnuKSToOfgN5NAAywUMR5zQ4i1FhjQEonlJZq3uGw== X-Received: by 10.28.199.201 with SMTP id x192mr10245447wmf.45.1516972610828; Fri, 26 Jan 2018 05:16:50 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id c49sm5233329wrc.48.2018.01.26.05.16.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 05:16:50 -0800 (PST) From: luca.boccassi@gmail.com To: Anatoly Burakov Cc: Cristian Dumitrescu , dpdk stable Date: Fri, 26 Jan 2018 13:13:24 +0000 Message-Id: <20180126131332.15346-54-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180126131332.15346-1-luca.boccassi@gmail.com> References: <20180126131332.15346-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'test/table: fix uninitialized parameter' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 13:16:51 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/28/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 55fa09034cd9d5f2b8256e0619a279d7afa4fdf4 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Thu, 21 Dec 2017 15:53:05 +0000 Subject: [PATCH] test/table: fix uninitialized parameter [ upstream commit 7e60499b6cb941547a147ed66f912aee148ff252 ] delete_bulk() copies metadata to pointers provided by the entries parameter, but in the unit test, they are uninitialized, leading to rte_table attempting to memcpy into random garbage pointers. Memsetting pointer table to zero will prevent that from happening. Fixes: 48f2543cf0a8 ("app/test: add bulk adding and deleting") Signed-off-by: Anatoly Burakov Acked-by: Cristian Dumitrescu --- app/test/test_table_acl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/test_table_acl.c b/app/test/test_table_acl.c index b3bfda4cc..a5d44c5b0 100644 --- a/app/test/test_table_acl.c +++ b/app/test/test_table_acl.c @@ -532,6 +532,8 @@ setup_acl_pipeline(void) struct rte_pipeline_table_entry *table_entries[5]; int key_found[5]; + memset(table_entries, 0, sizeof(table_entries)); + for (n = 0; n < 5; n++) { memset(&keys[n], 0, sizeof(struct rte_table_acl_rule_delete_params)); key_array[n] = &keys[n]; -- 2.14.2