From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id E6BC5A84E for ; Fri, 26 Jan 2018 14:16:52 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id b21so21165014wme.4 for ; Fri, 26 Jan 2018 05:16:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=b4U6sWckMM2Unz9/6t2jLSL9+xHbPL3OvPrQyC+sesg=; b=aT13llGucjyhVAUiXrBIo5YTd43vXpmzzwmaO6EKilQ9PjxSVCmQpk//ahsJvSGSjT ZCsF8Rq/vk/xYm+tgD2A2EI6tev8MmICGmb4odTwxe+eEID53cwOu1asuDtvnNnQvnWw Hkt/7k0gif2jgWGSktszDwHrXTtIRNeRhaa8Yy2+aiXPPoHf9pVkMBiKprp2LEQpn0au 4MxsopCTmBTiD766r33b3/PyT/rQ+EX8ra75vwcE2oB9RFTM8Q77Dsuq/5HDHQMJctOG ezlKC1CtiCYM8QdvUTjQcB3h8OHGnrVp5NsMd+0uEBVqIpwU0VYkomJVdvH6jS5XDS5i yckQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=b4U6sWckMM2Unz9/6t2jLSL9+xHbPL3OvPrQyC+sesg=; b=KHRRaM4wabz7V0nLrkCmwQ4KOf/liAEKUTA8PrubYpEaTN6wAY3xogMQeoakVjwyxB 0XJWg9JShGguAbZINO8TurBED0KDunk3c6IZn+KXQtyg4PIZDxwr9O0Tm7eE7DZLLjdR oaoPvu+Pgp7331YMV0AWADjRIYz/alc4dmgRiz+A6cLnGz0M0hX+PodKmJ21k+FjAT5R orB8LgS00JmWnzD9B1RPWRZmBlzJU/a9wxRyBRK9as2gb7tLLeD3mfjyrnSLni5eNFIb jZOfrDSGFlAleNB/RPE4wOASgG+SgwbzxDXzOLYhG9sp5jH/zbvfKd3ylnao3+mm49Mz 3Hog== X-Gm-Message-State: AKwxytev7rYJy9Dn9W25Ro1kPKpYzHQsS1igUhM3LPBT+UM7IUDSsw0E fHa/stZ4oohR4iA2Uhqo4hY= X-Google-Smtp-Source: AH8x225EHJPmoueweY2bQxk0tyex1SjV/nkokAeuEjgFEqvGuhG4w/4p032frS72/eo9wUJptLi4pQ== X-Received: by 10.28.105.214 with SMTP id z83mr11364976wmh.77.1516972612669; Fri, 26 Jan 2018 05:16:52 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id n104sm12844214wrb.56.2018.01.26.05.16.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 05:16:52 -0800 (PST) From: luca.boccassi@gmail.com To: Anatoly Burakov Cc: dpdk stable Date: Fri, 26 Jan 2018 13:13:25 +0000 Message-Id: <20180126131332.15346-55-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180126131332.15346-1-luca.boccassi@gmail.com> References: <20180126131332.15346-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'test/memzone: fix wrong test' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 13:16:53 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/28/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 5999060471eba43d59501b1146968dfb2ed0ce36 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Thu, 21 Dec 2017 18:19:44 +0000 Subject: [PATCH] test/memzone: fix wrong test [ upstream commit 82da6af3ca4ad9aa1316792f90b2f88cd3020456 ] When reserving memzones in autotest, it makes no sense to expect a failed memzone reserve when we specify both size flags - instead, we should expect a memzone reserved with one of the two sizes. Fixes: af75078fece3 ("first public release") Signed-off-by: Anatoly Burakov --- app/test/test_memzone.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/app/test/test_memzone.c b/app/test/test_memzone.c index 72cda007d..da8738cb4 100644 --- a/app/test/test_memzone.c +++ b/app/test/test_memzone.c @@ -289,10 +289,19 @@ test_memzone_reserve_flags(void) if (hugepage_2MB_avail && hugepage_1GB_avail) { mz = rte_memzone_reserve("flag_zone_2M_HINT", size, SOCKET_ID_ANY, RTE_MEMZONE_2MB|RTE_MEMZONE_1GB); - if (mz != NULL) { + if (mz == NULL) { printf("BOTH SIZES SET\n"); return -1; } + if (mz->hugepage_sz != RTE_PGSIZE_1G && + mz->hugepage_sz != RTE_PGSIZE_2M) { + printf("Wrong size when both sizes set\n"); + return -1; + } + if (rte_memzone_free(mz)) { + printf("Fail memzone free\n"); + return -1; + } } } /* @@ -424,10 +433,19 @@ test_memzone_reserve_flags(void) mz = rte_memzone_reserve("flag_zone_16M_HINT", size, SOCKET_ID_ANY, RTE_MEMZONE_16MB|RTE_MEMZONE_16GB); - if (mz != NULL) { + if (mz == NULL) { printf("BOTH SIZES SET\n"); return -1; } + if (mz->hugepage_sz != RTE_PGSIZE_16G && + mz->hugepage_sz != RTE_PGSIZE_16M) { + printf("Wrong size when both sizes set\n"); + return -1; + } + if (rte_memzone_free(mz)) { + printf("Fail memzone free\n"); + return -1; + } } } return 0; -- 2.14.2