From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 6FCA61B773; Wed, 31 Jan 2018 17:45:07 +0100 (CET) Received: from lfbn-lil-1-110-231.w90-45.abo.wanadoo.fr ([90.45.197.231] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1egvVc-0006VT-8W; Wed, 31 Jan 2018 17:45:17 +0100 Received: by droids-corp.org (sSMTP sendmail emulation); Wed, 31 Jan 2018 17:45:04 +0100 Date: Wed, 31 Jan 2018 17:45:04 +0100 From: Olivier Matz To: Andrew Rybchenko Cc: dev@dpdk.org, stable@dpdk.org, santosh.shukla@caviumnetworks.com, jerin.jacob@caviumnetworks.com Message-ID: <20180131164504.cnfgfwo2x3ftxnaj@platinum> References: <1511539591-20966-1-git-send-email-arybchenko@solarflare.com> <1516713372-10572-1-git-send-email-arybchenko@solarflare.com> <1516713372-10572-2-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516713372-10572-2-git-send-email-arybchenko@solarflare.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-stable] [RFC v2 01/17] mempool: fix phys contig check if populate default skipped X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 16:45:07 -0000 On Tue, Jan 23, 2018 at 01:15:56PM +0000, Andrew Rybchenko wrote: > There is not specified dependency between rte_mempool_populate_default() > and rte_mempool_populate_iova(). So, the second should not rely on the > fact that the first adds capability flags to the mempool flags. > > Fixes: 65cf769f5e6a ("mempool: detect physical contiguous objects") > Cc: stable@dpdk.org > > Signed-off-by: Andrew Rybchenko Looks good to me. I agree it's strange that the mp->flags are updated with capabilities only in rte_mempool_populate_default(). I see that this behavior is removed later in the patchset since the get_capa() is removed! However maybe this single patch could go in 18.02. +Santosh +Jerin since it's mostly about Octeon.