From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 08EEC1B74F for ; Wed, 7 Feb 2018 17:47:54 +0100 (CET) Received: by mail-wr0-f194.google.com with SMTP id 41so1754377wrc.9 for ; Wed, 07 Feb 2018 08:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6t+b6O7Fid5R/mm4PyDsolLSDNnSScfOmPEkVmY7OY8=; b=FdDYa+SUg+hzipIOvHUBCfiWaZm404xd1fmWBmquGuI5x2LFQpyv/mM0RvEXSTT1xu thYtXkVjvKmimTPKj6pgEAQC0dzG1MbRDjttINxwmRoSBdInFMd56lnoIJbTSa69rsFs Xwt8JV2Z9rFlnaGteiduKPOhq1rhbpmKc1V4vUY1brlo5+uRlmoYrqx9/ZjSVnECNqN6 lyCRwUBPff05Yu4EBDSMD2SXYCOTO80tAHOSklGP1nhfUOcDCX1QBXx/y7be7mBHqtnh r9ewI/+JKW8c0HC1oE4tJztAnDR9a3m3LAP5rj+1EJNo+/InrwnSXAsd0p0S9AdeBdIV A2xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6t+b6O7Fid5R/mm4PyDsolLSDNnSScfOmPEkVmY7OY8=; b=py4kOURfBgIUvph0Q6pX7eExqNs0wLxkoMPypa7bSKPih316MLyK/qrJAODJT5bOEk JtyRjUKG9CrIsZl5GJ3MudgCUeDabN8ICudCczo0e9gZnkeRevfdQQOqK//BjDp6MXQd zC6/iQRdSU7YjAHD7V44YuQx1yr9/0aU2OncKKCETg1xAGbgNvu3d6L2xD1XTs/YQh+5 HgXQt7PVqScMqLgycpnFQGC5RGiANp04APJKsFesCAGbCix1LBMWQgdYBnymrag1GmE8 eei1LW8365OG9oyRX9Pgvmb2NW6L+lMKumwlXJ3ov27dcLLf0exlulElRihDGsrNac+3 HkdQ== X-Gm-Message-State: APf1xPBkjQZuTRwgjB03IYaa6ZsrQeHXLUzQW8AhCRfQbLlBBGxN3YTA nw4uXSe53G8SXxmsSnZ2Nc0m06w9yZo= X-Google-Smtp-Source: AH8x224055iqeGcIUArVcVpx3FjJcrCJjfyqf0FSycteOG/FGnO8KSz16UKVoiYFJvcZLOkz1gxnVQ== X-Received: by 10.223.179.209 with SMTP id x17mr6103715wrd.162.1518022073748; Wed, 07 Feb 2018 08:47:53 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id k125sm4160127wmd.48.2018.02.07.08.47.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Feb 2018 08:47:53 -0800 (PST) From: luca.boccassi@gmail.com To: Radu Nicolau Cc: dpdk stable Date: Wed, 7 Feb 2018 16:46:56 +0000 Message-Id: <20180207164705.29052-25-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180207164705.29052-1-luca.boccassi@gmail.com> References: <20180126131332.15346-62-luca.boccassi@gmail.com> <20180207164705.29052-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/bonding: check error of MAC address setting' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 16:47:54 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/09/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 8dc7f949baf607fd4e9a23ca6330f8b739431caa Mon Sep 17 00:00:00 2001 From: Radu Nicolau Date: Thu, 1 Feb 2018 17:21:26 +0000 Subject: [PATCH] net/bonding: check error of MAC address setting [ upstream commit a508daa1a43491ef347774852fe9ee3ff960182c ] Coverity issue: 260405 Fixes: 2efb58cbab6e ("bond: new link bonding library") Signed-off-by: Radu Nicolau --- drivers/net/bonding/rte_eth_bond_api.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c index 29e2de5fd..4b6f1471c 100644 --- a/drivers/net/bonding/rte_eth_bond_api.c +++ b/drivers/net/bonding/rte_eth_bond_api.c @@ -412,8 +412,13 @@ __eth_bond_slave_add_lock_free(uint8_t bonded_port_id, uint8_t slave_port_id) if (internals->slave_count < 1) { /* if MAC is not user defined then use MAC of first slave add to * bonded device */ - if (!internals->user_defined_mac) - mac_address_set(bonded_eth_dev, slave_eth_dev->data->mac_addrs); + if (!internals->user_defined_mac) { + if (mac_address_set(bonded_eth_dev, + slave_eth_dev->data->mac_addrs)) { + RTE_BOND_LOG(ERR, "Failed to set MAC address"); + return -1; + } + } /* Inherit eth dev link properties from first slave */ link_properties_set(bonded_eth_dev, -- 2.14.2