From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id 358AC1B738 for ; Wed, 7 Feb 2018 17:47:57 +0100 (CET) Received: by mail-wr0-f172.google.com with SMTP id t94so1765688wrc.5 for ; Wed, 07 Feb 2018 08:47:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tAERvJ+OgwAjL8L7HkkHI32Ifm6buyns6yNeYCBtxV4=; b=c17sJu9urbzSvsz3R3by9GCCaItq45G4/YxoPtLGx3379SutOVVrdxut9WX03dbjfU xtXgqn/JK+JDKpDhL85nIY3GRmrSVF6CkBPe6tzCTWOXPQ+9quCez3FjQz74yq3eLyP3 fcuDphbyjQn9UVYJ7jrjxdM0xBk3aAYOWFYRHOsJyPkrJwdNj3M0iWfmarN5fGbMD/uZ z88GmNLHgOe3arvpzOuqAgt/QMVvOxU/SdKDCOHWQU57kH7LZH1XJ2TJWYTc0pi2GJzd 1/37suV5rLofnDD0k3eB5TNA/MqIxRVVib5GS9AbEGBo23c9ykOD7x2izOZVciToaMft 7RBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tAERvJ+OgwAjL8L7HkkHI32Ifm6buyns6yNeYCBtxV4=; b=ArUGepTvsXautaDtVzsfneGUFxOTMVupDJrddIi2+OdSlezE7aX8bMPNcdLJrdw6bC suLddjM0odC28bxZoB7V3euwMLg5x6vAiSrPe/qBgM6e602xU/ihPH0oYcDvvFlcpLS2 AuFIyOy55Ze3g7yAfloFBB1HT0mysdEhFUar4JkuBcWrnobqbxEXnVV93+9kA+JCbFby VDH2ruEvM10K6ASyKSijMvTYje+dJYvnaldXs4HI1cnX4x7c7RuIKptnpK0mk+biH0oI tEC+EYFB2fgSLqsEEqYpHv60uJ4xsSC3mdbzlprn6TcQkOr+VaGw4JTTVe+4bgquOfcL Ws5w== X-Gm-Message-State: APf1xPBuzRV68PZBPkjnGUMExysx3Z7bb2mS6zSsM0Sqp2lbxbRqvgxl iby4aBkkTSUIxXGib3jyyZJAxUwBYsQ= X-Google-Smtp-Source: AH8x225ThNImoBpzJwTCknaQ3twA6ZfP8k3rNsz0pmET768rtvpCNcc3s+KBfA9yBzZ//siskRUnfg== X-Received: by 10.223.164.148 with SMTP id g20mr6552424wrb.49.1518022076856; Wed, 07 Feb 2018 08:47:56 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id u79sm2502760wma.10.2018.02.07.08.47.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Feb 2018 08:47:56 -0800 (PST) From: luca.boccassi@gmail.com To: Matan Azrad Cc: dpdk stable Date: Wed, 7 Feb 2018 16:46:58 +0000 Message-Id: <20180207164705.29052-27-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180207164705.29052-1-luca.boccassi@gmail.com> References: <20180126131332.15346-62-luca.boccassi@gmail.com> <20180207164705.29052-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'app/testpmd: fix port index in RSS forward config' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 16:47:57 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/09/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From d793677634673a495d81be51807097278a6ab656 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Mon, 5 Feb 2018 14:09:21 +0000 Subject: [PATCH] app/testpmd: fix port index in RSS forward config [ upstream commit 13cb6fae7991e2213cf8ce39fe3caa1c804511e1 ] When multi-queue ports are configured by the user, the testpmd streams are created by rss_fwd_config_setup() function. This function may configure to the streams either invalid Rx ports or invalid Tx ports. An invalid Tx port is configured when the number of ports is odd. In this case, the last Tx port will be always invalid. An invalid Rx port is configured when NUMA support is configured by the user and the number of forward ports is much smaller than the number of all ports. In this case, also the Tx port is invalid. Change calculations to get valid ports. Fixes: af75078 ("first public release") Signed-off-by: Matan Azrad --- app/test-pmd/config.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index c50b62efd..351df5715 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1262,7 +1262,8 @@ rss_fwd_config_setup(void) * if we are in loopback, simply send stuff out through the * ingress port */ - if (port_topology == PORT_TOPOLOGY_LOOP) + if (port_topology == PORT_TOPOLOGY_LOOP || + txp >= cur_fwd_config.nb_fwd_ports) txp = rxp; fs->rx_port = fwd_ports_ids[rxp]; @@ -1279,11 +1280,7 @@ rss_fwd_config_setup(void) * Restart from RX queue 0 on next RX port */ rxq = 0; - if (numa_support && (nb_fwd_ports <= (nb_ports >> 1))) - rxp = (portid_t) - (rxp + ((nb_ports >> 1) / nb_fwd_ports)); - else - rxp = (portid_t) (rxp + 1); + rxp++; } } -- 2.14.2