From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 1862B1B782 for ; Wed, 7 Feb 2018 17:47:22 +0100 (CET) Received: by mail-wr0-f195.google.com with SMTP id w50so1771675wrc.2 for ; Wed, 07 Feb 2018 08:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=A7/T/FBHD5kUfVOFm4pHhMgEdDlHuJ6d1p1OoJ4PNZM=; b=XEU3QQ6EEhVKwZFSMDn/1XZkMbQw247ogeVdqZKslptp9Ea+Glhsj4XE7Qtg7N+L/4 5GsF5HvVocx76m5TShIoMdisQ9CGfAQWDjB6abZSL3fR1spHw9bG+PDSQXrz2Jn+oxLX qneoMCvK01Iwn/1Ev2OtF47Po66JPue/MLOP1KmmKHmg9K2pZdOJJwaog3kMkmHamM5n 2iNR2MJZ3Ylis6FN8ZutvjfY8k+T8CbsH27d0kztdaerrhoypPFDklQZ7aj9nrHBlpwe C0VC9bQisEDWJhJhmhLd0ElmRoX7IhXIrDQxPamLnob0JpzjLv42YKMAlmWKBBlMnGPR Lkcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=A7/T/FBHD5kUfVOFm4pHhMgEdDlHuJ6d1p1OoJ4PNZM=; b=JjhTW2eo2b5KikRDO/UNWxwh5Quit6N8Z/A9NY4lwBlhYlGlVVIEXDxkzMkTT0kfSv 2WVJqR+y+ysgtOpFH8ql2EFKsSM+o1uH7ZCRXtMueM4vkz+QyQR3uMXPu9G3uPQFRaUe ojI1BB7lQPYakm4CrxV4m1U+Mr3skGrQLeEq0r3K+XItIkXjfduZ4HSg/DQDUeUXoIvA uKp7ldn2McwPiAacdg2bd1dgsovVViVXt5qxRq+W3j1RtHl+i3XdQJJI2gHGNJ2tTl7K bg8mOII7ou830x0pP7LF15Ggi57ImOA9sOK9Ca1VelwXui82ufNAzd0eD+9U5vjONPxM TiCA== X-Gm-Message-State: APf1xPD0zPjYFJYJgK17XezKzyUQdRarBbKoNyXYHEhqr2dIMJeNP4Hm SFzMuCJcVLUn9mMpDDsX8M1q99Lp X-Google-Smtp-Source: AH8x224Nax2Z574PfJN0HVqcYmNGAqqtp9shxAbOBoaQSnlkMXEzqbKlHV6GU4OLligxKtkulR+8+g== X-Received: by 10.223.184.125 with SMTP id u58mr6872887wrf.138.1518022041778; Wed, 07 Feb 2018 08:47:21 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id k7sm2416485wrg.68.2018.02.07.08.47.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Feb 2018 08:47:21 -0800 (PST) From: luca.boccassi@gmail.com To: Fiona Trahe Cc: Radu Nicolau , dpdk stable Date: Wed, 7 Feb 2018 16:46:35 +0000 Message-Id: <20180207164705.29052-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180207164705.29052-1-luca.boccassi@gmail.com> References: <20180126131332.15346-62-luca.boccassi@gmail.com> <20180207164705.29052-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'crypto/qat: fix null auth algo overwrite' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 16:47:22 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/09/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 60c716b84bfa6566612e45bd1c93e36bab37e9dd Mon Sep 17 00:00:00 2001 From: Fiona Trahe Date: Thu, 25 Jan 2018 17:19:14 +0000 Subject: [PATCH] crypto/qat: fix null auth algo overwrite [ upstream commit 4e0955bddb0880949fb12de3a1a8f07eb9ace832 ] If auth algorithm is RTE_CRYPTO_AUTH_NULL and digest_length is 0 in the xform and digest pointer is set in the op, then the PMD may overwrite memory at the digest pointer. With this patch the memory is not overwritten. Fixes: db0e952a5c01 ("crypto/qat: add NULL capability") Signed-off-by: Fiona Trahe Acked-by: Radu Nicolau --- drivers/crypto/qat/qat_crypto.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c index 8b830b80f..a9416790c 100644 --- a/drivers/crypto/qat/qat_crypto.c +++ b/drivers/crypto/qat/qat_crypto.c @@ -1085,8 +1085,9 @@ qat_write_hw_desc_entry(struct rte_crypto_op *op, uint8_t *out_msg) ICP_QAT_FW_LA_DIGEST_IN_BUFFER_SET( qat_req->comn_hdr.serv_specif_flags, ICP_QAT_FW_LA_NO_DIGEST_IN_BUFFER); - auth_param->auth_res_addr = - op->sym->auth.digest.phys_addr; + if (likely(ctx->qat_hash_alg != ICP_QAT_HW_AUTH_ALGO_NULL)) + auth_param->auth_res_addr = + op->sym->auth.digest.phys_addr; digest_appended = 0; } -- 2.14.2