From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id B97661B73A for ; Wed, 7 Feb 2018 17:47:26 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id b21so4582375wme.4 for ; Wed, 07 Feb 2018 08:47:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kFC3hRJs5ovLsgvbAt3dRSI3wp3MSZjl/Wg1Hw0oF7A=; b=mZ0BLDU9HwoMXIw/HcnUUOXSG9aFYMx4BhdLZ7RT2sckzoUM8gyb//Ev0QtxH5ptP2 x05oZTk/OqxOS3J0ow/QUxpNiveWl4OTDqj50D+OrPcInOejuSNDF0kuL9Y2ANzcVp61 dUq/AluxLUSMUet1vmCq2l7l1cmT6K1wJnycdVfZc81Qi+FwYMuj3D/op0943EKEpVfg sBBSBlBud2SUv3jnWGWwbOW9vpGtRLV4HX8wGkBPMenNvEGggp8XZ+bHLwPGWDwHUwI7 Z7Oyjdei8VhDUoWJkjvTJHhJzRlGe5WG0fI8XtFqBgulYJgfTNu7XwHq83c80vI1CNx2 45Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kFC3hRJs5ovLsgvbAt3dRSI3wp3MSZjl/Wg1Hw0oF7A=; b=OOzYrU/lt6y2BV1mv0V0eQ+NznqxjtUguU5CHuorZUVJpoa8LaZfAOxMxbfLp3lM76 YQ6ATjRbEcbhhZCJDV3C/q5KKfkENcla7of6d6oN6OAASVJYUh8MjIuIBZzGLzCNdeWe 5lKFQ0WcY7A13LIPVg7oV3sgOLbejzGzEh0HuZLUuvdLULWZw0ssi+XbdbLBm+0GAfPO o0ZUKr6E8N2Up+WcqH0WECk+7CG3lQo1703w17vyufyx19/GwOWW+AI5I1RcPx8Qm9oS eor5ZN4ROyf2wWzg3exAcYAxwxtLYWPUz0300x6ZNqGvIvuimRrp92p3dBAMKvkHukMC Ho+w== X-Gm-Message-State: APf1xPDktqrFfTIz7jVP9Qzn/eTII4T+vTUmWfdoAhSy9uRffKkHwqa0 zxkLu8anCFu8BQfVVd/yH9/iwKAfwTQ= X-Google-Smtp-Source: AH8x227zrdIFw57/Lo8umDQN+iQZGqRDLAktDcaSpUgYXv5kZDR6sR8ATDMa4I1sxBU2smF3vNsALA== X-Received: by 10.28.31.212 with SMTP id f203mr4821312wmf.122.1518022046469; Wed, 07 Feb 2018 08:47:26 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id f22sm2028815wmi.24.2018.02.07.08.47.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Feb 2018 08:47:25 -0800 (PST) From: luca.boccassi@gmail.com To: Rafal Kozik Cc: Matthew Smith , Michal Krawczyk , dpdk stable Date: Wed, 7 Feb 2018 16:46:38 +0000 Message-Id: <20180207164705.29052-7-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180207164705.29052-1-luca.boccassi@gmail.com> References: <20180126131332.15346-62-luca.boccassi@gmail.com> <20180207164705.29052-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/ena: do not set Tx L4 offloads in Rx path' has been queued to LTS release 16.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 16:47:26 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/09/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 4eb2722d0fe6d4222c543948e357eff6da85d22d Mon Sep 17 00:00:00 2001 From: Rafal Kozik Date: Thu, 25 Jan 2018 16:27:43 +0100 Subject: [PATCH] net/ena: do not set Tx L4 offloads in Rx path [ upstream commit fd617795679019c7aea5ab1e8c85db02cf53f169 ] Information about received packet type detected by NIC should be stored in packet_type field of rte_mbuf. TX L4 offload flags should not be set in RX path. Only fields that could be set in of_flags during packet receiving are information if L4 and L3 checksum is correct. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Reported-by: Matthew Smith Signed-off-by: Rafal Kozik Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 6efe0c3c6..63c423627 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -248,16 +248,17 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf, struct ena_com_rx_ctx *ena_rx_ctx) { uint64_t ol_flags = 0; + uint32_t packet_type = 0; if (ena_rx_ctx->l4_proto == ENA_ETH_IO_L4_PROTO_TCP) - ol_flags |= PKT_TX_TCP_CKSUM; + packet_type |= RTE_PTYPE_L4_TCP; else if (ena_rx_ctx->l4_proto == ENA_ETH_IO_L4_PROTO_UDP) - ol_flags |= PKT_TX_UDP_CKSUM; + packet_type |= RTE_PTYPE_L4_UDP; if (ena_rx_ctx->l3_proto == ENA_ETH_IO_L3_PROTO_IPV4) - ol_flags |= PKT_TX_IPV4; + packet_type |= RTE_PTYPE_L3_IPV4; else if (ena_rx_ctx->l3_proto == ENA_ETH_IO_L3_PROTO_IPV6) - ol_flags |= PKT_TX_IPV6; + packet_type |= RTE_PTYPE_L3_IPV6; if (unlikely(ena_rx_ctx->l4_csum_err)) ol_flags |= PKT_RX_L4_CKSUM_BAD; @@ -265,6 +266,7 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf, ol_flags |= PKT_RX_IP_CKSUM_BAD; mbuf->ol_flags = ol_flags; + mbuf->packet_type = packet_type; } static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, -- 2.14.2