From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 5A2E31B32D for ; Sun, 11 Feb 2018 07:54:05 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BB09220973; Sun, 11 Feb 2018 01:54:04 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 11 Feb 2018 01:54:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=XR2fI+m+JImobsFLMkeCU2g5B3UFTuZZQDWqFmMY15c=; b=EEP96JNT cjGEvkmmJ+eyi3JOj5mQfbijMC5g2ZLVeKH/r/tUor2XW0pewlrADYIhOr+vmUHf D/CQgOWonM6aD0IubLKFZqdvJ+jl/QMpsUAY7jkF3WGZXvny0iMyzGsp9okEnMnP RI0ch0LYy3DRllHhY1Nk2zqcnWnWBwR/nlNqcErorBwW8WBhOBhibJVV3k+nH28x Ju2g1CdQSLJQwHW0Q029X51VIZb7eSJgppaTFTMj7Ha2ICcqxUOxC4IRFFSvEqTW G387Z3gDwANF9V9LdGZA9AiBLyglwSaSFmWUlyyfltKO7ypptwbEXNda5dRRrgYT akoeZPqAIgDTUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=XR2fI+m+JImobsFLMkeCU2g5B3UFT uZZQDWqFmMY15c=; b=bgYotdvOInHlrZAGoWWuzmnwRD4mt8lq+colVYbBR6QmU pchNhDhKqeu6si1T0stt77UFg9z+ELYXQkkMTf31pCAIesuMmEr8LrZ5YJu73QqG 3V109kyYjfhn1tEFd89i+/D1UIz2NmsnuIgc4BHatDVV1tXlRbu1Au4Kdc1XCxrz VYG85mCscjdw19BszIZBu+x7Sb5vd+e8X0x3wcOC1JqmEe9L2Xh+ypbKD/LNIdE1 T8W5w3YEGbL+PDFiOxaom7nwfRqXY9o6BXlneveM+eii1mRFXf0xLXG5AKqCZEB4 mY50wosu12kn4qq3J03ich72t3R9j905Btv6Y20hw== X-ME-Sender: Received: from yliu-mob (unknown [115.150.101.1]) by mail.messagingengine.com (Postfix) with ESMTPA id 5ADC57E34D; Sun, 11 Feb 2018 01:54:03 -0500 (EST) Date: Sun, 11 Feb 2018 14:54:00 +0800 From: Yuanhan Liu To: Matan Azrad Cc: Konstantin Ananyev , Thomas Monjalon , dpdk stable Message-ID: <20180211065400.GK23970@yliu-mob> References: <1517478479-12417-1-git-send-email-yliu@fridaylinux.org> <1517478479-12417-40-git-send-email-yliu@fridaylinux.org> <20180211024653.GC23970@yliu-mob> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-stable] patch 'ethdev: fix port id allocation' has been queued to LTS release 17.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Feb 2018 06:54:05 -0000 On Sun, Feb 11, 2018 at 06:40:27AM +0000, Matan Azrad wrote: > Ho Yuanhan > > From: Yuanhan Liu. Sent: Sunday, February 11, 2018 4:47 AM > > On Thu, Feb 01, 2018 at 05:47:54PM +0800, Yuanhan Liu wrote: > > > Hi, > > > > > > FYI, your patch has been queued to LTS release 17.11.1 > > > > > > Note it hasn't been pushed to > > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd > > k.org%2Fbrowse%2Fdpdk- > > stable&data=02%7C01%7Cmatan%40mellanox.com%7C1d21efdca33143ad70f > > 808d570f9b78f%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C63653 > > 9140229336610&sdata=2Pgtg0sgIoqPmYRPirEjMi2dmJKVKyFljRZHGLIcz5M%3 > > D&reserved=0 yet. > > > It will be pushed if I get no objections before 02/03/18. So please > > > shout if anyone has objections. > > > > It introduced an crash at port allocation. > > And I have now reverted it. Please do a backport if necessary. > > > > Please read the commit log and let me know if it necessary for this version - some secondary scenarios may fail without this patch. > Please send me the crash details, maybe it exposes new bugs in the stable branch. I didn't dig, the error happened at tring to access rte_eth_dev_data[0].name. if (rte_eth_dev_data[i].name[0] == '\0') { What I observed is "rte_eth_dev_data" is NULL, looks like it haven't been initiated yet. --yliu > > > > Thanks. > > > > --yliu > > > > > > --- > > > >From 67abe74f3c09e6f166902c9fc5f4d7f65f7b3007 Mon Sep 17 00:00:00 > > > >2001 > > > From: Matan Azrad > > > Date: Mon, 22 Jan 2018 16:38:18 +0000 > > > Subject: [PATCH] ethdev: fix port id allocation > > > > > > [ upstream commit 8ee892a2385c50427c03db5cef1789babceb5999 ] > > > > > > rte_eth_dev_find_free_port() found a free port by state checking. > > > The state field are in local process memory, so other DPDK processes > > > may get the same port ID because their local states may be different. > > > > > > Replace the state checking by the ethdev port name checking, so, if > > > the name is an empty string the port ID will be detected as unused. > > > > > > Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple > > > process model") > > > > > > Suggested-by: Konstantin Ananyev > > > Signed-off-by: Matan Azrad > > > Acked-by: Thomas Monjalon > > > Acked-by: Konstantin Ananyev > > > --- > > > lib/librte_ether/rte_ethdev.c | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/lib/librte_ether/rte_ethdev.c > > > b/lib/librte_ether/rte_ethdev.c index 9dcb0d2..8ea85cd 100644 > > > --- a/lib/librte_ether/rte_ethdev.c > > > +++ b/lib/librte_ether/rte_ethdev.c > > > @@ -192,8 +192,12 @@ rte_eth_dev_find_free_port(void) > > > unsigned i; > > > > > > for (i = 0; i < RTE_MAX_ETHPORTS; i++) { > > > - if (rte_eth_devices[i].state == RTE_ETH_DEV_UNUSED) > > > + /* Using shared name field to find a free port. */ > > > + if (rte_eth_dev_data[i].name[0] == '\0') { > > > + RTE_ASSERT(rte_eth_devices[i].state == > > > + RTE_ETH_DEV_UNUSED); > > > return i; > > > + } > > > } > > > return RTE_MAX_ETHPORTS; > > > } > > > -- > > > 2.7.4