From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yliu@fridaylinux.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
[66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 4E6011B1CB
for <stable@dpdk.org>; Tue, 13 Feb 2018 12:56:53 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id F0E9C20C21;
Tue, 13 Feb 2018 06:56:52 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
by compute1.internal (MEProxy); Tue, 13 Feb 2018 06:56:52 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org;
h=cc:content-type:date:from:in-reply-to:message-id:mime-version
:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=
fm2; bh=ppf0IwPGPbS9HnWtjgyWdGf7xG30dKVydzXw/kbQQLk=; b=rYKFYEg9
ORvShsNGbAQcIu8CQtKp8lw6qviT9njs13u8K82RAoMbyiI8eie5qNpjay5/BQSK
KdhIuTzB3szabm1wN8kQ0rV6/Tpv0a1+DbhFJUowgG5s6lnbRoST8zitsoRr5jM4
u35hhdip55u/jYBke2xmsoyI9ECscSnFhjLbLJo5h/zFtTmsDa4M/I63eE442Pub
P5fPVCxjEPI1ThVk4HFCik8ie5z8O2cbErqz31JSQCeagdWkPvr9A6fQa79lBCnb
pB6z0pQ4O1GX/YBifTkk6RJ+mFqIypdx2Ybn0cMiaBpTwP3q6EDzC+iecU4G/qmG
Lk5Js93Iulq3zg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=fm2; bh=ppf0IwPGPbS9HnWtjgyWdGf7xG30d
KVydzXw/kbQQLk=; b=hZOg1ZQvM9I3g6F9hblRIFszMXNhVZRvRMkqBZ9N7w446
/U5eRPSBCoXOVDf+oL6P7pUvnakJhrew0mYNi1njyQs6vJAdGkHP6j5cuO+3zt8w
iwPWNWijtBq8f/AUfYLunvWRRNLIhMpQevROV7MkGfT7LkDUuGafyaW6nAitl4Qd
ktprJix2NZzNTXurXz1CRc2FRaUnGij6wuCXjjZqmlKyhZADxBarLVC6HV+rWtfF
Y8mQtvTeaeqIJs3jmfajmNVnxy7x6uSsp27sb0oX/cBzNaB1U5gXgRfhjPWZyU/d
5tuhZsW/VQ+7+6DDw3obenL6Tp1sy1YYcd/AP+cTA==
X-ME-Sender: <xms:hNKCWkPq2Rq9eS-Z_Fv0aAxwEOlKYuiNeNiEa4p5J3nzqQu3UfbADA>
Received: from yliu-mob (unknown [115.150.27.48])
by mail.messagingengine.com (Postfix) with ESMTPA id 239B57E4C7;
Tue, 13 Feb 2018 06:56:51 -0500 (EST)
Date: Tue, 13 Feb 2018 19:56:48 +0800
From: Yuanhan Liu <yliu@fridaylinux.org>
To: Raslan Darawsheh <rasland@mellanox.com>
Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
dpdk stable <stable@dpdk.org>, Shahaf Shuler <shahafs@mellanox.com>
Message-ID: <20180213115648.GF2156@yliu-mob>
References: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org>
<1516808026-25523-41-git-send-email-yliu@fridaylinux.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1516808026-25523-41-git-send-email-yliu@fridaylinux.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [dpdk-stable] patch 'net/mlx5: fix flow type for allmulti
rules' has been queued to LTS release 17.11.1
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Feb 2018 11:56:53 -0000
On Wed, Jan 24, 2018 at 11:31:49PM +0800, Yuanhan Liu wrote:
> Hi,
>
> FYI, your patch has been queued to LTS release 17.11.1
>
> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> It will be pushed if I get no objections before 01/26/18. So please
> shout if anyone has objections.
Per asked Shahaf, this one is now reverted, due to there is a bug.
--yliu
>
> ---
> >From b187189e1371cba301f85e1f11c3c7d0211e4a0a Mon Sep 17 00:00:00 2001
> From: Raslan Darawsheh <rasland@mellanox.com>
> Date: Tue, 5 Dec 2017 11:37:50 +0200
> Subject: [PATCH] net/mlx5: fix flow type for allmulti rules
>
> [ upstream commit 0a40a1363a4df8043f9a7e93289eda2ea52815a7 ]
>
> Chnaged ibv_flow_attr type for allmulti rule to IBV_FLOW_ATTR_MC_DEFAULT
> instead of IBV_FLOW_ATTR_NORMAL, in case allmulti was enabled.
>
> Fixes: 272733b5 ("net/mlx5: use flow to enable unicast traffic")
>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_flow.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index f32dfdd..75ea299 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -432,6 +432,7 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
> /** Structure to pass to the conversion function. */
> struct mlx5_flow_parse {
> uint32_t inner; /**< Set once VXLAN is encountered. */
> + uint32_t allmulti:1; /**< Set once allmulti dst MAC is encountered. */
> uint32_t create:1;
> /**< Whether resources should remain after a validate. */
> uint32_t drop:1; /**< Target is a drop queue. */
> @@ -1206,6 +1207,17 @@ exit_free:
> }
> }
> }
> + if (parser->allmulti &&
> + parser->layer == HASH_RXQ_ETH) {
> + for (i = 0; i != hash_rxq_init_n; ++i) {
> + if (!parser->queue[i].ibv_attr)
> + continue;
> + if (parser->queue[i].ibv_attr->num_of_specs != 1)
> + break;
> + parser->queue[i].ibv_attr->type =
> + IBV_FLOW_ATTR_MC_DEFAULT;
> + }
> + }
> return ret;
> exit_enomem:
> for (i = 0; i != hash_rxq_init_n; ++i) {
> @@ -1311,6 +1323,7 @@ mlx5_flow_create_eth(const struct rte_flow_item *item,
> eth.val.ether_type &= eth.mask.ether_type;
> }
> mlx5_flow_create_copy(parser, ð, eth_size);
> + parser->allmulti = eth.val.dst_mac[0] & 1;
> return 0;
> }
>
> --
> 2.7.4